1. 22 Nov, 2020 1 commit
  2. 19 Nov, 2020 1 commit
    • Felix Ernst's avatar
      Allow having the UrlNavigators below the tab bar · 50ca5af7
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      This commit restores the possibility to have the UrlNavigators below
      the tab bar. This will happen automatically whenever the UrlNavigator
      is removed from the toolbar.
      
      It is also now again possible to have the toolbar on the side. This
      option is disabled while the toolbar contains the UrlNavigators.
      
      This commit makes no changes to the new default which is having the
      UrlNavigators in the toolbar but makes sure that upgrading users won't
      be affected.
      50ca5af7
  3. 13 Nov, 2020 1 commit
  4. 09 Nov, 2020 4 commits
    • Felix Ernst's avatar
      Adress the third round of Angelaccio's review comments · 63f4981f
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      Additionally remove some redundant code concerning UrlNavigator visuals.
      63f4981f
    • Felix Ernst's avatar
      Adress most of the second round of Angelaccio's review comments · 2d4d2ce9
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      This commit applies most suggestions which were made on the MR.
      Most notably the DolphinUrlNavigator class is split up which leads to
      the creation of a DolphinUrlNavigatorsController class.
      
      Additionally some minor coding style and const correctness changes are
      included.
      
      The error value of cached integers is changed from -1 to INT_MIN
      because situations could come up in which -1 would be a valid value.
      2d4d2ce9
    • Felix Ernst's avatar
      Apply Méven Car's suggestions · 42023831
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      42023831
    • Felix Ernst's avatar
      Make UrlNavigators in the toolbar the only option · 37327c9b
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      The UrlNavigators will be automatically added to the toolbar. The Sort By
      action is removed from the default toolbar to make space.
      
      Remove all options to have UrlNavigators outside the toolbar and remove
      those code paths.
      
      Make it so the new NavigatorsWidgetAction contains two UrlNavigators when
      in split view mode. Spacing was also added to align these UrlNavigators
      with the ViewContainers when enough space is available.
      
      Force the toolbar to be either at the top or bottom of the window.
      
      Set a sane sizeHint for DolphinUrlNavigator. It would be better to do this
      in KUrlNavigator in the future.
      
      This commit also contains a changes which should be moved to a separate
      merge requests before this gets merged:
      - Add an expansion animation when split view is enabled by the user
      37327c9b