GitLab

Felix Ernst authored Nov 19, 2020 and Elvis Angelaccio committed Nov 19, 2020

This commit restores the possibility to have the UrlNavigators below
the tab bar. This will happen automatically whenever the UrlNavigator
is removed from the toolbar.

It is also now again possible to have the toolbar on the side. This
option is disabled while the toolbar contains the UrlNavigators.

This commit makes no changes to the new default which is having the
UrlNavigators in the toolbar but makes sure that upgrading users won't
be affected.

To avoid Windows compatiblity issues.

The defaults changed in 37327c9b but
I forgot to also bump the kpartgui version so this commit rectifies
that.

Either the viewport, or the selected folder is used as destination.
The paste action is only added when enabled.

Apparently the icon was not null, because the mimetype was known.
But there was no icon associated with it and we got an
icon which is not null, but has a null pixmap.

Otherwise the value would be Trusted Only, which will
forbid installing local packages

BUG: 426455
FIXED-IN: 20.12

Felix Ernst authored Nov 09, 2020 and Elvis Angelaccio committed Nov 09, 2020

Additionally remove some redundant code concerning UrlNavigator visuals.

Felix Ernst authored Nov 05, 2020 and Elvis Angelaccio committed Nov 09, 2020

This commit applies most suggestions which were made on the MR.
Most notably the DolphinUrlNavigator class is split up which leads to
the creation of a DolphinUrlNavigatorsController class.

Additionally some minor coding style and const correctness changes are
included.

The error value of cached integers is changed from -1 to INT_MIN
because situations could come up in which -1 would be a valid value.

Felix Ernst authored Oct 28, 2020 and Elvis Angelaccio committed Nov 09, 2020

The secondary UrlNavigator is now created when and only when:
- split view mode is activated for the active tab
OR
- switching to a tab that has split view already enabled.
This fixes a crash that occurs when the setting to always start in
split view mode is enabled.

An animation for activating split view is also removed from this and
moved into a separate MR. Another unrelated name change left over from
a previous commit (viewContainers() -> activeViewContainers()) is
dropped.

Felix Ernst authored Sep 20, 2020 and Elvis Angelaccio committed Nov 09, 2020

The UrlNavigators will be automatically added to the toolbar. The Sort By
action is removed from the default toolbar to make space.

Remove all options to have UrlNavigators outside the toolbar and remove
those code paths.

Make it so the new NavigatorsWidgetAction contains two UrlNavigators when
in split view mode. Spacing was also added to align these UrlNavigators
with the ViewContainers when enough space is available.

Force the toolbar to be either at the top or bottom of the window.

Set a sane sizeHint for DolphinUrlNavigator. It would be better to do this
in KUrlNavigator in the future.

This commit also contains a changes which should be moved to a separate
merge requests before this gets merged:
- Add an expansion animation when split view is enabled by the user

Felix Ernst authored Aug 27, 2020 and Elvis Angelaccio committed Nov 09, 2020

This commit adds the DolphinUrlNavigatorWidgetAction::addToToolbarAndSave()
method which changes the users toolbar configuration to contain an
Url Navigator. This way the user doesn't need to do anything manually.

Aside from that a bunch of minor fixes like renaming and reordering

Felix Ernst authored Aug 12, 2020 and Elvis Angelaccio committed Nov 09, 2020

- Split the viewContainers(bool includeInActive) into two methods
    without parameters
- Prevent users from accidently hiding all Url Navigators by
    preventing the dangerous action and then displaying a helpful
    message instead
Unrelated to review comments: Remove a useless line of code

Felix Ernst authored Jun 14, 2020 and Elvis Angelaccio committed Nov 09, 2020

This commit adds a locationInToolbar KToggleAction to switch between
using a location bar to navigate or using a new custom QWidgetAction
in the toolbar.

A big portion of this MR is refactoring because until now the
UrlNavigator was tightly intertwined with the DolphinViewContainer.
With this MR an UrlNavigator for controlling a View can be freely
connected or disconnected with a single method call.

A DolphinUrlNavigator class is created in the process which contains all
Dolphin-specific UrlNavigator code which did previously reside in the
DolphinViewContainer class. Other application parts that belong to
UrlNavigator-management are also moved here.

Ismael Asensio authored Nov 06, 2020 and Elvis Angelaccio committed Nov 08, 2020

This effectively reverts the mutable iterations approach on
2448f88c, and fix crashes
and ghost items when using the filter bar

BUG: 428374

We still need to build them, because they
are also loaded on konqueror.

BUG: 428712
FIXED-IN: 20.12

This commit introduces KUserFeedback in dolphin with some basic data
sources and with a settings page to configure the telemetry values.

There are also a couple custom data sources as proof of concept: a bunch
of settings and the count of available network shares as listed by Solid.

The settings page is shown only if the user feedback framework is
enabled, but currently in Plasma we don't have a global kill switch to
disable it.

At the moment we never show an encouragement message. We need to connect
to the `Provider::showEncouragementMessage()` signal, but first we
should agree to a common way to show a non-annoying message to the users.

BUG: 420037
BUG: 420040
FIXED-IN: 20.12

Zren (Chris Holland) authored Oct 17, 2020 and Elvis Angelaccio committed Nov 04, 2020

Use early returns instead of deeply nested if/else.

Zren (Chris Holland) authored Jul 05, 2020 and Elvis Angelaccio committed Nov 04, 2020

The draw code is more like the last state of D21312 now.

Zren (Chris Holland) authored Jun 12, 2020 and Elvis Angelaccio committed Nov 04, 2020

Based on this kio filepicker patch:
https://github.com/KDE/kio/commit/933887dc334f3498505af7a86d25db7faae91019

Zren (Chris Holland) authored Jul 31, 2019 and Elvis Angelaccio committed Nov 04, 2020

The capacity bars will no longer update when capacity changes. It only
checks the size on init.

Updating during polish event is only a temporarily solution just to
draft code flow for seperating logic from painting. Eventually this
logic update should be in a worker thread detached from blocking the
rendering thread that blocks launching the dolphin window.

Zren (Chris Holland) authored May 20, 2019 and Elvis Angelaccio committed Nov 04, 2020

Draws overtop text that's goes below the baseline like a 'j'. It's
fairly difficult to add extra space below the text as the places view
is a "details" view, so the text is vertically centered in the
widget's "row" as you'd desire it to in the main file view.

We can make the widget 8px taller, adding 4px above and below so
there's adequate room for the capacitybar, but that wastes 4px for
each mount point.

Ideally we'd use the "compact" view, which displays the text/size in a
column beside the icon. However the compact view was not designed to
take up the entire width of the viewport. It's also designed to
overflow with a horizontal scrollbar.

This reverts commit eb441b11.

We'll push it again after we branch 20.12. We don't want to push a too
recent version of KF5 on distros.

!27

This makes the icon view less crowded.

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"