1. 04 Mar, 2018 1 commit
  2. 03 Mar, 2018 5 commits
  3. 18 Feb, 2018 1 commit
    • Nathaniel Graham's avatar
      Also use standard keyboard shortcut for "show/hide hidden files" · b95cc590
      Nathaniel Graham authored
      Use Ctrl+H as another keyboard shortcut to show and hide hidden files, as it is already the standard used in other GTK-based Linux file managers (Nautilus, Nemo, Caja, Thunar, Pantheon Files). This doesn't replace any existing shortcuts, so existing KDE users' muscle memory is retained.
      FEATURE: 390527
      FIXED-IN: KDE Applications 17.12.3
      Test Plan:
      - Ctrl+H now shows and hides hidden files
      - Alt+. still works to do the same
      - F8 still works to do the same
      - Toolbar button still changes state appropriately when any of the three shortcuts are used
      Reviewers: #dolphin, elvisangelaccio
      Reviewed By: elvisangelaccio
      Subscribers: emateli, elvisangelaccio
      Differential Revision: https://phabricator.kde.org/D10558
  4. 15 Feb, 2018 1 commit
  5. 14 Feb, 2018 1 commit
    • Marijo Mustac's avatar
      Add icons to Edit menu · 9a7569a8
      Marijo Mustac authored
      Since Breeze offers such a great palette of action icons I thought we should make use of them which make things also more consistent with other applications.
      Test Plan:
      Show menubar
      Icons are shown in Edit menu
      Reviewers: #dolphin, ngraham
      Reviewed By: #dolphin, ngraham
      Subscribers: ngraham
      Differential Revision: https://phabricator.kde.org/D10503
  6. 13 Feb, 2018 2 commits
    • Elvis Angelaccio's avatar
      Merge branch 'Applications/17.12' · 5f57256a
      Elvis Angelaccio authored
    • Robert Hoffmann's avatar
      Fix resetting "View Modes" preferences to defaults · a618383d
      Robert Hoffmann authored
      Removed call to settings.readConfig() in ViewSettingsTab::loadSettings(),
      because it overwrites default settings with user settings even if called
      from ViewSettingsTab::restoreDefaultSettings().
      Test Plan:
      Settings -> Configure Dolphin -> View Modes:
      Choose "Custom Font", "Choose...": other font settings than preselected;
      alter "Icon Size" slider positions;
      click OK; OK;
      note modified text font next to icons, icon sizes
      Settings -> Configure Dolphin -> View Modes:
      Click "Defaults"
      check "Font" is reset to "System Font";
      check "Icon Size" slider positions are reset to default positions;
      click OK
      check text font next to icons, icon sizes are reset to defaults
      Subscribers: ltoscano, ngraham, elvisangelaccio, michaelh, #dolphin
      Tags: #dolphin
      Differential Revision: https://phabricator.kde.org/D10190
  7. 11 Feb, 2018 2 commits
  8. 10 Feb, 2018 1 commit
    • Elvis Angelaccio's avatar
      Build TerminalPanel also on Windows · 87e8d0ba
      Elvis Angelaccio authored
      terminalpanel.cpp *should* compile on Windows, so there is no reason to
      remove it from the build and use tons of #ifdefs in dolphinmainwindow.
      We still keep the terminal panel disabled on Windows
      (i.e. the two remaining #ifndef Q_OS_WIN in dolphinmainwindow),
      because it is probably not functional.
      But at least we won't break the Windows CI every time
      someone touches the terminal panel code (see e.g. 2e942237).
      Test Plan: Builds on Linux, someone on Windows should test this patch if possible.
      Reviewers: #dolphin, #craft
      Differential Revision: https://phabricator.kde.org/D10006
  9. 05 Feb, 2018 2 commits
  10. 04 Feb, 2018 2 commits
    • Elvis Angelaccio's avatar
      Fix all krazy #include warnings · ecbab345
      Elvis Angelaccio authored
      - "include own header first line"
      - "put config.h in angle brackets line"
      - "do not include QtModule/QtClass line"
      `QElapsedTimer` was implicitly included by
      kfileitemmodelsortalgorithm.h, now we need to explicitly include it in
      We also need to explicitly link to `Qt5::Concurrent`, otherwise we
      cannot `#include <QtConcurrentRun>`.
    • Elvis Angelaccio's avatar
      Use qplatformdefs wrappers · 219e40cf
      Elvis Angelaccio authored
      As recommended by krazy and as kio does.
  11. 03 Feb, 2018 7 commits
  12. 02 Feb, 2018 1 commit
  13. 31 Jan, 2018 2 commits
    • Nathaniel Graham's avatar
      Merge branch 'Applications/17.12' · 0dd0b65b
      Nathaniel Graham authored
    • Nathaniel Graham's avatar
      Let the terminal panel dock to any part of the window · 108e10ca
      Nathaniel Graham authored
      BUG: 362593
      Just what it says: Let the terminal panel sit on the left or right side of the window.
      Test Plan:
      Tested in KDE Neon:
      - Opened terminal panel, unlocked widgets, and tried to drag it to the right or left side of the window: I can
      - Put terminal panel on right side, quit Dolphin and opened Dolphin again: terminal panel appears on the right as expected
      - Put terminal panel on right side, closed terminal panel, quit Dolphin, opened Dolphin, and opened the terminal panel again: terminal panel appears on the right as expected
      - Removed dolphinrc file and opened terminal panel: appears on the bottom
      Reviewers: #dolphin
      Subscribers: elvisangelaccio, anthonyfieroni, cfeck
      Differential Revision: https://phabricator.kde.org/D10189
  14. 30 Jan, 2018 1 commit
  15. 29 Jan, 2018 1 commit
    • Marco Martin's avatar
      base scrolling on the smallest item · 0b130dd5
      Marco Martin authored
      CCBUG: 386379
      after recent highdpi patches on scrolling that delegated it
      completely to the scrollbar, based upon the scrollbar singleStep
      setted to the tallest of the items in the view.
      tough this makes scrolling way too fast, and on folders where just
      few filenames are longer than most we can get a single scrolling
      step almost double the number of lines configured in the
      mouse kcm.
      Using the shortest item instead of the tallest mitigates this problem
      making it a bit more usable
      Test Plan:
      tested on different folders in different view modes both with
      mouse and touchpad
      Reviewers: #dolphin, broulik, ngraham
      Reviewed By: #dolphin, ngraham
      Subscribers: ngraham, plasma-devel
      Tags: #plasma
      Differential Revision: https://phabricator.kde.org/D10102
  16. 27 Jan, 2018 3 commits
  17. 26 Jan, 2018 2 commits
  18. 23 Jan, 2018 1 commit
    • Julian Schraner's avatar
      Add option to sort for original date · ea6a2424
      Julian Schraner authored
      Takes the original date a photo was taken out of the data provided by Baloo & makes it available to the user
      FEATURE: 303645
      Test Plan:
      - Works with a batch of time-tagged photos
      - Can be hidden/shown/sorted like any other property
      Reviewers: #dolphin, ngraham, elvisangelaccio
      Reviewed By: #dolphin, ngraham, elvisangelaccio
      Subscribers: elvisangelaccio, ngraham
      Differential Revision: https://phabricator.kde.org/D10059
  19. 21 Jan, 2018 2 commits
    • Andreas Krutzler's avatar
      Fix renamed file reclaims focus · bba44ae9
      Andreas Krutzler authored
      After renaming a file and then selecting another file immediately the just selected file stays selected.
      BUG: 388555
      Test Plan:
      Steps to reproduce:
      $ mkdir /tmp/test
      $ cd /tmp/test
      $ touch a.tmp b.tmp
      $ dolphin /tmp/test
      In dolphin:
      * select a.tmp
      * <F2>
      * type aaa
      * select b.tmp immediately
      Expected result:
      * a.tmp renamed to aaa.tmp
      * b.tmp stays selected, aaa.tmp stays unselected
      Reviewers: ngraham, michaelh, #dolphin, elvisangelaccio
      Reviewed By: ngraham, michaelh, #dolphin, elvisangelaccio
      Subscribers: emateli, elvisangelaccio, #dolphin
      Differential Revision: https://phabricator.kde.org/D9711
    • Elvis Angelaccio's avatar
      Don't show 'Open Terminal' on Windows · 6cf74d2f
      Elvis Angelaccio authored
      We already disable the TerminalPanel on Windows, we should do the same
      with the 'Open Terminal' action for consistency.
  20. 19 Jan, 2018 1 commit
  21. 18 Jan, 2018 1 commit