1. 19 Nov, 2017 1 commit
    • Andreas Krutzler's avatar
      Fix scrolling during inline renaming causes rename of wrong file · 5bee1889
      Andreas Krutzler authored
      Summary:
      Scrolling during inline renaming accepts the renaming now, like if one would hit Return for example. I chose this approach because it seems the easiest way to fix this.
      This also fixes the “possible” Ui glitch where the renaming KTextField doesn’t move along with the list item. Possible glitch, because I don’t know if this is intentional, but for me it looks broken.
      
      BUG: 378786
      Fixes T7443
      
      Test Plan:
      * Enable "Rename inline" in dolphin settings
      * Go to a folder where you have to scroll through items (many files, big zoom,…)
      * Start to rename a file (context menu, F2, …)
      * Scroll with mouse wheel
      * Rename  accepted -> file is renamed
      
      Reviewers: ngraham, rkflx, #dolphin, elvisangelaccio
      
      Reviewed By: ngraham, rkflx, #dolphin, elvisangelaccio
      
      Subscribers: anthonyfieroni, elvisangelaccio, #dolphin
      
      Maniphest Tasks: T7443
      
      Differential Revision: https://phabricator.kde.org/D8822
      5bee1889
  2. 16 Nov, 2017 2 commits
    • Nathaniel Graham's avatar
      Use KConfig::readEntry()'s default argument properly · e60e3f07
      Nathaniel Graham authored
      Summary: Follow-on patch to D7440 to use KConfig::readEntry()'s default argument properly to reduce some unnecessary code
      
      Test Plan: Tested in KDE Neon. no regressions; by default, all plugins are enabled if the key is not set, and if it is set, user changes to the list are remembered
      
      Reviewers: #dolphin, elvisangelaccio, dfaure, apol
      
      Reviewed By: #dolphin, elvisangelaccio, apol
      
      Differential Revision: https://phabricator.kde.org/D8846
      e60e3f07
    • Nathaniel Graham's avatar
      Turn on Dolphin icon previews by default · bebcf035
      Nathaniel Graham authored
      Summary:
      BUG: 338492
      BUG: 350212
      
      By default, turn on all preview plugins and turn on previews themselves.
      
      Depends on D8347
      
      Test Plan:
      Tested this change in an up-to-date KDE Neon: removed the existing dolphinrc file, deployed Dolphin with the change, and observed that previews are now turned on for all file types for which a plugin exists except for text files, which are in the blacklist because they're mostly useless at nearly all icon sizes (still available in case people want them, though).
      
      Here's how Dolphin's main window looks by default now in KDE Neon:
      
      {F5441184}
      (You may notice that there are no previews for the video files; that's because Neon doesn't ship with any plugins for them, so that would be expected at this point)
      
      And here is how the Settings > General > Preview window looks like now by default:
      {F5435391}
      
      Reviewers: #dolphin, #vdg, markg, abetts, dfaure, aseigo, elvisangelaccio
      
      Reviewed By: #vdg, abetts, dfaure, elvisangelaccio
      
      Subscribers: abetts, cfeck, andreaska, emmanuelp, andreask, markg, broulik, anthonyfieroni, davidedmundson, ltoscano, dfaure, elvisangelaccio, #konqueror
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D7440
      bebcf035
  3. 13 Nov, 2017 1 commit
  4. 11 Nov, 2017 3 commits
    • Ben Cooksley's avatar
      Earlier versions of Qt don't cascade include QUrl so we need to explicitly... · fcbf79f9
      Ben Cooksley authored
      Earlier versions of Qt don't cascade include QUrl so we need to explicitly include it to keep compatibility with Qt 5.7 (as used on FreeBSD)
      fcbf79f9
    • Emirald Mateli's avatar
      Prevent folders from drag and dropping onto themselves in dolphin main view · 99e80c1c
      Emirald Mateli authored
      Summary:
      This patch aims to improve user experience by not allowing the user to drag and drop a folder into itself.
      
      The current behavior shows a red message at the top which can then be closed by the user, instead of relying on that, this patch disables the option of dropping onto self and uses the "Invalid drop target cursor" to highlight the behavior.
      
      BUG: 307747
      
      Since spectacle is unable to screenshot the cursor overlay, find attached a photo of the screen.
      {F3787651}
      
      Test Plan:
      1. Drag a folder.
      2. Drop it onto itself.
      
      Reviewers: #dolphin, elvisangelaccio, ngraham, rkflx, dfaure
      
      Reviewed By: #dolphin, elvisangelaccio, rkflx, dfaure
      
      Subscribers: rkflx, ngraham, elvisangelaccio, dfaure, anthonyfieroni, #konqueror
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D6281
      99e80c1c
    • Andreas Krutzler's avatar
      Prevent "Two clicks renaming" if the selected file/folder is not movable · fa04e375
      Andreas Krutzler authored
      Summary:
      Two clicks renaming doesn't check if the user is actually allowed to rename a file/folder. With this patch, this get fixed.
      Depends on D7647
      
      Reviewers: rkflx, #dolphin, ngraham
      
      Reviewed By: #dolphin, ngraham
      
      Subscribers: elvisangelaccio, ngraham, #dolphin
      
      Differential Revision: https://phabricator.kde.org/D8740
      fa04e375
  5. 10 Nov, 2017 1 commit
  6. 07 Nov, 2017 1 commit
    • Diego Gangl's avatar
      Add more whitespace to the status bar · f047b566
      Diego Gangl authored
      Summary:
      This patch gives the status bar a little more vertical whitespace, prevents the status bar from "jumping up and down" when showing a progress bar, and adds a bit of padding on the sides so the labels are more clearly separated when using dual panes.
      
      Reviewers: #dolphin, #vdg, ngraham, elvisangelaccio
      
      Differential Revision: https://phabricator.kde.org/D8540
      f047b566
  7. 05 Nov, 2017 1 commit
  8. 03 Nov, 2017 1 commit
  9. 01 Nov, 2017 2 commits
    • Laurent Montel's avatar
      Remove not necessary check pointer · d1acb1d5
      Laurent Montel authored
      Test Plan: compile
      
      Reviewers: #dolphin, elvisangelaccio
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D8565
      d1acb1d5
    • Nathaniel Graham's avatar
      Make Saved Search feature discoverable · 64cfc43b
      Nathaniel Graham authored
      Summary:
      FEATURE: 269332
      
      Make Dolphin's Saved Search feature discoverable by adding a button inside the search field. The button only becomes enabled when there is a valid search term. When pushed, it saves the search to the Places panel, providing a visible-by-default way to do this to complement the existing implementation that is only visible in the context menu.
      
      Also harmonized the label text so that it's consistent no matter how you create a saved search (button or context menu)
      
      Test Plan:
      Tested in KDE Neon. Works great:
      {F5449508}
      
      Reviewers: #dolphin, broulik, dfaure, markg, emateli, elvisangelaccio
      
      Reviewed By: #dolphin, markg, emateli, elvisangelaccio
      
      Subscribers: anthonyfieroni, markg, emateli, elvisangelaccio, cfeck, #dolphin
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D8454
      64cfc43b
  10. 27 Oct, 2017 1 commit
    • Andreas Krutzler's avatar
      Two clicks on file/folder to rename · 54542830
      Andreas Krutzler authored
      Summary:
      Make renaming of files/folders faster by clicking a second time on the items text to start renaming.
      BUG: 205157
      
      Test Plan:
      This feature works as follows:
      
      1. select an item by single-click, or one is already selected
      2. wait the "double-click-interval"
      3. click on the items text
      4. none of the cancellations (see below) happens within the double-click-interval
      5. inline-renaming starts
      
      Cancellations:
      * open any file/folder
      * select different item(s)
      * start dragging items
      * Dolphin loses focus
      
      This feature is just enabled while "Double-click to open files and folders" in system-settings and "Rename inline" in Dolphin are enabled.
      
      Reviewers: #dolphin, #kde_applications, elvisangelaccio, emmanuelp, ngraham, markg, rkflx
      
      Reviewed By: #dolphin, #kde_applications, elvisangelaccio, ngraham, rkflx
      
      Subscribers: rkflx, markg, funkybomber, sars, elvisangelaccio, ngraham
      
      Differential Revision: https://phabricator.kde.org/D7647
      54542830
  11. 16 Oct, 2017 1 commit
  12. 14 Oct, 2017 2 commits
  13. 12 Oct, 2017 1 commit
    • Miklos Marton's avatar
      Don't block unmounting when terminal panel's cwd is the mountpoint · bd47eb2e
      Miklos Marton authored
      When unmounting a removable media Dolphin checks if there are
      some files open on the device before performing the unmount.
      If the terminal window in dolphin is open and the to be unmounted path is open,
       the unmount process will be blocked.
      
      This patch sets the terminal window current path to the home directory upon unmount request
       if the terminal directory is set to the mount path.
      
      The unmount request could came from two sources:
      
          The user could hit right click on the media in the dolphin's places panel and hit unmount.
          The user could request an unmount from the indicator applet
      
      This patch was originally written by Arjun AK for the kdelibs4 version
      of Dolphin: https://git.reviewboard.kde.org/r/121613/
      
      BUG: 158264
      FIXED-IN: 17.11.80
      
      Differential Revision: https://phabricator.kde.org/D7847
      bd47eb2e
  14. 04 Oct, 2017 1 commit
    • Nathaniel Graham's avatar
      Move Folders item closer to the top · 1ad3b777
      Nathaniel Graham authored
      Summary:
      Move Folders item closer to the top in Dolphin's find panel. This seems like a more natural placment than after the document types.
      
      Also re-order variable placement to maintain consistency
      
      Test Plan:
      Tested in KDE Neon; works. Before:
      {F4631565}
      
      After:
      {F4631532}
      
      Reviewers: #dolphin, elvisangelaccio
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D8132
      1ad3b777
  15. 03 Oct, 2017 1 commit
    • XY Quadrat's avatar
      Add option to only search for folders · 60ef0fc7
      XY Quadrat authored
      This commit adds an option under "More options" at the search widget.
      It allows to only search for folders and filter out everything else,
      just like the other options (e.g. "Videos") above.
      
      FEATURE: 269334
      REVIEW: 130159
      60ef0fc7
  16. 30 Sep, 2017 2 commits
    • Fabian Vogt's avatar
      Merge branch 'Applications/17.08' · f9bbbd82
      Fabian Vogt authored
      f9bbbd82
    • Fabian Vogt's avatar
      Fix build with Qt 5.10 · c96efc7c
      Fabian Vogt authored
      Summary: QStaticText's constructor with const QString & as argument is now explicit.
      
      Test Plan:
      Did not build before, now does.
      
      Note that this might change the behaviour as the other properties of m_text are now
      kept, which was not the case before. I'm not sure what the expected behaviour here
      is supposed to be.
      
      Reviewers: #dolphin, #kde_applications, cfeck
      
      Reviewed By: cfeck
      
      Subscribers: cfeck, #kde_applications, #dolphin
      
      Differential Revision: https://phabricator.kde.org/D8075
      c96efc7c
  17. 22 Sep, 2017 1 commit
    • Nate Graham's avatar
      Add Bitrate to Dolphin's Additional Information · 76698ff8
      Nate Graham authored
      Summary:
      Adds Bitrate to Dolphin's Additional information columns.
      
      BUG: 368418
      
      Test Plan:
      Tested in KDE Neon. A bitrate column can be added and shows the bitrate in kb/s:
      
      {F3907210}
      
      Works for audio as well as video files!
      
      Reviewers: #dolphin, #kde_applications, broulik, aacid, dfaure, emmanuelp
      
      Reviewed By: #dolphin, #kde_applications, emmanuelp
      
      Subscribers: rkflx, alexeymin, anthonyfieroni
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D7763
      76698ff8
  18. 21 Sep, 2017 1 commit
    • Gregor Mi's avatar
      Select child folder when navigating to a parent folder · 3749b555
      Gregor Mi authored
      Whenever the dolphin view is initialized to show the contents of a new URL
      (e.g. "/home/x/test") it will be checked if the new URL is a parent of the
      previous displayed URL (e.g. "/home/x/test/documents/aaa"). If the check is
      successful, then the common child (in this example: "/home/x/test/documents/")
      folder item will be selected and scrolled into view.
      
      REVIEW: 123253
      BUG: 377392
      CCBUG: 335616
      3749b555
  19. 17 Sep, 2017 3 commits
    • Elvis Angelaccio's avatar
      Merge branch 'Applications/17.08' · 49396318
      Elvis Angelaccio authored
      49396318
    • Emirald Mateli's avatar
      Keep renamed file(s) in view · 478f404b
      Emirald Mateli authored
      When renaming a file, if its new name causes it to scroll out of view,
      Dolphin will not scroll to the location of the new file.
      This patch aims to address that. This affects all view modes.
      
      CCBUG: 354330
      
      Test Plan:
      1. Have many files in a directory (or several files, just zoom in a lot)
      2. Rename a file so that it will move out of view
      
      Differential Revision: https://phabricator.kde.org/D6312
      478f404b
    • Elvis Angelaccio's avatar
      Make sure we always have Shift+Del as shortcut · cdd002c5
      Elvis Angelaccio authored
      After commit 68bb0ec2 the shortcut for the Delete action is not
      necessarily Shift+Del, but whatever the user set in System Setting.
      However DolphinRemoveAction assumes/hardcodes Shift+Del, so we should
      always make sure we have this shortcut around, for consistency.
      
      We just need to add it (if necessary) to the list of shortcuts of the
      action. However:
      
      * for the actual Delete action, we need to append it (if we'd prepend it,
        it would override a custom primary shortcut in the 'Configure Shortcuts' dialog).
      * for DolphinRemoveAction, we need to prepend it in order to have
        Shift+Del (rather than the custom primary shortcut) in the context menu.
      
      Differential Revision: https://phabricator.kde.org/D7655
      cdd002c5
  20. 13 Sep, 2017 1 commit
  21. 12 Sep, 2017 2 commits
  22. 11 Sep, 2017 2 commits
  23. 07 Sep, 2017 1 commit
  24. 03 Sep, 2017 1 commit
  25. 02 Sep, 2017 1 commit
  26. 01 Sep, 2017 1 commit
    • Robert Hoffmann's avatar
      Limit folder panel to home directory if inside home · 94fab8c8
      Robert Hoffmann authored
      Summary:
      Added the option to limit the displayed folders in the folder panel (F7) to the tree below the user's home directory if the current URL is inside the home directory.
      This can be configured in the preferences General/Behaviour tab by checking the corresponding check box.
      
      Reviewers: #dolphin, elvisangelaccio, emmanuelp
      
      Reviewed By: #dolphin, elvisangelaccio, emmanuelp
      
      Subscribers: emmanuelp, elvisangelaccio, #konqueror, #dolphin
      
      Differential Revision: https://phabricator.kde.org/D7477
      94fab8c8
  27. 29 Aug, 2017 1 commit
    • Kai Uwe Broulik's avatar
      Prefer place name over actual name in title bar · 652f57d2
      Kai Uwe Broulik authored
      When inside a place, the address bar already gives it precedence over the actual folder name.
      By doing this in the title bar also, we make it consistent and can mask ugly technical terminology
      like "trash:/" and instead show the nice localized "Trash" place name as well as "Home" instead
      of lowercase internal user name.
      
      BUG: 211959
      
      Differential Revision: https://phabricator.kde.org/D4826
      652f57d2
  28. 27 Aug, 2017 1 commit
  29. 25 Aug, 2017 1 commit
  30. 24 Aug, 2017 1 commit