1. 13 Jul, 2020 1 commit
  2. 24 May, 2020 1 commit
    • Piotr Henryk Dabrowski's avatar
      use KSycoca for updating OpenPreferredSearchTool action · 29e6cf01
      Piotr Henryk Dabrowski authored
      Summary:
      Remove all random updates of OpenPreferredSearchTool action, and
      use KSycoca for updating it as discussed in https://phabricator.kde.org/D22594#663847
      
      Enhancement for D29441 for bug #420911 caused by D22594.
      The bug was fixed by D29442.
      
      CCBUG: 420911
      
      Test Plan:
      ```
      $ cd ${KDE_INSTALL_DIR}/usr/share/applications
      
      $ sudo mv org.kde.kfind.desktop org.kde.kfind.desktop_
      $ kbuildsycoca5
      
      $ sudo mv org.kde.kfind.desktop_ org.kde.kfind.desktop
      $ kbuildsycoca5
      ```
      
      Reviewers: broulik, elvisangelaccio, ngraham, #dolphin
      
      Reviewed By: elvisangelaccio, #dolphin
      
      Subscribers: anthonyfieroni, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D29568
      29e6cf01
  3. 05 Dec, 2019 1 commit
    • Nate Graham's avatar
      Add action for focusing Terminal Panel · 69838a1c
      Nate Graham authored
      Summary:
      Add an action for focusing and de-focusing the Terminal Panel.
      
      FEATURE: 185096
      FIXED-IN 20.04.0
      
      Test Plan:
      - Hit {key Ctrl Shift F4} or click {nav Tools > Focus Terminal Panel} or {nav Control > Tools > Focus Terminal Panel}
      - If the Terminal Panel was closed, it opens and gains focus
      - If the Terminal Panel was open but unfocused, it gains focus
      - If the Terminal Panel was open and focused, focus returns to the view
      
      {F6630289, size=full}
      
      Reviewers: #dolphin, elvisangelaccio, rominf
      
      Reviewed By: #dolphin, elvisangelaccio, rominf
      
      Subscribers: kfm-devel, elvisangelaccio, rkflx, ngraham, #dolphin
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D10959
      69838a1c
  4. 17 Nov, 2019 1 commit
    • Piotr Henryk Dabrowski's avatar
      [Dolphin] Open Preferred Search Tool action · 537dc786
      Piotr Henryk Dabrowski authored
      Summary:
      Added "Open Preferred Search Tool" action to Tools menu.
      
      It runs preferred (topmost) external search tool as configured in the "More Search Tools" menu.
      
      By default Ctrl+Shift+F shortcut is assigned to this action.
      
      FEATURE: 384798
      FIXED-IN: 20.03.80
      
      {F7134238}
      {F7134240}
      {F7134242}
      
      Reviewers: #dolphin, ngraham, elvisangelaccio
      
      Reviewed By: #dolphin, ngraham
      
      Subscribers: pkloc, kfm-devel, kde-doc-english
      
      Tags: #dolphin, #documentation
      
      Differential Revision: https://phabricator.kde.org/D22594
      537dc786
  5. 29 Sep, 2019 1 commit
    • David Hallas's avatar
      Add navigation history to forward/back buttons · eec49bc3
      David Hallas authored
      Summary:
      Adds navigation history to forward/back buttons in the toolbar. This
      changes the forward/back buttons in the toolbar to use the
      KToolBarPopupAction class which provides access to a drop down menu.
      
      Test Plan:
      Browse some folders
      Click the back drop down menu and navigate somewhere
      Click the forward drop down menu and navigate somewhere
      
      FEATURE: 157819
      FIXED-IN: 19.12.0
      
      Reviewers: #dolphin, ngraham, elvisangelaccio, #vdg
      
      Reviewed By: #dolphin, ngraham, elvisangelaccio, #vdg
      
      Subscribers: felixernst, nerdopolist, mart, richardl, ognarb, david.fontanals, abetts, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D19311
      eec49bc3
  6. 01 Sep, 2019 2 commits
    • Nate Graham's avatar
      Add "Add to Places" action to file menu · 7cad80b2
      Nate Graham authored
      Summary:
      It's recommended that actions available in context menus be available in the main menu
      as well for discoverability's sake. This patch does so for the "Add to Places" action.
      
      The action is moved over to the main window, and accessed in the context menu via the
      actionCollection it lives in.
      
      BUG: 390757
      FIXED-IN: 19.08.0
      
      Test Plan:
      - Action still works
      - Action still appears in context menu when relevant
      - Action in the File menu only becomes enabled when only a single directory is selected or nothing is selected
      
      {F7143876}
      
      {F7143877}
      
      {F7143878}
      
      {F7143879}
      
      Reviewers: #dolphin, elvisangelaccio
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: elvisangelaccio, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D22149
      7cad80b2
    • Ismael Asensio's avatar
      [dolphin] Add an action to toggle the searchbar · 3a758690
      Ismael Asensio authored
      Summary:
      Make search action toggle the searchbar instead of just launching it.
      
      The search action in dolphin did only bring up the search bar, but to close it again you had to go to the closing button on the same searchbar.
      This behavior in inconsistent with other dolphin actions which toggle panels or tools.
      
      BEFORE:
      {F7256652}
      
      AFTER:
      {F7256862}
      
      BUG: 344617
      FIXED-IN: 19.12.0
      Closes T8473
      
      Depends on D23075
      
      Test Plan:
      - Enable the search mode: the searchbar appears and the toolbar button gets checked
      - Press the search button again, and it goes back to normal mode.
      - The search button state is coherent with the searchbox
      - Coherence is kept when changing to a split view or different tab
      - Shorcut <Ctrl-F> does not close the searchbar, but moves the focus to it.
      
      Reviewers: #dolphin, ngraham, #vdg, elvisangelaccio
      
      Reviewed By: ngraham, #vdg
      
      Subscribers: ndavis, felixernst, elvisangelaccio, kfm-devel
      
      Tags: #dolphin
      
      Maniphest Tasks: T8473
      
      Differential Revision: https://phabricator.kde.org/D23232
      3a758690
  7. 23 Jun, 2019 1 commit
    • Felix Ernst's avatar
      Add "What's This?" to nearly everything in the main window · bd788a3f
      Felix Ernst authored
      Summary:
      This commit adds "What's This?" help to nearly everything in the
      Dolphin main window (panels, views, buttons, ...). It adds the "?"
      to the title bar so this help can easily be called.
      
      For links in those help texts to work the WhatsThisClickedEvents are
      handled in the main window class. This doesn't work for menus because
      events from them aren't forwarded to the main window for some
      reason so EventFilters are installed for the Control button menus.
      
      Modifying the "Help" menu of KXmlGui is deprecated so no EventFilter
      can be installed in the menubar. Therefore help texts without links
      are provided for the menubar.
      
      Test Plan:
      Check if the event handling might make any problems.
      Check for any big mistakes in the help messages.
      
      Reviewers: #dolphin, elvisangelaccio
      
      Subscribers: broulik, elvisangelaccio, yurchor, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D20471
      bd788a3f
  8. 30 May, 2019 1 commit
    • Alexander Saoutkin's avatar
      Open externally called files/directories in new tabs · 27e3907a
      Alexander Saoutkin authored
      Summary:
      FEATURE: 183429
      FIXED-IN: 19.08.0
      GUI: new cli argument --new-window
      
      Externally called files/directories are opened in a a new tab of an instance of Dolphin that already exists. If any of the given URIs are already open in a tab, then those tabs are activated instead of a new tab being opened.  If there is no instance then the files/directories are opened in a new window. The newly opened file/directory has its tab activated, and consequently, the window is also activated.
      
      When the user clicks "Open In New Window" or "Detach Tab", the files/directories are opened in a new window.
      
      Test Plan:
      [Manual]
      Before testing, set the default file manager in system settings as the newly built Dolphin executable.
      One must also include the new dolphin executable in the $PATH, otherwise some functions will attempt to open the system dolphin instead of the new one.
      
      Furthermore, running two different versions of Dolphin (in particular, where one does not have this patch included) can result in bugs appearing, in particular, new tabs not opening as old instances will not recognise the DBus commands sent to it. However, I see no reason why a user will have two different versions of Dolphin (apart from people like us :D).
      
      Open directories with the help of auxillary programs (i.e. a browser). The files/directories should appear in a new window if an instance does not exist. If an existence already exists, then a new tab should be opened and activated in that instance and the window activated.
      Use QDBusViewer to open folders/items by calling the ShowFolders/ShowItems methods in org.freedesktop.FileManager1 of the Dolphin instance.
      When a user chooses to "Open In New Window"/"Detach Tab" then the files/directories should be opened in a new window.
      
      Reviewers: #dolphin, elvisangelaccio
      
      Subscribers: zzag, dfaure, fvogt, fikrim, magar, fbg13, davidedmundson, kwin, ngraham, elvisangelaccio, anthonyfieroni, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D16648
      27e3907a
  9. 13 May, 2019 1 commit
    • David Hallas's avatar
      Add Bookmark Handling · 2fac50f5
      David Hallas authored
      Summary:
      Add Bookmark Handling. Adds complete bookmark support as provided by
      other KDE applications like Konsole and Konqueror. This allows you to
      bookmark individual folders, create bookmark folders and open them.
      
      Test Plan:
      Go -> Bookmark -> Add Bookmark
      Go -> Bookmark -> [Open the bookmark you selected]
      
      FEATURE: 171366
      
      Reviewers: #dolphin, elvisangelaccio, ngraham
      
      Reviewed By: #dolphin, elvisangelaccio, ngraham
      
      Subscribers: ognarb, meven, loh.tar, cfeck, hein, kfm-devel
      
      Tags: #dolphin
      
      Maniphest Tasks: T5408
      
      Differential Revision: https://phabricator.kde.org/D19926
      2fac50f5
  10. 09 Mar, 2019 1 commit
    • David Hallas's avatar
      New tab placed after current tab when middle-clicking · e602e532
      David Hallas authored
      Summary:
      New tabs should be placed after the currently active tab when using
      middle click.
      
      Test Plan:
      Open new tab from the places panel using middle click, verify that the
      Open new tab from the folders panel using middle click, verify that the
      tab is opened after the current tab
      Open new tab by middle clicking on the Back button, verify that the tab
      is opened after the current tab
      Open new tab by middle clicking on the Forward button, verify that the tab
      is opened after the current tab
      
      FEATURE: 403690
      
      Reviewers: #dolphin, ngraham, elvisangelaccio
      
      Reviewed By: #dolphin, ngraham, elvisangelaccio
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D19201
      e602e532
  11. 24 Aug, 2018 1 commit
    • David Hallas's avatar
      Unify window and tab title · 44a21ea5
      David Hallas authored
      Summary:
      Previously the title of tabs was a prettyfied version of the URL.
      This is inconsistent with the title of the Window and in some cases
      for specials URLs kind of misleading. This commit generalizes the
      code from DolphinMainWindow so that both the DolphinMainWindow title
      and the tab title uses the same function for the title. This also
      means that the 'Show Full Path in Title Bar' also applies to the
      tab title, and also that searches changes the tab title.
      
      FEATURE: 387851
      
      Test Plan: Open a new tab from the places panel and navigate around.
      
      Reviewers: #dolphin, ngraham, elvisangelaccio, markg
      
      Reviewed By: #dolphin, ngraham, markg
      
      Subscribers: markg, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D14442
      44a21ea5
  12. 18 Mar, 2018 1 commit
  13. 04 Mar, 2018 1 commit
  14. 10 Feb, 2018 1 commit
    • Elvis Angelaccio's avatar
      Build TerminalPanel also on Windows · 87e8d0ba
      Elvis Angelaccio authored
      Summary:
      terminalpanel.cpp *should* compile on Windows, so there is no reason to
      remove it from the build and use tons of #ifdefs in dolphinmainwindow.
      
      We still keep the terminal panel disabled on Windows
      (i.e. the two remaining #ifndef Q_OS_WIN in dolphinmainwindow),
      because it is probably not functional.
      
      But at least we won't break the Windows CI every time
      someone touches the terminal panel code (see e.g. 2e942237).
      
      Test Plan: Builds on Linux, someone on Windows should test this patch if possible.
      
      Reviewers: #dolphin, #craft
      
      Differential Revision: https://phabricator.kde.org/D10006
      87e8d0ba
  15. 03 Feb, 2018 1 commit
  16. 18 Jan, 2018 1 commit
  17. 20 Nov, 2017 1 commit
  18. 14 Oct, 2017 1 commit
  19. 12 Oct, 2017 1 commit
    • Miklos Marton's avatar
      Don't block unmounting when terminal panel's cwd is the mountpoint · bd47eb2e
      Miklos Marton authored
      When unmounting a removable media Dolphin checks if there are
      some files open on the device before performing the unmount.
      If the terminal window in dolphin is open and the to be unmounted path is open,
       the unmount process will be blocked.
      
      This patch sets the terminal window current path to the home directory upon unmount request
       if the terminal directory is set to the mount path.
      
      The unmount request could came from two sources:
      
          The user could hit right click on the media in the dolphin's places panel and hit unmount.
          The user could request an unmount from the indicator applet
      
      This patch was originally written by Arjun AK for the kdelibs4 version
      of Dolphin: https://git.reviewboard.kde.org/r/121613/
      
      BUG: 158264
      FIXED-IN: 17.11.80
      
      Differential Revision: https://phabricator.kde.org/D7847
      bd47eb2e
  20. 24 Aug, 2017 1 commit
  21. 12 Mar, 2017 1 commit
  22. 18 Feb, 2017 1 commit
  23. 13 Feb, 2017 1 commit
  24. 02 Feb, 2017 2 commits
  25. 26 Sep, 2016 1 commit
  26. 27 Apr, 2015 1 commit
    • Emmanuel Pescosta's avatar
      Simplify startup split view handling · 5acfb277
      Emmanuel Pescosta authored
      * Instead of setting and resetting GeneralSettings's split view option, just pass it on to openFiles/openDirectories.
      * Require at least one url in openFiles/openDirectories
      
      REVIEW: 123395
      5acfb277
  27. 26 Feb, 2015 1 commit
  28. 04 Feb, 2015 1 commit
  29. 28 Jan, 2015 2 commits
  30. 03 Nov, 2014 1 commit
  31. 02 Nov, 2014 1 commit
  32. 21 Oct, 2014 1 commit
  33. 20 Oct, 2014 1 commit
  34. 18 Oct, 2014 1 commit
  35. 10 Oct, 2014 1 commit
  36. 15 Sep, 2014 1 commit
  37. 12 Sep, 2014 1 commit