1. 10 Sep, 2019 1 commit
  2. 09 Sep, 2019 2 commits
    • Nate Graham's avatar
      Merge branch 'Applications/19.08' · 4c995268
      Nate Graham authored
      4c995268
    • Nate Graham's avatar
      Fix ascending/descending choosers getting unchecked when re-selecting the same sort order · 60d6a3bd
      Nate Graham authored
      Summary:
      When you select the same sort order that's already selected, the currently-checked
      sort order description (the human-readable ascending/descending items) gets unchecked
      in `slotSortTriggered()` yet the ascending/descending items items only get checked in
      `slotSortOrderChanged()`. Because the order hasn't gotten changed, neither one gets
      checked again.
      
      This patch fixes the problem by not unchecking them in the first place.
      
      BUG: 411223
      FIXED-IN: 19.08.2
      
      Test Plan:
      1. Right-click > Sort By > Click the currently-selected sort order
      2. Right-click > Sort By > See that the item for the current ascending/descending setting has not been changed
      
      Reviewers: elvisangelaccio, #dolphin
      
      Reviewed By: elvisangelaccio, #dolphin
      
      Subscribers: broulik, meven, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D23412
      60d6a3bd
  3. 08 Sep, 2019 1 commit
  4. 06 Sep, 2019 1 commit
  5. 05 Sep, 2019 1 commit
  6. 04 Sep, 2019 2 commits
  7. 02 Sep, 2019 9 commits
  8. 01 Sep, 2019 5 commits
    • Nate Graham's avatar
      Add "Add to Places" action to file menu · 7cad80b2
      Nate Graham authored
      Summary:
      It's recommended that actions available in context menus be available in the main menu
      as well for discoverability's sake. This patch does so for the "Add to Places" action.
      
      The action is moved over to the main window, and accessed in the context menu via the
      actionCollection it lives in.
      
      BUG: 390757
      FIXED-IN: 19.08.0
      
      Test Plan:
      - Action still works
      - Action still appears in context menu when relevant
      - Action in the File menu only becomes enabled when only a single directory is selected or nothing is selected
      
      {F7143876}
      
      {F7143877}
      
      {F7143878}
      
      {F7143879}
      
      Reviewers: #dolphin, elvisangelaccio
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: elvisangelaccio, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D22149
      7cad80b2
    • Ismael Asensio's avatar
      [dolphin] Add an action to toggle the searchbar · 3a758690
      Ismael Asensio authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      Summary:
      Make search action toggle the searchbar instead of just launching it.
      
      The search action in dolphin did only bring up the search bar, but to close it again you had to go to the closing button on the same searchbar.
      This behavior in inconsistent with other dolphin actions which toggle panels or tools.
      
      BEFORE:
      {F7256652}
      
      AFTER:
      {F7256862}
      
      BUG: 344617
      FIXED-IN: 19.12.0
      Closes T8473
      
      Depends on D23075
      
      Test Plan:
      - Enable the search mode: the searchbar appears and the toolbar button gets checked
      - Press the search button again, and it goes back to normal mode.
      - The search button state is coherent with the searchbox
      - Coherence is kept when changing to a split view or different tab
      - Shorcut <Ctrl-F> does not close the searchbar, but moves the focus to it.
      
      Reviewers: #dolphin, ngraham, #vdg, elvisangelaccio
      
      Reviewed By: ngraham, #vdg
      
      Subscribers: ndavis, felixernst, elvisangelaccio, kfm-devel
      
      Tags: #dolphin
      
      Maniphest Tasks: T8473
      
      Differential Revision: https://phabricator.kde.org/D23232
      3a758690
    • Nazar Kalinowski's avatar
      Make non-empty textual columns come first in sorting · 7f6d4937
      Nazar Kalinowski authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      Summary:
      
      Current behavior of dolphin in sorting of files with textual columns (e.g. tags) is to show files without this particular textual column (e.g. without tags) first.
      This patch changes this behavior so that dolphin shows the files with some value before the files without any value for chosen sorting method.
      
      BUG: 410538
      
      Test Plan:
      Sorting by name (isn't affected by the patch): https://i.imgur.com/eqbYwyZ.png
      Sorting by textual column ("tags" in this particular example),
      old version (non-tagged files and folders come first): https://i.imgur.com/5KLLujU.png
      patched version (tagged files and folders come first): https://i.imgur.com/oUAeZ2z.png
      
      Reviewers: #dolphin, #vdg, ngraham
      
      Reviewed By: #dolphin, #vdg, ngraham
      
      Subscribers: elvisangelaccio, ngraham, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D23482
      7f6d4937
    • Méven Car's avatar
      Add click to play/pause feature on previews for audio/video · eaec53a7
      Méven Car authored
      Test Plan:
      In dolphin, click on a video or audio preview in the information panel.
      The video or audio preview starts
      
      Reviewers: elvisangelaccio, #dolphin, ngraham
      
      Reviewed By: elvisangelaccio, #dolphin, ngraham
      
      Subscribers: alexde, anthonyfieroni, ngraham, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D22183
      eaec53a7
    • Christoph Feck's avatar
      246a525f
  9. 28 Aug, 2019 1 commit
    • Kai Uwe Broulik's avatar
      Don't store view properties on network shares · db717a21
      Kai Uwe Broulik authored
      Entering a folder will have Dolphin determine whether it can store the view properties in a .directory file within the folder or
      in a generic config location.
      It does so by checking for permissions on the file and parent dir causing various stat calls that potentially block on a slow mount.
      Also, the config reading thereafter can be very slow.
      Moreover, network shares are typically shared between users, so one user's view properties shouldn't affect or be overwritten
      by this Dolphin instance.
      It doesn't resolve symlinks but is surely an improvement over the status quo.
      
      Differential Revision: https://phabricator.kde.org/D23458
      db717a21
  10. 27 Aug, 2019 1 commit
    • Kai Uwe Broulik's avatar
      Always periodically dispatch pending items · f4a1d1b0
      Kai Uwe Broulik authored
      "Local" URLs can also be slow.
      This might jeopardize loading large local directories where a resorting could take place but imho it's better than leaving the user
      wondering when files will finally show up. However, it takes some time for KDirLister to initially signal items having been added,
      and only then our 2 second timer starts.
      Also, stop the timer when loading has completed.
      
      Differential Revision: https://phabricator.kde.org/D23460
      f4a1d1b0
  11. 25 Aug, 2019 3 commits
  12. 24 Aug, 2019 2 commits
  13. 23 Aug, 2019 1 commit
  14. 19 Aug, 2019 1 commit
  15. 14 Aug, 2019 1 commit
  16. 13 Aug, 2019 1 commit
  17. 11 Aug, 2019 6 commits
  18. 08 Aug, 2019 1 commit