1. 10 Sep, 2019 1 commit
  2. 09 Sep, 2019 1 commit
    • Nate Graham's avatar
      Fix ascending/descending choosers getting unchecked when re-selecting the same sort order · 60d6a3bd
      Nate Graham authored
      Summary:
      When you select the same sort order that's already selected, the currently-checked
      sort order description (the human-readable ascending/descending items) gets unchecked
      in `slotSortTriggered()` yet the ascending/descending items items only get checked in
      `slotSortOrderChanged()`. Because the order hasn't gotten changed, neither one gets
      checked again.
      
      This patch fixes the problem by not unchecking them in the first place.
      
      BUG: 411223
      FIXED-IN: 19.08.2
      
      Test Plan:
      1. Right-click > Sort By > Click the currently-selected sort order
      2. Right-click > Sort By > See that the item for the current ascending/descending setting has not been changed
      
      Reviewers: elvisangelaccio, #dolphin
      
      Reviewed By: elvisangelaccio, #dolphin
      
      Subscribers: broulik, meven, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D23412
      60d6a3bd
  3. 04 Sep, 2019 1 commit
  4. 14 Aug, 2019 1 commit
  5. 13 Aug, 2019 1 commit
  6. 29 Jul, 2019 1 commit
  7. 04 Jul, 2019 1 commit
    • Nicolas Fella's avatar
      Use more human-readable sort order descriptions · 95270333
      Nicolas Fella authored
      Summary:
      Anecdotal evidence shows that ascending/descending regularly takes people longer to process than necessary. This patch implements more human-friendly sort order descriptions, in particular:
      
      A-Z/Z-A for text
      Newest first/oldest-first for time
      Lowest first/highest first for rating
      smallest first/largest first for sizes
      
      If there is no string for a particular role defined it will fall back to Ascending/Descending.
      
      I'm aware that not every language uses A-Z. In this case the translator can pick any string that represents the concept of text sorting
      
      Test Plan: Sort view in various ways
      
      Reviewers: #dolphin, #vdg, ngraham
      
      Reviewed By: #dolphin, #vdg, ngraham
      
      Subscribers: ngraham, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D22006
      95270333
  8. 23 Jun, 2019 1 commit
    • Felix Ernst's avatar
      Add "What's This?" to nearly everything in the main window · bd788a3f
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      Summary:
      This commit adds "What's This?" help to nearly everything in the
      Dolphin main window (panels, views, buttons, ...). It adds the "?"
      to the title bar so this help can easily be called.
      
      For links in those help texts to work the WhatsThisClickedEvents are
      handled in the main window class. This doesn't work for menus because
      events from them aren't forwarded to the main window for some
      reason so EventFilters are installed for the Control button menus.
      
      Modifying the "Help" menu of KXmlGui is deprecated so no EventFilter
      can be installed in the menubar. Therefore help texts without links
      are provided for the menubar.
      
      Test Plan:
      Check if the event handling might make any problems.
      Check for any big mistakes in the help messages.
      
      Reviewers: #dolphin, elvisangelaccio
      
      Subscribers: broulik, elvisangelaccio, yurchor, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D20471
      bd788a3f
  9. 05 May, 2019 1 commit
  10. 24 Feb, 2019 1 commit
  11. 24 Oct, 2018 1 commit
  12. 13 Apr, 2018 1 commit
  13. 04 Mar, 2018 1 commit
  14. 03 Mar, 2018 2 commits
  15. 18 Feb, 2018 1 commit
    • Nate Graham's avatar
      Also use standard keyboard shortcut for "show/hide hidden files" · b95cc590
      Nate Graham authored and Nate Graham's avatar Nate Graham committed
      Summary:
      Use Ctrl+H as another keyboard shortcut to show and hide hidden files, as it is already the standard used in other GTK-based Linux file managers (Nautilus, Nemo, Caja, Thunar, Pantheon Files). This doesn't replace any existing shortcuts, so existing KDE users' muscle memory is retained.
      
      FEATURE: 390527
      FIXED-IN: KDE Applications 17.12.3
      
      Test Plan:
      - Ctrl+H now shows and hides hidden files
      - Alt+. still works to do the same
      - F8 still works to do the same
      - Toolbar button still changes state appropriately when any of the three shortcuts are used
      
      Reviewers: #dolphin, elvisangelaccio
      
      Reviewed By: elvisangelaccio
      
      Subscribers: emateli, elvisangelaccio
      
      Differential Revision: https://phabricator.kde.org/D10558
      b95cc590
  16. 21 Nov, 2017 1 commit
  17. 16 Oct, 2017 1 commit
  18. 17 Sep, 2017 1 commit
    • Elvis Angelaccio's avatar
      Make sure we always have Shift+Del as shortcut · cdd002c5
      Elvis Angelaccio authored
      After commit 68bb0ec2 the shortcut for the Delete action is not
      necessarily Shift+Del, but whatever the user set in System Setting.
      However DolphinRemoveAction assumes/hardcodes Shift+Del, so we should
      always make sure we have this shortcut around, for consistency.
      
      We just need to add it (if necessary) to the list of shortcuts of the
      action. However:
      
      * for the actual Delete action, we need to append it (if we'd prepend it,
        it would override a custom primary shortcut in the 'Configure Shortcuts' dialog).
      * for DolphinRemoveAction, we need to prepend it in order to have
        Shift+Del (rather than the custom primary shortcut) in the context menu.
      
      Differential Revision: https://phabricator.kde.org/D7655
      cdd002c5
  19. 24 Aug, 2017 1 commit
  20. 09 Aug, 2017 1 commit
  21. 27 Jul, 2017 1 commit
  22. 13 Mar, 2017 1 commit
    • Elvis Angelaccio's avatar
      Port to KStandardAction::DeleteFile · 68bb0ec2
      Elvis Angelaccio authored
      Summary:
      It was introduced in kconfig 5.25 and it properly handles the shift+del
      shortcut (together with kxmlgui >= 5.30). This allows us to drop the
      custom delete shortcut as well as the shift+del workaround in
      DolphinMainWindow.
      
      Test Plan: Shift+Del still deletes files, without the 'ambiguous shortcut' warning dialog.
      
      Reviewers: emmanuelp
      
      Differential Revision: https://phabricator.kde.org/D5010
      68bb0ec2
  23. 14 Jan, 2017 1 commit
  24. 02 Jan, 2017 1 commit
    • Elvis Angelaccio's avatar
      Properly disable create_dir action in Trash · 24ed38d7
      Elvis Angelaccio authored
      `isFolderWritable` is set in DolphinView::updateWritableState() according to
      KFileItemListProperties::supportsWriting().
      However, `writing=true` does not imply `makedir=true`,
      in an ioslave's .protocol file. An example is the trash protocol.
      
      So we need to enable the `create_dir` action only if the protocol is
      actually able to create folders.
      
      CCBUG: 332463
      REVIEW: 129712
      24ed38d7
  25. 16 Mar, 2016 1 commit
  26. 12 Jan, 2016 1 commit
  27. 24 Feb, 2015 1 commit
  28. 25 Dec, 2014 1 commit
  29. 10 Nov, 2014 1 commit
  30. 21 Oct, 2014 1 commit
  31. 18 Oct, 2014 2 commits
  32. 10 Oct, 2014 1 commit
  33. 14 Sep, 2014 2 commits
  34. 12 Sep, 2014 1 commit
  35. 31 Jul, 2014 1 commit
  36. 27 Jun, 2014 1 commit
  37. 20 Jun, 2014 1 commit