1. 06 Dec, 2018 1 commit
  2. 03 Dec, 2018 1 commit
    • Anton Kreuzkamp's avatar
      KItemListWidget: Use initStyleOption · 037d2c99
      Anton Kreuzkamp authored
      Instead of using QStyleOption::initFrom, let's use
      QGraphicsWidget::initStyleOption, which is made for exactly the purpose
      of KItemListWidget. This is especially important since, according to the
      docs of QGraphicsItem::paint "The widget argument is optional. [...]
      For cached painting, widget is always 0.". Even though currently no code
      in dolphin does cached painting, for the sake of modularity one should
      not rely on widget to be non-null. Using QStyleOption::initFrom does
      assume that, though.
      
      In fact, GammaRay asks the items to do cached painting when attaching it
      to the application, causing it to crash.
      037d2c99
  3. 02 Dec, 2018 4 commits
  4. 01 Dec, 2018 2 commits
    • Thomas Surrel's avatar
      Fix selection when navigating back, with size sorting. · 6100f66a
      Thomas Surrel authored
      Summary:
      KItemListSelectionManager::itemsMoved (called when sorting by size)
      was re-activating anchor selection regardless if we actually were
      doing an anchored selection. This was leading to an incorrect
      selection when navigating back.
      
      BUG: 352296
      
      Test Plan:
      In any folder, sort by size then move to a subfolder. Navigate back
      to the parent folder: only the parent folder should be selected.
      
      Reviewers: #dolphin, elvisangelaccio
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: elvisangelaccio, broulik, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D17042
      6100f66a
    • Thomas Surrel's avatar
      Do not sort twice when changing role and order at the same time · b714604a
      Thomas Surrel authored
      Summary:
      When using the list header to change the role and order, if one
      changes the order to descending and then changes role, dolphin
      also changes the order back to ascending. This results in sorting
      the list of files twice in a row. This patch removes the first
      (useless) sort.
      
      Reviewers: #dolphin, elvisangelaccio
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: elvisangelaccio, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D17111
      b714604a
  5. 30 Nov, 2018 2 commits
  6. 29 Nov, 2018 2 commits
  7. 24 Nov, 2018 1 commit
    • Elvis Angelaccio's avatar
      [PlacesPanel] Port to KFilePlaceEditDialog · b5df5f4d
      Elvis Angelaccio authored
      Summary:
      This patch ports away from the old PlacesItemEditDialog copy,
      which doesn't honour the "applicationLocal" checkbox.
      
      KFilePlaceEditDialog was not exported by KIO, but it will be starting
      from 5.53
      
      BUG: 376619
      FIXED-IN: 19.03.80
      
      Test Plan:
      * Create a new place ("Add Entry" from the panel context menu) and check the "only show in dolphin" checkbox
      * Edit an existing (global) place and check the "only show in dolphin" checkbox
      
      Reviewers: #dolphin
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D16824
      b5df5f4d
  8. 21 Nov, 2018 3 commits
  9. 20 Nov, 2018 2 commits
  10. 19 Nov, 2018 1 commit
    • Thomas Surrel's avatar
      Show the Delete context menu entry even when disabled · 1340e985
      Thomas Surrel authored
      Summary:
      This is consistent with the HIG, and the 'Rename' entry in
      the context menu already behaves like that.
      
      Test Plan:
      Right click on /home. The context menu should contained
      the 'Delete' entry, but it should be disabled.
      
      Reviewers: #dolphin, #vdg, ngraham
      
      Reviewed By: #dolphin, #vdg, ngraham
      
      Subscribers: ngraham, romangg, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D17012
      1340e985
  11. 17 Nov, 2018 3 commits
    • Thomas Surrel's avatar
      Do not disconnect all StorageAccess signals when unmounting · e710a643
      Thomas Surrel authored
      Summary:
      The problem is caused by the fact device interfaces returned by
      Solid (e.g. item->device().as<Solid::StorageAccess>()) are not
      full objects, but only references/pointers to a per-device-object,
      i.e. requesting the same interface for a device will return the same
      address every time.
      
      If the interface is used used in multiple places, calling disconnect
      on the interface address disconnects the signals for all users.
      
      BUG: 400992
      
      Test Plan:
      In Dolphin, mount a local partition (e.g. a Windows partition)
      then unmount it (right click on it in Places, then Unmount).
      Try to access it again by clicking on it in Places, we should
      get access to it correctly.
      
      Reviewers: #dolphin, #frameworks, bruns, elvisangelaccio
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: elvisangelaccio, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D16857
      e710a643
    • Chris Rizzitello's avatar
      Improve Ux for the places panel's hidden items · c900f7d2
      Chris Rizzitello authored
      Summary:
      BUG: 400860
      FIXED-IN: 18.12.0
      
      Clean up the context menu for the places panel.
       - Change Text "Show All Entries" -> "Show Hidden Places"
       - Use State dependent icon (like hidden files)
       - Disable instead of hide if not places are hidden.
       - Toggle to unchecked if last item of group is unhidden.
      
      Create a copy of this "Show Hidden Places" entry in the main dolphin menu View->Places.
      
      Test Plan:
      With Hidden Places
      {F6398756}
      {F6398759}
      Context Menu:
      {F6398762}
      {F6398761}
      
      Without Hidden Places.
      {F6414694}
      {F6414696}
      
      Reviewers: #dolphin, #vdg, elvisangelaccio, ngraham
      
      Reviewed By: #dolphin, #vdg, elvisangelaccio, ngraham
      
      Subscribers: cfeck, elvisangelaccio, veqz, davidc, ngraham, kfm-devel
      
      Tags: #dolphin
      
      Maniphest Tasks: T8349
      
      Differential Revision: https://phabricator.kde.org/D16767
      c900f7d2
    • Harald Sitter's avatar
      move kcrash link to dolphin app (which is the effective user) · a4cddf75
      Harald Sitter authored
      Summary:
      to successfully use kcrash when linking with as-needed (which is a default
      flag on many linux distros) one also needs to call KCrash::initialize.
      this call happens in the app's main.cpp. as such the kcrash link target
      on the dolphinprivate library doesn't do anything for dolphinprivate but
      only kicks into action for dolphin itself.
      to avoid confusion and make it clear that kcrash is only initialized in the
      application scope the KF5::Crash link target is now on the application
      target, not the library target.
      
      (this makes no difference in the output, kcrash was still correctly linked
       via dolphinprivate; but only for kdeinit_dolphin, dolphinprivate did
       not get linked to it with as-needed)
      
      Test Plan: builds; links as expected
      
      Reviewers: elvisangelaccio, #dolphin
      
      Reviewed By: elvisangelaccio, #dolphin
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D16896
      a4cddf75
  12. 16 Nov, 2018 2 commits
  13. 14 Nov, 2018 1 commit
  14. 13 Nov, 2018 1 commit
  15. 11 Nov, 2018 3 commits
  16. 08 Nov, 2018 1 commit
    • Shubham  .'s avatar
      Warn user before renaming the file/folder to start with a ' . ' · b08cea86
      Shubham . authored
      Summary: For normal "casual" linux users, renaming the file/folder starting with dot may get irritating, they will be wondering their file is deleted.
      
      Test Plan:
      1. Make new file/folder.
      2. Rename it to .foo
      3. Question dialog appears.
      
      Reviewers: elvisangelaccio, ngraham, pino
      
      Reviewed By: elvisangelaccio, ngraham
      
      Subscribers: cfeck, emateli, elvisangelaccio, pino, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D15980
      b08cea86
  17. 07 Nov, 2018 1 commit
  18. 05 Nov, 2018 1 commit
  19. 04 Nov, 2018 2 commits
  20. 02 Nov, 2018 1 commit
  21. 01 Nov, 2018 1 commit
  22. 28 Oct, 2018 1 commit
  23. 27 Oct, 2018 3 commits