1. 01 Aug, 2021 1 commit
    • Felix Ernst's avatar
      Fix width issues when un-maximizing Dolphin · 7edce5a0
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      Before this commit un-maximizing or to be more precise instantly
      changing the size of the window by a large amount could potentially
      change the width of the sidebars, the viewContainers and the window
      itself to unexpected/undesired widths.
      
      This happened because the spacing calculation is triggered when the
      primary ViewContainer is resized but at this point in time some of
      the other widgets, especially the secondary ViewContainer and the
      navigatorsWidget have generally not been resized yet. Therefore the
      width and spacing calculations are based on partly updated and
      partly outdated values leading to wrong results.
      
      This commit makes it so calculation of spacings is delayed until
      all widths have been updated.
      
      Yes, spacing probably should not have the power to resize the
      window but unfortunately the spacing can not be set to be less
      forceful when taking space because otherwise the UrlNavigators
      will take all space they can get with their
      QSizePolicy::MinimumExpanding.
      
      BUG: 430521
      FIXED-IN: 21.08
      7edce5a0
  2. 28 Jul, 2021 1 commit
    • Nate Graham's avatar
      Revert "Don't session-restore invalid paths" · ea7d4f05
      Nate Graham authored
      This reverts commit c733b3aa.
      
      There are people who prefer the old behavior of session-restoring all
      paths including the ones which are currently inaccessible. The idea is
      that Dolphin is like a web browser; if a website is not currently
      available, the browser tells you that instead of silently discarding the
      URL and showing you the homepage. Doing this can be considered a form
      of data loss.
      
      In addition, the reason for the change was to prevent Dolphin from
      showing invalid paths on launch for unmounted removable disks, but that
      specific case was fixed separately by switching to ~ for any tabs/views
      that were showing locations on a just-unmounted removable disk. So you
      will never run into the problem if yo unmount a disk in Dolphin and then
      close it.
      
      Accordingly, let's revert the change because it causes more problems than
      it resolves.
      
      BUG: 439864
      CCBUG: 427619
      FIXED-IN: 21.08
      ea7d4f05
  3. 27 Jul, 2021 1 commit
  4. 26 Jul, 2021 1 commit
  5. 24 Jul, 2021 1 commit
  6. 17 Jul, 2021 1 commit
  7. 13 Jul, 2021 1 commit
    • Christian Muehlhaeuser's avatar
      Ensure stable sort order when sorting by size · baaf0c29
      Christian Muehlhaeuser authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      Folders with equal size caused the sort operation to become unstable,
      as the result of lessThan was non-deterministic.
      
      We need the fallback mechanisms at the bottom of the function to
      resovle the situation and provide a stable sort order.
      
      This also fixes expanding the contents of a folder into the wrong
      parent.
      
      BUG: 433247
      FIXED-IN: 21.08
      baaf0c29
  8. 10 Jul, 2021 1 commit
  9. 09 Jul, 2021 2 commits
  10. 07 Jul, 2021 1 commit
  11. 05 Jul, 2021 1 commit
  12. 04 Jul, 2021 11 commits
  13. 03 Jul, 2021 3 commits
  14. 30 Jun, 2021 1 commit
  15. 29 Jun, 2021 1 commit
    • Mufeed Ali's avatar
      Show a "Loading..." placeholder text · 152a7b4f
      Mufeed Ali authored and Nate Graham's avatar Nate Graham committed
      Since a placeholder text is being used when the folder is empty, it
      also makes sense to show a similar placeholder text when the view is
      still loading, especially now that the status bar which previously
      contained a loading indicator now disappears when a folder is loading.
      152a7b4f
  16. 27 Jun, 2021 1 commit
    • Méven Car's avatar
      KFileItemModel: Allow to group files and folder together · a3559a19
      Méven Car authored
      When folders size is available and unless sort dir first is set, folders
      and files can be grouped together in the regular size groups.
      
      Without this you can end up with multiple groups being added each time a
      folder size alternates with a file size.
      
      Relates to d520b417
      a3559a19
  17. 25 Jun, 2021 1 commit
  18. 22 Jun, 2021 3 commits
    • Felix Ernst's avatar
      Merge branch 'release/21.04' addendum · 823e99fe
      Felix Ernst authored
      This should have belonged to my previous merge
      480b3067 but somehow I managed to
      miss this one line.
      
      It was written by Derek Christ as part of
      dc3beae3.
      823e99fe
    • Felix Ernst's avatar
      Merge branch 'release/21.04' · 480b3067
      Felix Ernst authored
      480b3067
    • Derek Christ's avatar
      Fix shift-action modifier in context menu · dc3beae3
      Derek Christ authored and Méven Car's avatar Méven Car committed
      Before this patch, the shift-action modifier in context menus did not
      work when a sub-context menu is open, that does not have the main
      context menu as its parent.
      The new fix installs an event filter on QApplication whenever a new
      context menu is opened to make the context menu aware of shift-presses
      even when a sub-context menu is in focus.
      
      BUG: 425997
      FIXED-IN: 21.04
      dc3beae3
  19. 18 Jun, 2021 3 commits
  20. 14 Jun, 2021 1 commit
  21. 13 Jun, 2021 1 commit
  22. 12 Jun, 2021 1 commit
    • Felix Ernst's avatar
      Remove the filter action from the toolbar · 63d19463
      Felix Ernst authored
      This commit removes the "toggle_filter" action from the default
      toolbar configuration. It is not quite important enough to be
      always visible on the toolbar by default. Instead it is easily
      accessible through the hamburger menu and the menu bar.
      
      The filter is only really necessary if one has a lot of items in
      the current location and one knows exactly how to identify a
      certain item among them by the name which probably isn't how most
      people browse their files.
      
      There are also some more advanced use-cases but advanced users
      will be able to either learn the keyboard shortcut or move this
      action back to the toolbar.
      63d19463
  23. 08 Jun, 2021 1 commit
    • Felix Ernst's avatar
      Add "Sort By" to the hamburger menu · 5271943a
      Felix Ernst authored
      People seem to use the "Sort By" menu often enough that it should
      be available through the hamburger menu.
      
      Before this change one could only sort the view through the right-
      click context menu, using the details view mode or by using the
      actions from the menu bar.
      5271943a