1. 01 Aug, 2021 1 commit
    • Felix Ernst's avatar
      Fix width issues when un-maximizing Dolphin · 7edce5a0
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      Before this commit un-maximizing or to be more precise instantly
      changing the size of the window by a large amount could potentially
      change the width of the sidebars, the viewContainers and the window
      itself to unexpected/undesired widths.
      This happened because the spacing calculation is triggered when the
      primary ViewContainer is resized but at this point in time some of
      the other widgets, especially the secondary ViewContainer and the
      navigatorsWidget have generally not been resized yet. Therefore the
      width and spacing calculations are based on partly updated and
      partly outdated values leading to wrong results.
      This commit makes it so calculation of spacings is delayed until
      all widths have been updated.
      Yes, spacing probably should not have the power to resize the
      window but unfortunately the spacing can not be set to be less
      forceful when taking space because otherwise the UrlNavigators
      will take all space they can get with their
      BUG: 430521
      FIXED-IN: 21.08
  2. 03 Jun, 2021 1 commit
  3. 18 Jan, 2021 1 commit
    • Norbert Preining's avatar
      Show button to open knetattach inline with URL nav on remove:// view · 33270dd4
      Norbert Preining authored
      This is a backport of b1cadeba
        From b1cadeba Mon Sep 17 00:00:00 2001
        From: Nate Graham <nate@kde.org>
        Date: Tue, 15 Dec 2020 23:03:00 -0700
        Subject: [PATCH] Show button to open knetattach inline with URL nav on
         Remote:// view
        In conjunction with
        the net result is to hide the knetattach launcher in the view, and show
        it inline with Dolphin's URL navigator toolbar when viewing the
        remote:// view, just like how we add an "Empty Trash" button when
        viewing trash://.
      The backport ensures that even with frameworks << 5.78 only one network
      button is shown.
      BUG: 431626
  4. 15 Jan, 2021 1 commit
  5. 09 Jan, 2021 1 commit
  6. 06 Jan, 2021 1 commit
    • Felix Ernst's avatar
      Fix location bar being wrongly aligned on first startup · 0cee94ce
      Felix Ernst authored
      When starting Dolphin the very first time, the spacing in front of the
      location bar is wrong. This commit fixes this by completely updating
      all cached geometry every time adjustSpacing() is called. Because this
      happens once on a timer 100 ms after every url change, it will happen
      once shortly after the window is shown. At that point all geometry is
      where it should be and spacing calculation works as expected.
      The ViewContainer geometry retrieval is refactored into a small nested
      helper class in DolphinNavigatorsWidgetAction by the name
      Previously the logic of that class was divided between DolphinTabPage
      and DolphinNavigatorsWidgetAction.
      BUG: 429447
      FIXED-IN: 21.04.0
  7. 27 Dec, 2020 1 commit
    • Nate Graham's avatar
      Make it more obvious that you can connect to servers on remote:/ page · b14f98de
      Nate Graham authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      Right now it is not super obvious how you connect to a remote server
      in Dolphin when you already know the URL. Users will go to the
      "Network" item in the Places panel, but from there it is not totally
      clear. The "Add Network Folder" icon in the view opens a complicated
      wizard and it's also a bit of an odd UX to have it living in the view as
      opposed to being a toolbar button.
      Old hands and developers know that the URL navigator is, well, a URL
      navigator, and as such, it accepts arbitrary URLs from any view.
      However this may not be obvious to other more casual users, for
      two reasons:
      1. The URL navigator is in breadcrumbs view nearly all of the time and
         by default, so may users may not know that it can accept text at all
      2. Even when it's displaying URLs, they are almost always local paths,
         so users may not make the connection that it can accept remote URLs
         rather that just local paths
      To improve the discoverability of this fea...
  8. 22 Nov, 2020 1 commit
  9. 19 Nov, 2020 1 commit
    • Felix Ernst's avatar
      Allow having the UrlNavigators below the tab bar · 50ca5af7
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      This commit restores the possibility to have the UrlNavigators below
      the tab bar. This will happen automatically whenever the UrlNavigator
      is removed from the toolbar.
      It is also now again possible to have the toolbar on the side. This
      option is disabled while the toolbar contains the UrlNavigators.
      This commit makes no changes to the new default which is having the
      UrlNavigators in the toolbar but makes sure that upgrading users won't
      be affected.
  10. 13 Nov, 2020 1 commit
  11. 09 Nov, 2020 4 commits
    • Felix Ernst's avatar
      Adress the third round of Angelaccio's review comments · 63f4981f
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      Additionally remove some redundant code concerning UrlNavigator visuals.
    • Felix Ernst's avatar
      Adress most of the second round of Angelaccio's review comments · 2d4d2ce9
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      This commit applies most suggestions which were made on the MR.
      Most notably the DolphinUrlNavigator class is split up which leads to
      the creation of a DolphinUrlNavigatorsController class.
      Additionally some minor coding style and const correctness changes are
      The error value of cached integers is changed from -1 to INT_MIN
      because situations could come up in which -1 would be a valid value.
    • Felix Ernst's avatar
      Apply Méven Car's suggestions · 42023831
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
    • Felix Ernst's avatar
      Make UrlNavigators in the toolbar the only option · 37327c9b
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      The UrlNavigators will be automatically added to the toolbar. The Sort By
      action is removed from the default toolbar to make space.
      Remove all options to have UrlNavigators outside the toolbar and remove
      those code paths.
      Make it so the new NavigatorsWidgetAction contains two UrlNavigators when
      in split view mode. Spacing was also added to align these UrlNavigators
      with the ViewContainers when enough space is available.
      Force the toolbar to be either at the top or bottom of the window.
      Set a sane sizeHint for DolphinUrlNavigator. It would be better to do this
      in KUrlNavigator in the future.
      This commit also contains a changes which should be moved to a separate
      merge requests before this gets merged:
      - Add an expansion animation when split view is enabled by the user