1. 14 Apr, 2020 1 commit
  2. 13 Apr, 2020 1 commit
    • Alexander Lohnau's avatar
      Dolphin Services: Launch Deb/Rpm archives with QDesktopServices · 514d9c8f
      Alexander Lohnau authored
      Summary:
      When you are inside the services store and you choose to install a deb/rpm package
      they open in the default application (mostlikely a package installer utility like discover).
      
      PS: I have written some ideas/questions, maybe you can comment on them :-) ?
      
      Test Plan:
      Tests still pass, try out what was described in the summary.
      A product which has a deb/rpm package is for example: `Jetbrains Dolphin Plugin`
      
      Reviewers: #dolphin, elvisangelaccio, ngraham, aspotashev
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D28795
      514d9c8f
  3. 12 Apr, 2020 1 commit
    • Martin Tobias Holmedahl Sandsmark's avatar
      Fix crashing on starting and quitting · 35b4c6d4
      Martin Tobias Holmedahl Sandsmark authored
      QCollator (especially with Qt 5.14 and ICU 65.1) is very unhappy with
      threads.
      
      To avoid having to lock and unlock the mutex everywhere (and ensure it
      is unlocked before calling other things that might lock it, etc.), we do
      it as locally as possible. Even if for some reason Qt and ICU make
      QCollator threadsafe in the future locking here should have minimal
      impact.
      
      BUG: 419585
      
      Differential Revision: https://phabricator.kde.org/D28659
      35b4c6d4
  4. 06 Apr, 2020 1 commit
  5. 05 Apr, 2020 1 commit
    • Nate Graham's avatar
      Use same logic for "no extension" case with Duplicate feature · 9b82b08f
      Nate Graham authored
      Summary:
      In the "no extension" case, we weren't separating out the path and the original filename,
      breaking the feature for languages where the word "copy" would be at the beginning of the
      filename, not after it (e.g. "copia de foo" in Spanish, and similar in other romance
      languages). This patch fixes that by separating the original path and filename in the no
      extension case as is done for the other case, which should solve the issue.
      
      BUG: 419070
      FIXED-IN: 20.04.0
      
      Test Plan:
      No changes in English; should fix the issue in Spanish once new translations are done
      (see https://bugs.kde.org/show_bug.cgi?id=419070 for details)
      
      Reviewers: #dolphin, elvisangelaccio, arojas, meven, pino, #localization
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: aacid, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D28227
      9b82b08f
  6. 30 Mar, 2020 1 commit
  7. 28 Mar, 2020 1 commit
  8. 25 Mar, 2020 1 commit
    • Tranter Madi's avatar
      Update dragCursor while dragging · b96c48b4
      Tranter Madi authored
      Summary:
      While dragging, the user could want to change the modifier, so we should call event->acceptProposedAction() to do update the dragCursor.
      
      FIXED-IN: 20.04.0
      
      Test Plan: While dragging files, change modifiers between Ctrl/Shift/Alt... and move the mouse at least 1px to see the cursor changes.
      
      Reviewers: #dolphin, meven, ngraham, davidedmundson, elvisangelaccio
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: elvisangelaccio, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D28017
      b96c48b4
  9. 19 Mar, 2020 1 commit
  10. 17 Mar, 2020 2 commits
  11. 16 Mar, 2020 2 commits
  12. 15 Mar, 2020 2 commits
    • Nate Graham's avatar
      Add Duplicate feature · 405dd624
      Nate Graham authored
      Summary: Adds a Duplicate feature to Dolphin, showing up as a menu item in the File menu that appears when one or more items are selected and the directory is writable. Duplicated items receive the names of the original files with " copy" appended before the file extension, if any.
      
      Test Plan:
      
      {F5201386} {F5201393}
      
      Test cases:
      
      - Try to duplicate when nothing is selected: **PASS**: menu item is grayed out
      - Try to duplicate anything on a read-only local volume: **PASS**:  menu item is grayed out
      - Try to duplicate anything on a read-only samba share: **PASS**: menu item is grayed out
      - Duplicate single local file on R/W volume: **PASS**: item is duplicated and named correctly
      - Duplicate multiple local files on R/W volume: **PASS**: 3 items are duplicated, named correctly, and selected
      - Duplicate single local directory on  R/W volume: **PASS**: item is duplicated and named correctly, but a rename operation is not initiated
      - Duplicate multiple local directories on R/W volume: **PASS**: 3 items are duplicated, named correctly, and selected
      - Duplicate single file on R/W samba share: **PASS**: item is duplicated and correctly
      - Duplicate multiple files on R/W samba share: **PASS**: 3 items are duplicated, named correctly, and selected
      - Duplicate single directory on R/W samba share: **PASS**: item is duplicated and named correctly
      - Duplicate multiple directory on R/W samba share: **PASS**: 3 items are duplicated, named correctly, and selected
      - Try to undo a successful duplication: **PASS**: operation is undone
      
      This is my first attempt at a big change like this and I'm sure it's full of issues. I will accept any and all suggestions for improvement. :)
      
      Reviewers: #dolphin, #kde_applications, elvisangelaccio, dfaure, broulik, davidedmundson
      
      Subscribers: kfm-devel, meven, markg, fazevedo, cfeck, #dolphin
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D8208
      405dd624
    • Albert Astals Cid's avatar
  13. 02 Mar, 2020 1 commit
  14. 01 Mar, 2020 4 commits
    • Alexander Saoutkin's avatar
      Merge branch 'release/19.12' · 7a288585
      Alexander Saoutkin authored
      7a288585
    • Alexander Saoutkin's avatar
      Fix typo in comment · af45eb0a
      Alexander Saoutkin authored
      af45eb0a
    • Alexander Saoutkin's avatar
      Fix files not being highlighted if directory of file is already open · fef7eebc
      Alexander Saoutkin authored
      Summary:
      In DolphinTabWidget::openFiles it assumes openDirectories will open new tabs, so it
      only marks the URL selection for the newly opened tabs. This assumption is incorrect
       as Dolphin might reuse tabs when the folder is already open.
      
      Even then, markUrlsAsSelected does nothing when the folder is already opened.
      The selection seems to only be used when the folder finishes loading, calls made after
      that only change a variable without updating the actual selection.
      
      A call to DolphinView::updateViewState() is required to restore the intended behaviour, so long as DolphinView::clearSelection() has been called on the relevant tab, otherwise updateViewState() is a no-op.
      
      BUG: 417230
      FIXED-IN: 19.12.3
      
      Test Plan:
      1. In any application that has an "open containing folder" select that option
      2. and then do the same for another file in the same folder
      
      Reviewers: broulik
      
      Reviewed By: broulik
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D27389
      fef7eebc
    • Christoph Feck's avatar
      270ab975
  15. 29 Feb, 2020 1 commit
  16. 21 Feb, 2020 1 commit
  17. 18 Feb, 2020 1 commit
  18. 16 Feb, 2020 1 commit
  19. 14 Feb, 2020 1 commit
    • Nate Graham's avatar
      Restore former position of "Create New" menu item in viewport context menu · 4c923a53
      Nate Graham authored
      Summary:
      I've seem various complaints from users about the fact that the {nav Create New...} menu
      item in the viewport context menu is now below {nav Open With} item. All the other
      changes to menus seem to have been well-received but this one has garnered criticism.
      Looking through D23757 and D11884, I can't actually see that this was intentional, so
      it might even be a bug.
      
      Either way, this patch restores the old position of the {nav Create New} menu items at
      the top of the Viewport context menu.
      
      BUG: 417640
      FIXED-IN: 20.04.0
      
      Test Plan: {F8093605}
      
      Reviewers: #vdg, #dolphin, elvisangelaccio, ndavis
      
      Reviewed By: #vdg, ndavis
      
      Subscribers: asturmlechner, markuss, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D27267
      4c923a53
  20. 12 Feb, 2020 1 commit
    • Ilya Bizyaev's avatar
      Swap "Open in New Window" and "Open in New Tab" in context menus · 402f7f30
      Ilya Bizyaev authored
      Summary:
      Since Dolphin's default behaviour became opening in new tabs rather than in new windows
      (a very positive change, in my opinion), I always find myself accidentally opening folders
      in new windows from the context menu. This is because in most browsers with tab workflow
      (e.g. Firefox, Chromium, Falkon) the top context menu action is opening in a new tab, and
      my muscle memory plays a bad trick :) I'm aware of middle-clicking, but I find it
      inconvenient with my touchpad.
      
      I suspect I'm probably not alone in that, so I think it makes sense to swap these actions
      in Dolphin to match widely used apps.
      
      Test Plan:
      Open Dolphin, right click folders in the main view and in the Places panel, ensure the
      actions are indeed swapped
      
      Reviewers: #vdg, ndavis, #dolphin, ngraham
      
      Reviewed By: #vdg, ndavis, #dolphin, ngraham
      
      Subscribers: ngraham, ndavis, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D27318
      402f7f30
  21. 06 Feb, 2020 1 commit
  22. 03 Feb, 2020 1 commit
  23. 02 Feb, 2020 2 commits
  24. 28 Jan, 2020 1 commit
    • George Vogiatzis's avatar
      Add natural sorting and case-insensitive sorting for all role-types · 9e3418bd
      George Vogiatzis authored
      Summary:
       Add natural sorting and case-insensitive sorting, for all role-types
      that benefit from.
      
      BUG: 406296
      FIXED-IN: 19.12.2
      
      Test Plan:
      Sort by any role type specified in `isRoleValueNatural()`
      Before: Sorting is always case sensitive
      After: Sorting according to 'Sorting mode' in configuration.
      
      Reviewers: #dolphin, nicolasfella, meven, elvisangelaccio, ngraham
      
      Reviewed By: #dolphin, meven, elvisangelaccio, ngraham
      
      Subscribers: cfeck, meven, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D25741
      9e3418bd
  25. 27 Jan, 2020 2 commits
  26. 26 Jan, 2020 1 commit
    • Nikolai Krasheninnikov's avatar
      Fixes multiple VCS plugin calls on single directory update. · 305085b5
      Nikolai Krasheninnikov authored
      Summary:
      Fixes multiple VCS plugin beginRetrival()/endRetrival()/itemVersion() calls on single directory update.
      When VCS pluging finished gathering directory information VersionControlObserver::slotThreadFinished() calls KFileItemModel::setData() on each entry with appropriate item VCS information.
      This in turn emits KFileItemModel::itemsChanged() which is connected with VersionControlObserver::delayedDirectoryVerification() which is starting to gather VCS directory information again.
      This commits breaks the vicious circle.
      
      BUG: 415698
      FIXED-IN: 20.04.0
      
      Reviewers: #dolphin, meven, ngraham, elvisangelaccio
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D26721
      305085b5
  27. 20 Jan, 2020 1 commit
  28. 19 Jan, 2020 1 commit
    • Ismael Asensio's avatar
      (search) Fix searching tags with spaces · 5778099e
      Ismael Asensio authored
      Summary:
      Tags containing blank spaces were not handled properly in the search widget.
      Now we enclose them in quotes and strip the quotes before setting them to the widget.
      
      {F7854247}
      
      Test Plan:
      No artifacts when searching tags containing spaces
      Added test cases to `bin/dolphinquerytest`
      
      Reviewers: #dolphin, elvisangelaccio, ngraham, meven
      
      Reviewed By: #dolphin, elvisangelaccio, ngraham
      
      Subscribers: meven, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D26369
      5778099e
  29. 13 Jan, 2020 3 commits
    • Nate Graham's avatar
      Use more conventional "Add to Places" text for that action · 897ce848
      Nate Graham authored
      Summary:
      I originally implemented this to show "Add <current folder> to Places" to make the menu
      item more clear when invoked from the file menu or the viewport context menu because I
      thought it wasn't totally clear that the action would be referring to the folder for the
      visible view.
      
      However I think in retrospect that this was a mistake. No other items in the file menu
      or the viewport context menu name the current folder like this, so clearly there wasn't
      a problem. And then the item's text doesn't match the text for other items.
      
      Thie patch removes that behavior and makes the name match the style of all the other menu
      item text.
      
      BUG: 416064
      FIXED-IN: 20.04.0
      
      Reviewers: #dolphin, #vdg, meven
      
      Reviewed By: #dolphin, meven
      
      Subscribers: elvisangelaccio, meven, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D26590
      897ce848
    • Script Kiddy's avatar
      GIT_SILENT made messages (after extraction) · ba751e65
      Script Kiddy authored
      ba751e65
    • Script Kiddy's avatar
      GIT_SILENT made messages (after extraction) · 2fd2f621
      Script Kiddy authored
      2fd2f621
  30. 12 Jan, 2020 1 commit
    • Ismael Asensio's avatar
      Get rid of -Wdeprecated-copy warning · a8dd6998
      Ismael Asensio authored
      Summary:
      Remove the explicit copy constructor of `KItemListStyleOption`, since it does not
      add any logic to what the implicit copy constructor does, but triggers a compiler
      warning if we don't overload `operator=` too.
      
      Test Plan:
      Compiles without `-Wdeprecated-copy` warning
      No behavior changes
      
      Reviewers: elvisangelaccio, #dolphin
      
      Reviewed By: elvisangelaccio, #dolphin
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D26585
      a8dd6998