1. 14 Apr, 2020 1 commit
  2. 20 Jan, 2020 1 commit
  3. 11 Jan, 2020 1 commit
    • Piotr Henryk Dabrowski's avatar
      Hide tooltip instantly on filter change · f729f6f5
      Piotr Henryk Dabrowski authored
      Summary:
      Instantly hide tooltip shown over an element when filter bar changes.
      
      Currently the tooltip stays even when filtering causes the file under the mouse to change or disappears entirely.
      The tooltip also continues to cover much of the window - hiding the new filtering results from user.
      
      This is an enhancement to D22512
      
      Test Plan:
      1. place the mouse pointer over a file to show the tooltip
      2. press "/" to activate filter bar
      3. type in filter phrase
      
      Reviewers: #dolphin, elvisangelaccio, ngraham
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D26576
      f729f6f5
  4. 09 Nov, 2019 1 commit
  5. 06 Oct, 2019 1 commit
  6. 03 Oct, 2019 2 commits
    • Ismael Asensio's avatar
      Update searchbox on URL changes (Fix D24369) · 3d65fa9a
      Ismael Asensio authored
      Summary:
      In D24369 I introduced a regression: Where now the searchbox is updated on url changes for search urls, it is not updated anymore for regular folders. The effect is that not-indexed folders can have the extra options enabled or vice-versa. This patch fixes it, moving back the updating logic to `setSearchModeEnable`.
      
      Test Plan: - Searchbox updates properly when changing between search urls and regular folders, either indexed or nor-indexed.
      
      Reviewers: #dolphin, elvisangelaccio
      
      Subscribers: kfm-devel, elvisangelaccio
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D24376
      3d65fa9a
    • Ismael Asensio's avatar
      Update searchbox on URL changes (Fix D24369) · 8599a42a
      Ismael Asensio authored
      Summary:
      In D24369 I introduced a regression: Where now the searchbox is updated on url changes for search urls, it is not updated anymore for regular folders. The effect is that not-indexed folders can have the extra options enabled or vice-versa. This patch fixes it, moving back the updating logic to `setSearchModeEnable`.
      
      Test Plan: - Searchbox updates properly when changing between search urls and regular folders, either indexed or nor-indexed.
      
      Reviewers: #dolphin, elvisangelaccio
      
      Subscribers: kfm-devel, elvisangelaccio
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D24376
      8599a42a
  7. 02 Oct, 2019 1 commit
    • Ismael Asensio's avatar
      Update searchbar parameters on URL change · b3120cb9
      Ismael Asensio authored
      Summary:
      Searchbar options (text and options) were only updated when toggling the search on, $
      Main use case is when changing between stored search urls in Places panel.
      
      Test Plan:
      - Store two search urls in Places panel
      - Navigate between them
      - The searchbar text and parameters change accordingly
      
      BEFORE:
      {F7500811}
      AFTER:
      {F7500813}
      
      Reviewers: #dolphin, elvisangelaccio
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D24369
      b3120cb9
  8. 15 Sep, 2019 1 commit
    • Nazar Kalinowski's avatar
      Fix wrong window titles · 681d8bb6
      Nazar Kalinowski authored
      Summary:
      BUG: 389135
      FIXED-IN: 19.11.80
      
      Currently dolphin shows a folder's name instead of a "place" name if the current path has trailing slash and place's name doesn't, or vice versa.
      This patch fixes this behavior, so that dolphin always shows a "place" name.
      
      The QUrl::FullyEncoded string conversion is required because that's how
      the places model stores the places URLs in the XML bookmarks file.
      
      Test Plan:
      Test configuration: https://imgur.com/a/U4zBp8c
      Before (wrong window titles are in red): https://imgur.com/a/dB4xRwo
      After (all window titles are correct): https://imgur.com/a/W7virBn
      
      Reviewers: #dolphin, elvisangelaccio
      
      Subscribers: elvisangelaccio, ngraham, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D23706
      681d8bb6
  9. 08 Sep, 2019 1 commit
  10. 02 Sep, 2019 2 commits
    • Elvis Angelaccio's avatar
      Fix places text when the URL has a trailing slash · c5a71376
      Elvis Angelaccio authored
      Summary: QUrl::fileName() returns an empty string if the URL ends with a slash.
      
      Test Plan:
      1. Run `dolphin /tmp` from command line
      2. Right-click from viewport and click 'Add to Places'
      
      Reviewers: ngraham
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D23654
      c5a71376
    • Kai Uwe Broulik's avatar
      Reset progress bar text when directory loading starts · ada16756
      Kai Uwe Broulik authored
      Dolphin shows a different text for whether it is loading the directory or currently sorting its contents.
      However, when entering a folder that causes sort criteria to change (e.g. because of different view properties in that folder),
      the status bar text is changed to "Sorting..." while it is still actually loading the folder.
      When loading a directory starts, reset any status bar text to ensure "Loading..." is displayed in this case.
      
      Differential Revision: >https://phabricator.kde.org/D23459
      ada16756
  11. 01 Sep, 2019 1 commit
    • Ismael Asensio's avatar
      [dolphin] Add an action to toggle the searchbar · 3a758690
      Ismael Asensio authored
      Summary:
      Make search action toggle the searchbar instead of just launching it.
      
      The search action in dolphin did only bring up the search bar, but to close it again you had to go to the closing button on the same searchbar.
      This behavior in inconsistent with other dolphin actions which toggle panels or tools.
      
      BEFORE:
      {F7256652}
      
      AFTER:
      {F7256862}
      
      BUG: 344617
      FIXED-IN: 19.12.0
      Closes T8473
      
      Depends on D23075
      
      Test Plan:
      - Enable the search mode: the searchbar appears and the toolbar button gets checked
      - Press the search button again, and it goes back to normal mode.
      - The search button state is coherent with the searchbox
      - Coherence is kept when changing to a split view or different tab
      - Shorcut <Ctrl-F> does not close the searchbar, but moves the focus to it.
      
      Reviewers: #dolphin, ngraham, #vdg, elvisangelaccio
      
      Reviewed By: ngraham, #vdg
      
      Subscribers: ndavis, felixernst, elvisangelaccio, kfm-devel
      
      Tags: #dolphin
      
      Maniphest Tasks: T8473
      
      Differential Revision: https://phabricator.kde.org/D23232
      3a758690
  12. 23 Jun, 2019 1 commit
    • Felix Ernst's avatar
      Add "What's This?" to nearly everything in the main window · bd788a3f
      Felix Ernst authored
      Summary:
      This commit adds "What's This?" help to nearly everything in the
      Dolphin main window (panels, views, buttons, ...). It adds the "?"
      to the title bar so this help can easily be called.
      
      For links in those help texts to work the WhatsThisClickedEvents are
      handled in the main window class. This doesn't work for menus because
      events from them aren't forwarded to the main window for some
      reason so EventFilters are installed for the Control button menus.
      
      Modifying the "Help" menu of KXmlGui is deprecated so no EventFilter
      can be installed in the menubar. Therefore help texts without links
      are provided for the menubar.
      
      Test Plan:
      Check if the event handling might make any problems.
      Check for any big mistakes in the help messages.
      
      Reviewers: #dolphin, elvisangelaccio
      
      Subscribers: broulik, elvisangelaccio, yurchor, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D20471
      bd788a3f
  13. 26 May, 2019 1 commit
    • Nate Graham's avatar
      When filter bar is focused, switch to view when tab key is pressed · c22df71d
      Nate Graham authored
      Summary:
      Various people have requested that the tab key move keyboard focus from the filter bar's
      text edit field to the main view. It already does this when the Enter and return keys
      are pressed, but apparently this is not very intuitive and people expect Tab to work too.
      
      This patch makes that behavior possible by moving the Lock button to the left of the
      text edit field, and re-arranging the code so that the filter bar is initialized first.
      This works because Qt assigns tab ordering by default according to the order of widget
      construction. So if we simply construct the main view right after the filter bar, then
      the tab ordering is set up this way automatically.
      
      BUG: 403379
      BUG: 403356
      FIXED-IN: 19.08.0
      
      Test Plan:
      1. Activate Filter bar
      2. Hit Tab key
      3. View has become focused
      4. Play around in Dolphin for a while and notice no regressions or crashes
      
      Reviewers: #dolphin, elvisangelaccio
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D21177
      c22df71d
  14. 18 Mar, 2019 1 commit
  15. 27 Feb, 2019 1 commit
  16. 17 Feb, 2019 1 commit
    • Nate Graham's avatar
      Word-wrap KMessageWidget text · cf2da56c
      Nate Graham authored
      Summary:
      Word-wrap KMessageWidget text to prevent the window from being widened
      when the text is very long.
      
      CCBUG: 404232
      
      Only `CCBUG: ` because word wrap only works where QLabel detects a word boundary;
      it will not wrap a string with no spaces or other word boundaries (e.g.
      "aaaaaaaaaaaaaaaaaaaa...")
      
      Test Plan:
      - Create a new text file with a 300-character name that has spaces in it
      - In the KMessageWidget's error message, the file name is wrapped at the word
      boundaries
      
      Reviewers: #dolphin, #frameworks, cfeck, elvisangelaccio
      
      Reviewed By: #dolphin, cfeck, elvisangelaccio
      
      Subscribers: elvisangelaccio, cfeck, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D18968
      cf2da56c
  17. 15 Jan, 2019 1 commit
  18. 07 Oct, 2018 1 commit
  19. 27 Sep, 2018 2 commits
  20. 02 Sep, 2018 1 commit
  21. 24 Aug, 2018 1 commit
    • David Hallas's avatar
      Unify window and tab title · 44a21ea5
      David Hallas authored
      Summary:
      Previously the title of tabs was a prettyfied version of the URL.
      This is inconsistent with the title of the Window and in some cases
      for specials URLs kind of misleading. This commit generalizes the
      code from DolphinMainWindow so that both the DolphinMainWindow title
      and the tab title uses the same function for the title. This also
      means that the 'Show Full Path in Title Bar' also applies to the
      tab title, and also that searches changes the tab title.
      
      FEATURE: 387851
      
      Test Plan: Open a new tab from the places panel and navigate around.
      
      Reviewers: #dolphin, ngraham, elvisangelaccio, markg
      
      Reviewed By: #dolphin, ngraham, markg
      
      Subscribers: markg, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D14442
      44a21ea5
  22. 03 Jun, 2018 1 commit
  23. 02 Jun, 2018 1 commit
    • Nate Graham's avatar
      Show a warning when running as the root user · 621cd24a
      Nate Graham authored
      Summary: Now that Dolphin can be run as the root user again, let's show a warning.
      
      Test Plan:
      When run with the root user account:
      {F5882057}
      
      Reviewers: #dolphin, markg, elvisangelaccio
      
      Reviewed By: markg, elvisangelaccio
      
      Subscribers: acooligan, anthonyfieroni, chinmoyr, kfm-devel, rikmills, emmanuelp, zzag, nicolasfella, elvisangelaccio, Fuchs, mmustac, markg
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D12732
      621cd24a
  24. 13 May, 2018 1 commit
    • Melanie Genz's avatar
      Add missing i18n call · 2e1cc199
      Melanie Genz authored
      The string was already part of dolphin but was not exposed for
      translation.
      
      BUG: 394194
      2e1cc199
  25. 19 Mar, 2018 1 commit
  26. 18 Mar, 2018 1 commit
  27. 11 Mar, 2018 1 commit
  28. 04 Mar, 2018 1 commit
  29. 03 Dec, 2017 1 commit
    • Julian Schraner's avatar
      Change window title when searching · 702429ac
      Julian Schraner authored
      Summary:
      When you search for a file (e.g. "hello world") the window title of Dolphin will now change to "Search for [input]" instead of "baloosearch - /".
      
      BUG: 321575
      
      Test Plan:
        - Disables it iself after search bar is hidden
        - Works with multiple word searches
      
      Reviewers: #dolphin, ngraham, elvisangelaccio
      
      Reviewed By: #dolphin, ngraham, elvisangelaccio
      
      Subscribers: anthonyfieroni, elvisangelaccio, rkflx, emmanuelp, ngraham, #dolphin
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D8273
      702429ac
  30. 21 Nov, 2017 1 commit
  31. 01 Nov, 2017 1 commit
    • Nathaniel Graham's avatar
      Make Saved Search feature discoverable · 64cfc43b
      Nathaniel Graham authored
      Summary:
      FEATURE: 269332
      
      Make Dolphin's Saved Search feature discoverable by adding a button inside the search field. The button only becomes enabled when there is a valid search term. When pushed, it saves the search to the Places panel, providing a visible-by-default way to do this to complement the existing implementation that is only visible in the context menu.
      
      Also harmonized the label text so that it's consistent no matter how you create a saved search (button or context menu)
      
      Test Plan:
      Tested in KDE Neon. Works great:
      {F5449508}
      
      Reviewers: #dolphin, broulik, dfaure, markg, emateli, elvisangelaccio
      
      Reviewed By: #dolphin, markg, emateli, elvisangelaccio
      
      Subscribers: anthonyfieroni, markg, emateli, elvisangelaccio, cfeck, #dolphin
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D8454
      64cfc43b
  32. 21 Sep, 2017 1 commit
    • Gregor Mi's avatar
      Select child folder when navigating to a parent folder · 3749b555
      Gregor Mi authored
      Whenever the dolphin view is initialized to show the contents of a new URL
      (e.g. "/home/x/test") it will be checked if the new URL is a parent of the
      previous displayed URL (e.g. "/home/x/test/documents/aaa"). If the check is
      successful, then the common child (in this example: "/home/x/test/documents/")
      folder item will be selected and scrolled into view.
      
      REVIEW: 123253
      BUG: 377392
      CCBUG: 335616
      3749b555
  33. 27 Jul, 2017 1 commit
    • Elvis Angelaccio's avatar
      Fix drop menu position with urlnavigator drops · c3de8676
      Elvis Angelaccio authored
      Commit 1e251d2f6a in kio broke drop menus when dropping on the URL
      navigator (menus show up in the DolphinView rather than the URL bar).
      This happens because in DolphinView::dropUrls() we set `this` as the
      widget passed to KJobWidgets::setWindow() (in DragAndDropHelper::dropUrls()).
      
      We need to replace `this` with the actual widget that received the QDropEvent
      and that can mapToGlobal() the relative pos of the drop event.
      Unfortunately this widget is not KUrlNavigator itself, but one of its
      KUrlNavigatorButton children (private class, not exported). So
      unfortunately we need a new API in KIO that exposes this child widget.
      
      Differential Revision: https://phabricator.kde.org/D6684
      c3de8676
  34. 12 Mar, 2017 1 commit
  35. 18 Feb, 2017 2 commits
    • Don Nguyen's avatar
      Make "show filter bar" a toggle action · edf8e573
      Don Nguyen authored
      REVIEW: 129662
      edf8e573
    • Emmanuel Pescosta's avatar
      Restore the view state after the URL of the DolphinView has been changed, · 41b0e429
      Emmanuel Pescosta authored
      as stated in the documentation of KUrlNavigator::saveLocationState.
      
      The historyChanged signal of the KUrlNavigator is emitted before the urlChanged
      signal and so the view state restoring happens before the view URL has been
      changed. This makes it impossible to save and restore the selected URLs, because
      DolphinView::setUrl clears the list of selected items (which has been restored
      right before). This changes removes the history changed slot and restores the
      view state after the setUrl call.
      41b0e429
  36. 16 Jan, 2017 1 commit