1. 02 Jun, 2018 2 commits
    • Nerdopolis Turfwalker's avatar
      Add 'Sort By' and 'View Mode' into Dolphin file context menus · 97801e2c
      Nerdopolis Turfwalker authored
      Summary: This adds the 'Sort By' and 'View Mode'  options into the context menu of Dolphin within the file browser. I keep looking for these option (especially sort by) in the Context Menu, and keep forgetting to go to the menu. It also makes the order of "View Mode" and "Sort By" options consistent in the control menu
      
      Test Plan: Made sure that the options appeared when right clicking on an empty space.
      
      Reviewers: #dolphin, ngraham, elvisangelaccio
      
      Reviewed By: #dolphin, ngraham, elvisangelaccio
      
      Subscribers: question, markg, elvisangelaccio, mmustac, rkflx, ngraham, kfm-devel, #dolphin
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D12911
      97801e2c
    • Nate Graham's avatar
      Show a warning when running as the root user · 621cd24a
      Nate Graham authored
      Summary: Now that Dolphin can be run as the root user again, let's show a warning.
      
      Test Plan:
      When run with the root user account:
      {F5882057}
      
      Reviewers: #dolphin, markg, elvisangelaccio
      
      Reviewed By: markg, elvisangelaccio
      
      Subscribers: acooligan, anthonyfieroni, chinmoyr, kfm-devel, rikmills, emmanuelp, zzag, nicolasfella, elvisangelaccio, Fuchs, mmustac, markg
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D12732
      621cd24a
  2. 01 Jun, 2018 1 commit
  3. 31 May, 2018 1 commit
    • Nate Graham's avatar
      Re-allow running Dolphin as the root user (but still not using sudo) · 40453cb6
      Nate Graham authored
      Summary:
      Prohibiting the use of Dolphin as the actual root user (not using `sudo` or `kdesu`) breaks legitimate use cases for using the root user. An example is Kali, a distro that logs in as the root user by default as a deliberate design choice.
      
      In such an environment, there is no additional security vulnerability beyond what you're already potentially exposing yourself to. So, let's re-enable it.
      
      BUG: 387974
      FIXED-IN: 18.08.0
      
      Test Plan:
      - Log in as normal user and run `sudo dolphin`: you get an error message.
      - Log in as normal user and run `kdesu dolphin`: you get an error message.
      - Log in as the root user and run dolphin normally: it works.
      
      Reviewers: markg, elvisangelaccio, #dolphin
      
      Reviewed By: markg
      
      Subscribers: chinmoyr, cfeck, elvisangelaccio, mmustac, Fuchs, markg, graesslin, nicolasfella, zzag, kfm-devel, emmanuelp
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D12795
      40453cb6
  4. 22 May, 2018 1 commit
  5. 20 May, 2018 3 commits
  6. 18 May, 2018 2 commits
    • Alexander Miller's avatar
      Make target_link_libraries for kdeinit_dolphin PRIVATE · 8e6f4eec
      Alexander Miller authored
      Summary:
      There is no need to add all of kdeinit_dolphin's
      dependencies (including the static archive) when
      linking dolphin; kdemain is the only needed symbol.
      Mark the link libraries PRIVATE to simplify the
      link command for dolphin.
      
      Reviewers: #dolphin, elvisangelaccio
      
      Reviewed By: elvisangelaccio
      
      Subscribers: asturmlechner, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D12931
      8e6f4eec
    • Alexander Miller's avatar
      Remove main.cpp from dolphinstatic_SRCS · b607091c
      Alexander Miller authored
      Summary:
      The file main.cpp is already in dolphin_SRCS and doesn't
      belong in dolphinstatic_SRCS.
      
      Normally the duplicate object is simply ignored, but with
      link time optimization (LTO), linking dolphin can fail.
      Apparently, the compiler tries to inline inline kdemain()
      in this case. That is undesirable anyway and it ultimately
      fails because the DBusInterface definition is not available:
      
      .../ccHEv6cl.ltrans0.ltrans.o: In function `DBusInterface::~DBusInterface()':
      <artificial>:(.text+0x2583): undefined reference to `vtable for DBusInterface'
      .../ccHEv6cl.ltrans0.ltrans.o: In function `DBusInterface::~DBusInterface()':
      <artificial>:(.text+0x5aa3): undefined reference to `vtable for DBusInterface'
      .../ccHEv6cl.ltrans0.ltrans.o: In function `kdemain':
      <artificial>:(.text+0x7686): undefined reference to `DBusInterface::DBusInterface()'
      <artificial>:(.text+0x7b64): undefined reference to `vtable for DBusInterface'
      collect2: error: ld returned 1 exit status
      
      See also <https://bugs.gentoo.org/655710>.
      
      Reviewers: #dolphin, elvisangelaccio
      
      Reviewed By: elvisangelaccio
      
      Subscribers: elvisangelaccio, asturmlechner, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D12929
      b607091c
  7. 17 May, 2018 2 commits
  8. 14 May, 2018 2 commits
  9. 13 May, 2018 2 commits
  10. 12 May, 2018 1 commit
  11. 11 May, 2018 2 commits
  12. 07 May, 2018 1 commit
    • Nate Graham's avatar
      Disable all the 'create new' items when in the Trash · e133c455
      Nate Graham authored
      Summary:
      Disable all the items in the 'create new' menu when the active view is in the trash,
      because they're not useful and don't even work. We don't disable the entire menu
      because it's useful to be able to see what specific things are disabled.
      
      This can be reverted once T8234 is implemented.
      
      BUG: 332463
      FIXED-IN: 18.08.0
      
      Test Plan:
      - Enter the trash with and without a split view; the 'create new' menu items are all disabled
      - Be looking at something other than the trash with and without a split view; the 'create new' menu items are all enabled
      - Toggle between split views (one in the trash, one elsewhere); menu is correct for both cases
      
      Out of the trash:
      {F5837042}
      
      In the trash:
      {F5837043}
      
      Reviewers: #dolphin, broulik, elvisangelaccio, markg
      
      Reviewed By: #dolphin, elvisangelaccio, markg
      
      Subscribers: markg, elvisangelaccio
      
      Differential Revision: https://phabricator.kde.org/D12731
      e133c455
  13. 02 May, 2018 1 commit
  14. 30 Apr, 2018 4 commits
  15. 29 Apr, 2018 4 commits
  16. 25 Apr, 2018 4 commits
    • Elvis Angelaccio's avatar
      DolphinTabPage: deactivate secondary view after closing split view · 362244cc
      Elvis Angelaccio authored
      We deactivate the previously active view container whenever we change the active
      split view, but we never do the same when we close the split view.
      
      Long term we should probably even delete the secondary view after
      closing the split view, because it will never be used again and the
      pointer will be overwritten the next time the user opens the split view.
      362244cc
    • Elvis Angelaccio's avatar
      Merge branch 'Applications/18.04' · 9ec81359
      Elvis Angelaccio authored
      9ec81359
    • Robert Jennings's avatar
      Update window title after closing split view · 78c8b36d
      Robert Jennings authored
      Summary:
      
      In dolphintabpage.cpp:
      
      Through the connections set up in createViewContainer(), m_primaryViewContainer->setActive(true), at line 98,
      ends up triggering slotViewActivated().
      
      Because m_primaryViewActive is true, oldActiveView is not set to the view needed in this particular situation.
      Both oldActiveView and newActiveView end up pointing to the same view and the connections are not set up.
      
      BUG: 385111
      FIXED-IN: 18.04.1
      
      Test Plan:
      1. Open split view
      2. Make left panel active
      3. Close split view
      4. Navigate to various directories
      
      Window title now updates to show current directory
      
      Also tried with multiple tabs/combinations
      
      Reviewers: #dolphin, ngraham
      
      Reviewed By: #dolphin, ngraham
      
      Subscribers: elvisangelaccio, ngraham
      
      Differential Revision: https://phabricator.kde.org/D12446
      78c8b36d
    • Elvis Angelaccio's avatar
      Add failing test case for bug #385111 · 74c2d4ea
      Elvis Angelaccio authored
      Will be fixed by D12446.
      
      CCBUG: 385111
      74c2d4ea
  17. 22 Apr, 2018 1 commit
    • Nate Graham's avatar
      Move "Open" actions to the top of the context menu for files · b9143a55
      Nate Graham authored
      Summary:
      This patch moves the "Open", "Open With", and "Open in" items to the top of the context menu to reap the following benefits:
      - Move the "Open" and "Open With" items closer to the top since they're commonly used items, and right now they're buried in the middle of the menu
      - Group related functionality
      - Consistency with other common platforms (macOS Finder and Windows Explorer both have these items at the top of the context menu)
      
      For folders, the "Open With" entries are moved higher, but not all the way to the top, since the "open in New tab/folder" entries are more useful.
      
      Test Plan:
      Tested all menu items in the context menu for files, folders, and links; all still work.
      
      Context menu for single file:
      {F5806809}
      
      Context menu for multiple files:
      {F5806810}
      
      Context menu for single folder:
      {F5806811}
      
      Context menu for multiple folders:
      {F5806812}
      
      Context menu for symlink to folder:
      {F5806815}
      
      Reviewers: #dolphin, #vdg, elvisangelaccio, abetts
      
      Reviewed By: #dolphin, #vdg, elvisangelaccio, abetts
      
      Subscribers: markg, abetts, elvisangelaccio
      
      Differential Revision: https://phabricator.kde.org/D11884
      b9143a55
  18. 20 Apr, 2018 1 commit
  19. 19 Apr, 2018 1 commit
    • Nate Graham's avatar
      Fix inconsistent preview spacing and icon wiggly-ness when toggling previews in Icon mode · e15d9f26
      Nate Graham authored
      Summary:
      Dolphin had some code to change the grid spacing when previews were toggled, in an attempt to optimize the view for 3:2 landscape photos. This was problematic for many reasons:
      - Conceptually, it was a bad idea to optimize the view for one specific use case. Previews are useful for more than just landscape photos, and this optimization would be inapplicable to any other set of files.
      - Folders entirely full of images commonly have some portrait-orientation images included too, so even if the goal were appropriate, it was a bad idea to optimize for only having landscape images.
      - For small sizes and medium icons (< 96px), the preview grid size was virtually identical to the non-preview grid size, so it had essentially no effect, and only made the icons wiggle strangely when previews were toggled.
      - For large large sizes (>= 96px), all it did was unnecessarily increase the horizontal grid spacing, actually //reducing// usability for browsing through folders of images.
      
      Therefore, let's just remove this code.
      
      BUG: 393306
      FIXED-IN: 18.04.1
      
      Test Plan:
      - Go to {nav Settings > View Modes > Icons} and make the icon size and preview size identical for 64px
      - Toggle previews on and off
      - Change both sizes to 112x
      - Toggle previews on and off
      
      In both cases, the grid spacing does not change and the icons do not wiggle strangely. The only visual change is that previews turn on or off.
      
      Dolphin still works fine for viewing  3:2 landscape photos. 80px icons:
      {F5813467}
      
      192px icons:
      {F5813465}
      
      In fact, it's vastly //improved// for the >=96px use case since the grid spacing is no longer excessively wide
      
      Reviewers: #dolphin, hein
      
      Reviewed By: hein
      
      Subscribers: broulik
      
      Differential Revision: https://phabricator.kde.org/D12362
      e15d9f26
  20. 13 Apr, 2018 1 commit
  21. 12 Apr, 2018 2 commits
  22. 11 Apr, 2018 1 commit