1. 26 Dec, 2019 1 commit
  2. 24 Dec, 2019 2 commits
  3. 23 Dec, 2019 1 commit
  4. 21 Dec, 2019 4 commits
    • Piotr Henryk Dabrowski's avatar
      Use KParts::ReadOnlyPart::localFilePath() in DolphinPart::slotOpenTerminal() · 6cb4d81a
      Piotr Henryk Dabrowski authored
      Reviewers: ngraham, elvisangelaccio, #dolphin
      
      Reviewed By: ngraham, elvisangelaccio, #dolphin
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D26140
      6cb4d81a
    • Nate Graham's avatar
      Merge branch 'release/19.12' · 08049836
      Nate Graham authored
      08049836
    • Nate Graham's avatar
      Improve scroll wheel speed by basing it on label height, not icon height · 403de19d
      Nate Graham authored
      Summary:
      Dolphin currently scrolls by the height of three items at a time per "step" when
      using a scroll wheel. Because item height is highly variable, this leads to scroll
      speed being inconsistent between views, and generally far too fast when using
      icon view with icons larger than 22px size.
      
      This patch makes the size of the scroll step based on the text label rather than the
      icon size just like D25683, ensuring that the scroll speed does not vary and become
      super fast when using large icons in particular.
      
      It also reverts 90beb4a5, which is no longer needed.
      
      BUG: 386379
      FIXED-IN: 19.12.1
      
      Test Plan:
      Use a mouse with a scroll wheel and scroll in Dolphin item views with list view,
      details view, icon view, etc, using different item sizes. Speed should be
      consistent in all views now, and also feel consistent with other KDE apps.
      
      Also try with multiple scale factors to make sure the behavior does not change.
      
      No change with high-resolution two-finger touchpad scrolling.
      
      Reviewers: #dolphin, elvisangelaccio
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: ahiemstra, lots0logs, anthonyfieroni, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D19190
      403de19d
    • Ismael Asensio's avatar
      fix(search): Correctly parse filename and/or content search · 616d4e6b
      Ismael Asensio authored
      Summary:
      Currently, the search url parsing does not detect if the search is based on Content or Filename, and it just keeps the last selection which can be inconsistent with the actual search.
      
      This patch add such detection, and since an advanced user can combine filename and content search (using the keyword `filename:`), now the parsing detects both items and handles the four possible cases:
      
      | Content | Filename | Search text | Search type |
      |---|---|------------------------|------------------|
      | T | T | abc filename:"xyz"  | Content          |
      | T | F | abc                           | Content          |
      | F | T | xyz                           | Filename         |
      | F | F |                                  | do not set       |
      
      Depends on: D25260
      
      Test Plan: `bin/dolphinquerytest`: Added new test cases for searches with content text and/or filename
      
      Reviewers: elvisangelaccio, bruns, #dolphin
      
      Reviewed By: elvisangelaccio, #dolphin
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D25416
      616d4e6b
  5. 20 Dec, 2019 1 commit
  6. 19 Dec, 2019 1 commit
  7. 16 Dec, 2019 2 commits
  8. 15 Dec, 2019 2 commits
    • Ismael Asensio's avatar
      [dolphin/search] Search by (multiple) tags · 8e80c1d6
      Ismael Asensio authored
      Summary:
      Adds a tag selector in the extended filters of the search box.
      Selected tag or tags are added to the search query along with the other filters (type, date, rating).
      
      FEATURE: 412564
      CCBUG: 356062
      
      Test Plan:
      - Menu shows the user tags
      - Picking any tag/s filters the search to that specific tag/s
      
      {F7727909}
      
      Reviewers: elvisangelaccio, ngraham, #dolphin, #vdg
      
      Reviewed By: elvisangelaccio, ngraham, #dolphin, #vdg
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Maniphest Tasks: T9094
      
      Differential Revision: https://phabricator.kde.org/D25130
      8e80c1d6
    • Nate Graham's avatar
      Don't overload the word "Properties" to mean multiple things · f6229562
      Nate Graham authored
      Summary:
      Generally "Properties" refers to information about a selected file. However Dolphin also
      uses the word "Properties" in the phrase "View Properties", which refers to the display
      style of the view. Since "properties" is a fairly esoteric and technical term to most
      users, it would probably be wise to avoid using it in multiple contexts.
      
      Accordingly, this patch changes "view properties" to "view display style".
      
      Test Plan: Look at the settings window, hamburger menu, view menu, and docbook
      
      Reviewers: #vdg, #dolphin, ndavis, elvisangelaccio
      
      Reviewed By: #vdg, #dolphin, ndavis, elvisangelaccio
      
      Subscribers: ndavis, kfm-devel, kde-doc-english
      
      Tags: #dolphin, #documentation
      
      Differential Revision: https://phabricator.kde.org/D25987
      f6229562
  9. 10 Dec, 2019 1 commit
  10. 09 Dec, 2019 3 commits
  11. 06 Dec, 2019 3 commits
  12. 05 Dec, 2019 3 commits
  13. 02 Dec, 2019 1 commit
  14. 01 Dec, 2019 1 commit
  15. 28 Nov, 2019 3 commits
    • Elvis Angelaccio's avatar
      Merge branch 'release/19.12' · 26f0e55f
      Elvis Angelaccio authored
      26f0e55f
    • Ismael Asensio's avatar
      fix(search): Fix baloo searchString parsing · 6776fbc9
      Ismael Asensio authored
      Summary:
      Fix the parsing of Baloo query `searchString` to represent its parameters properly
      in the search box:
      # Baloo terms (`rating`, `modified`) are added to the user search text: {F7575590}
      # Extra quotes are added to the search text: https://bugs.kde.org/show_bug.cgi?id=412952
      
      This revision supersedes D24422, by making the fixes on the new dolphin query model,
      instead of directly on the UI.
      
      BUG: 412952
      FIXED IN: 19.11.90
      
      Test Plan:
        - `bin/dolphinquerytest` passes without `XFAIL`s
        - Dolphin search box is not garbled by search terms or quotes
      
      Reviewers: elvisangelaccio, bruns, ngraham, #dolphin
      
      Reviewed By: elvisangelaccio
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D25260
      6776fbc9
    • Elvis Angelaccio's avatar
      Force dbus introspection on the Dolphin_1 object · 089a05b4
      Elvis Angelaccio authored
      Summary:
      QtDBus caches known interfaces when passing a non-empty interface name
      to the QDbusInterface constructor. This is an issue when calling the
      FileManager1 methods more than once, because `preferred` could be a
      valid interface from the cache, but it would later fail to call the
      `openFiles`/`openDirectories` methods on the main window.
      
      By passing an empty interface name, we prevent QtDBus from using the
      cache so that we always get an invalid interface when calling the
      FileManager1 methods on a daemonized dolphin process (that doesn't have
      the Dolphin_1 dbus object).
      
      BUG: 414402
      FIXED-IN: 19.12.0
      
      Test Plan:
      1. dolphin --daemon
      2. qdbus org.freedesktop.FileManager1 /org/freedesktop/FileManager1 ShowFolders "/tmp" ""
      3. Close the dolphin window that was just opened.
      4. Start a normal dolphin process
      5. qdbus org.freedesktop.FileManager1 /org/freedesktop/FileManager1 ShowFolders "/tmp" ""
      6. Close again the dolphin window
      7. qdbus org.freedesktop.FileManager1 /org/freedesktop/FileManager1 ShowFolders "/tmp" ""
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D25510
      089a05b4
  16. 26 Nov, 2019 1 commit
  17. 25 Nov, 2019 2 commits
  18. 24 Nov, 2019 1 commit
    • Elvis Angelaccio's avatar
      Fix accessibility regression on the Dolphin Control button · 82e366f0
      Elvis Angelaccio authored
      9cd042a8 removed the text from the Control button without setting an
      accessibleName property, which is a regression for screen-reader users.
      
      This breaks the 19.12 string freeze, but since it's the same string we
      were translating before 9cd042a8, hopefully it's not going to be too
      much of a burden for translators.
      
      CCBUG: 414271
      CCMAIL: kde-i18n-doc@kde.org
      82e366f0
  19. 23 Nov, 2019 2 commits
  20. 19 Nov, 2019 2 commits
    • Noah Davis's avatar
      Change default completion mode to CompletionPopupAuto · c33808b1
      Noah Davis authored
      Summary:
      This makes Dolphin use the "Dropdown List & Automatic" completion mode by default when editing the URL bar.
      
      Given the context of someone typing file paths, I can't see why one wouldn't want to use this feature, unless they don't like how it looks.
      
      Reviewers: #vdg, #dolphin, ngraham, elvisangelaccio
      
      Reviewed By: #vdg, #dolphin, ngraham, elvisangelaccio
      
      Subscribers: ngraham, elvisangelaccio, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D25391
      c33808b1
    • Laurent Montel's avatar
      Port deprecated methods · 373c3ebc
      Laurent Montel authored
      373c3ebc
  21. 17 Nov, 2019 3 commits