1. 15 May, 2020 1 commit
    • Nikolai Krasheninnikov's avatar
      Added VCS plugins signals connections for outOfVersionControl() actions. · 9b7fc506
      Nikolai Krasheninnikov authored
      Summary:
      Plugins can now do out of version control actions (D29041), so we need them to inform of their state.
      This change connects every plugin signal to Dolphin on plugin instantiation.
      
      Test Plan:
      1. Try SVN Update of inaccessible repository: see SVN error message shows up.
      2. Try pull inaccessible git repository: see GIT error message shows up.
      3. Try SVN Commit: see SVN message.
      
      Reviewers: #dolphin, meven, elvisangelaccio
      
      Reviewed By: #dolphin, meven
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D29488
      9b7fc506
  2. 14 May, 2020 1 commit
  3. 13 May, 2020 1 commit
  4. 11 May, 2020 3 commits
  5. 10 May, 2020 1 commit
  6. 09 May, 2020 1 commit
  7. 08 May, 2020 1 commit
  8. 06 May, 2020 3 commits
    • Ahmad Samir's avatar
      Port QRegExp to QRegularExpression · e3c03e46
      Ahmad Samir authored
      Summary:
      Port QRegExp::exactMatch() with QRegularExpression::anchoredPattern().
      Port QRegExp::Wildcard with QRegularExpression::wildcardToRegularExpression().
      Note that QRegularExpression::wildcardToRegularExpression() returns an anchored
      pattern.
      
      Test Plan:
      Using the filter bar in dolphin works as before.
      
      All unit tests pass, except:
      - kfileitemmodeltest (which is unrelated AFAICS); it fails on master too
      - placesitemmodeltest, which fails on master too
      
      Reviewers: #dolphin, elvisangelaccio, meven
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D26215
      e3c03e46
    • Kai Uwe Broulik's avatar
      Merge branch 'release/20.04' · 37deaaef
      Kai Uwe Broulik authored
      37deaaef
    • Kai Uwe Broulik's avatar
      Don't update preferred search action on window activation · 801fdf4c
      Kai Uwe Broulik authored
      I don't see why this is necessary and causes a blocking(!) StatJob every single time the window is focussed,
      worse, ends up in an infinite loop when the window loses focus on an auth prompt.
      
      CCBUG: 420911
      
      Differential Revision: https://phabricator.kde.org/D29441
      801fdf4c
  9. 05 May, 2020 7 commits
  10. 04 May, 2020 6 commits
    • Nikolai Krasheninnikov's avatar
      Merge branch 'release/20.04' · 61ce7cea
      Nikolai Krasheninnikov authored
      61ce7cea
    • Nikolai Krasheninnikov's avatar
      Fixes Dolphin crash on "Defocus Terminal Panel" menu click if no Konsole is installed. · 2c72b186
      Nikolai Krasheninnikov authored
      Summary:
      Dolphin crashes if no Konsole is installed and user clicks menu action "Defocus Terminal Panel".
      This fix is pretty straight forward.
      
      Steps to reproduce:
      1. Run Dolphin without Konsole available.
      2. Press F4 to open console window.
      3. Click in service menu "Focus Terminal Panel".
      4. Click in service menu "Defocus Terminal Panel". Observe the crash.
      
      Test Plan:
      1. Run Dolphin without Konsole available.
      2. Press F4 to open console window.
      3. Click in service menu "Focus Teminal Panel".
      4. Click in service menu "Defocus Terminal Panel".
      5. Click in service menu "Focus Terminal Panel".
      6. Press F4 to close console window.
      
      Reviewers: #dolphin, meven, elvisangelaccio, ngraham
      
      Reviewed By: #dolphin, meven, elvisangelaccio, ngraham
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D29345
      2c72b186
    • Nikolai Krasheninnikov's avatar
      Fixes Dolphin crash on "Defocus Terminal Panel" menu click if no Konsole is installed. · a9e2f01a
      Nikolai Krasheninnikov authored
      Summary:
      Dolphin crashes if no Konsole is installed and user clicks menu action "Defocus Terminal Panel".
      This fix is pretty straight forward.
      
      Steps to reproduce:
      1. Run Dolphin without Konsole available.
      2. Press F4 to open console window.
      3. Click in service menu "Focus Terminal Panel".
      4. Click in service menu "Defocus Terminal Panel". Observe the crash.
      
      Test Plan:
      1. Run Dolphin without Konsole available.
      2. Press F4 to open console window.
      3. Click in service menu "Focus Teminal Panel".
      4. Click in service menu "Defocus Terminal Panel".
      5. Click in service menu "Focus Terminal Panel".
      6. Press F4 to close console window.
      
      Reviewers: #dolphin, meven, elvisangelaccio, ngraham
      
      Reviewed By: #dolphin, meven, elvisangelaccio, ngraham
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D29345
      a9e2f01a
    • Alexander Lohnau's avatar
      Dolphin: Cleanup kcms · fd827e41
      Alexander Lohnau authored
      Summary: Refactor forearch, adjust formatting, remove unnecessary version checks.
      
      Test Plan: Compiles
      
      Reviewers: #dolphin, ngraham, elvisangelaccio, meven
      
      Reviewed By: #dolphin, ngraham
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D29377
      fd827e41
    • Antonio Prcela's avatar
      Replace the list with the simplified list, instead of concatenate. · ddcca5fb
      Antonio Prcela authored
      Summary: Replace the list m_selectedUrls with a simplified list, instead of concatenating the simplified list to the current one.
      
      Reviewers: dfaure, meven
      
      Reviewed By: dfaure
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D29399
      ddcca5fb
    • Méven Car's avatar
      [Details mode] Allow to fill the column size of directories with actual size · e6ea3ab4
      Méven Car authored
      Summary:
      Allow to compute the recursive size of directories to fill the details view size column.
      A setting allow to set a limit to the recursive level, allowing the user to have some power over the setting.
      
      When sorting by size and the feature is on, we get progressive ordering as the directory size are gathered.
      
      KDirectoryContentsCounter uses a cache internally to keep results so that it can display directory size faster, but counts the dir size of directories each time it is asked to count the size a directory nevertheless and when the size has changed, it is updated.
      KDirectoryContentsCounter uses one worker per instance only, meaning one process per view makes the disk spin.
      
      FIXED-IN: 20.08
      BUG: 190580
      BUG: 158090
      
      Test Plan:
      With some recursion allowed:
      {F8267580}
      
      Without any recursion allowed (default):
      {F8267581}
      
      Reviewers: elvisangelaccio, ngraham, #dolphin
      
      Reviewed By: elvisangelaccio, ngraham, #dolphin
      
      Subscribers: feverfew, anthonyfieroni, iasensio, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D25335
      e6ea3ab4
  11. 03 May, 2020 4 commits
    • Alexander Lohnau's avatar
      Dolphin Service Menu Installer: Launch certain scripts in Konsole · d34559d1
      Alexander Lohnau authored
      Summary:
      In general the issue with installers/uninstallers for the dolphin plugin is
      that a lot of the scripts are intended to be run manually in a terminal.
      For instance if a script uses `sudo make install` the user can't type in the password.
      
      With this patch scripts that are executed without arg variants are
      executed in konsole (if available).
      
      Test Plan:
      Tests still pass. Try to install the "Jetbrains Dolphin Plugin" tar.gz file from the kde store.
      If you have the required dependencies etc. the konsole window should close.
      If the install script fails (type in wrong admin password a couple of times) you
      should have a shell opened.
      
      Reviewers: #dolphin, ngraham, nicolasfella, elvisangelaccio, meven
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D29089
      d34559d1
    • Elvis Angelaccio's avatar
      32308843
    • Alexander Lohnau's avatar
      Dolphin Services: Add search box · e6d4afa9
      Alexander Lohnau authored
      Summary:
      You can now filter the list of installed services.
      This is especially useful if you install additional service menus
      from the kde store, because one instalaton can add a lot of services.
      For instance the ReImage plugin.
      
      Test Plan:
      Compiles, search for a service menu.
      Only services matching the query will show up.
      
      Reviewers: ngraham, elvisangelaccio, meven
      
      Reviewed By: meven
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D29375
      e6d4afa9
    • Méven Car's avatar
      filenamesearch:/ define a title for the query · e076d866
      Méven Car authored
      Summary: CCBUG: 420354
      
      Reviewers: ngraham, elvisangelaccio, #dolphin, #frameworks, iasensio
      
      Reviewed By: elvisangelaccio, #dolphin, iasensio
      
      Subscribers: iasensio, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D29198
      e076d866
  12. 01 May, 2020 1 commit
    • Méven Car's avatar
      Information Panel: show early icons for folders · dcd8c646
      Méven Car authored
      Summary:
      Folders previews can be long to generate.
      This can be noticeable by the user.
      
      This diff displays folder icons after a 100ms timer.
      
      BUG: 420340
      FIXED-IN: 20.08
      
      Test Plan:
      rm -r ~/.cache/thumbnails/
      In dolphin open trash
      Click on download (or any directory with a long to generate preview).
      
      Reviewers: #dolphin, ngraham
      
      Reviewed By: #dolphin, ngraham
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D29204
      dcd8c646
  13. 30 Apr, 2020 1 commit
  14. 29 Apr, 2020 1 commit
  15. 27 Apr, 2020 2 commits
    • Yuri Chornoivan's avatar
      Update docs for startup page of configuration · 7f085a5b
      Yuri Chornoivan authored
      Summary: After several resurfaces of GUI the current docs are not up-to-date.
      
      Test Plan: I used an impression from D11382 to write this. Tested with checkXML5. An updated screenshot is needed.
      
      Reviewers: #dolphin, ngraham
      
      Reviewed By: #dolphin, ngraham
      
      Subscribers: ngraham, kfm-devel, kde-doc-english
      
      Tags: #dolphin, #documentation
      
      Differential Revision: https://phabricator.kde.org/D29220
      7f085a5b
    • René J.V. Bertin's avatar
      prevent a QFileInfo warning · d3813ee6
      René J.V. Bertin authored
      DolphinSearchBox::init() can generate a terminal warning depending on
      the user's search history:
      
      QFileInfo::absolutePath: Constructed with empty filename
      
      The warning can seem to appear randomly if you don't use the search
      feature often, because of its dependency on previous search activity.
      
      Prevent this warning by adding a simple check if the current
      m_searchPath is valid or not. This check has no effect on the value
      returned by DolphinSearchBox::isIndexingEnabled() and is in line with
      the fact that m_searchPath == QUrl() indicates that no search path has
      been set.
      
      Differential Revision: https://phabricator.kde.org/D29194
      d3813ee6
  16. 26 Apr, 2020 1 commit
    • Nate Graham's avatar
      Add an option to show tabs from last time when Dolphin starts · caf2fe1c
      Nate Graham authored
      Summary:
      All modern web browsers offer a function to show tabs from last time when a browser starts, and many apps today
      restore their prior state when they're launched. This patch implements thatfunctionality as an option and turns it on by default.
      
      The settings window is accordingly adjusted to be clear about what applies when:
      
      {F7681752}
      
      FEATURE: 413564
      FIXED-IN: 20.08.0
      
      Depends on D25106
      Depends on D25219
      
      Test Plan:
      With the new setting turned off:
      - No behavioral changes at all
      
      With the new setting turned on:
      - When launched from the GUI or CLI without any URLs, dolphin restores session
      - When rebooting with Dolphin open, it restores session normally after the system comes back (i.e. no behavioral change here)
      - When launched with URLs, Dolphin window is opened showing those URLs instead of restoring session
      - When Dolphin is already running and a new window is opened, that new window shows a single tab with the same URL as was visible in the previously-open Dolphin instance (i.e. no behavioral change here)
      - "Open Containing folder" functionality in other apps works regardless of whether or not Dolphin is running
      
      Reviewers: #dolphin, #vdg, feverfew, meven, elvisangelaccio, ndavis
      
      Reviewed By: #dolphin, #vdg, feverfew, elvisangelaccio, ndavis
      
      Subscribers: davidedmundson, ndavis, intika, feverfew, kfm-devel, ngraham, broulik, #dolphin
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D11382
      caf2fe1c
  17. 25 Apr, 2020 2 commits
  18. 21 Apr, 2020 3 commits
    • Alexander Lohnau's avatar
      Merge branch 'release/20.04' · e78fe032
      Alexander Lohnau authored
      e78fe032
    • Alexander Lohnau's avatar
      Dolphin Service Installer: Run uninstall scripts, rename methods · 5bbdf66f
      Alexander Lohnau authored
      Summary:
      Now scripts starting with `uninstall` are being executed.
      Addtionally the `runInstallerScriptOnce` method has been renamed, because it is used to run the install/uninstall scripts.
      Same for `runInstallerScript`.
      Depends on D28801
      
      Test Plan: Compile, run tests. Try to uninstall a dolphin service which has a uninstall.sh script.
      
      Reviewers: #dolphin, ngraham, nicolasfella, elvisangelaccio
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: cfeck, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D28836
      5bbdf66f
    • Méven Car's avatar
      Information Panel: Make icons as big as previews · cb085066
      Méven Car authored
      Summary:
      Make icons match the preview size.
      It prevents a user that had a wide information panel,
      seeing a size difference between a preview and an icon despite they can look similar (i.e folder preview).
      
      Test Plan:
      Before:
      {F8248373, size=full}
      
      After:
      {F8248370, size=full}
      
      Reviewers: #dolphin, ngraham, elvisangelaccio
      
      Reviewed By: #dolphin, ngraham, elvisangelaccio
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D29002
      cb085066