1. 19 May, 2020 1 commit
  2. 18 May, 2020 4 commits
  3. 17 May, 2020 1 commit
  4. 15 May, 2020 1 commit
    • Nikolai Krasheninnikov's avatar
      Added VCS plugins signals connections for outOfVersionControl() actions. · 9b7fc506
      Nikolai Krasheninnikov authored
      Summary:
      Plugins can now do out of version control actions (D29041), so we need them to inform of their state.
      This change connects every plugin signal to Dolphin on plugin instantiation.
      
      Test Plan:
      1. Try SVN Update of inaccessible repository: see SVN error message shows up.
      2. Try pull inaccessible git repository: see GIT error message shows up.
      3. Try SVN Commit: see SVN message.
      
      Reviewers: #dolphin, meven, elvisangelaccio
      
      Reviewed By: #dolphin, meven
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D29488
      9b7fc506
  5. 14 May, 2020 1 commit
  6. 13 May, 2020 2 commits
  7. 11 May, 2020 5 commits
  8. 10 May, 2020 2 commits
  9. 09 May, 2020 1 commit
  10. 08 May, 2020 1 commit
  11. 06 May, 2020 3 commits
    • Ahmad Samir's avatar
      Port QRegExp to QRegularExpression · e3c03e46
      Ahmad Samir authored
      Summary:
      Port QRegExp::exactMatch() with QRegularExpression::anchoredPattern().
      Port QRegExp::Wildcard with QRegularExpression::wildcardToRegularExpression().
      Note that QRegularExpression::wildcardToRegularExpression() returns an anchored
      pattern.
      
      Test Plan:
      Using the filter bar in dolphin works as before.
      
      All unit tests pass, except:
      - kfileitemmodeltest (which is unrelated AFAICS); it fails on master too
      - placesitemmodeltest, which fails on master too
      
      Reviewers: #dolphin, elvisangelaccio, meven
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D26215
      e3c03e46
    • Kai Uwe Broulik's avatar
      Merge branch 'release/20.04' · 37deaaef
      Kai Uwe Broulik authored
      37deaaef
    • Kai Uwe Broulik's avatar
      Don't update preferred search action on window activation · 801fdf4c
      Kai Uwe Broulik authored
      I don't see why this is necessary and causes a blocking(!) StatJob every single time the window is focussed,
      worse, ends up in an infinite loop when the window loses focus on an auth prompt.
      
      CCBUG: 420911
      
      Differential Revision: https://phabricator.kde.org/D29441
      801fdf4c
  12. 05 May, 2020 7 commits
  13. 04 May, 2020 6 commits
    • Nikolai Krasheninnikov's avatar
      Merge branch 'release/20.04' · 61ce7cea
      Nikolai Krasheninnikov authored
      61ce7cea
    • Nikolai Krasheninnikov's avatar
      Fixes Dolphin crash on "Defocus Terminal Panel" menu click if no Konsole is installed. · 2c72b186
      Nikolai Krasheninnikov authored
      Summary:
      Dolphin crashes if no Konsole is installed and user clicks menu action "Defocus Terminal Panel".
      This fix is pretty straight forward.
      
      Steps to reproduce:
      1. Run Dolphin without Konsole available.
      2. Press F4 to open console window.
      3. Click in service menu "Focus Terminal Panel".
      4. Click in service menu "Defocus Terminal Panel". Observe the crash.
      
      Test Plan:
      1. Run Dolphin without Konsole available.
      2. Press F4 to open console window.
      3. Click in service menu "Focus Teminal Panel".
      4. Click in service menu "Defocus Terminal Panel".
      5. Click in service menu "Focus Terminal Panel".
      6. Press F4 to close console window.
      
      Reviewers: #dolphin, meven, elvisangelaccio, ngraham
      
      Reviewed By: #dolphin, meven, elvisangelaccio, ngraham
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D29345
      2c72b186
    • Nikolai Krasheninnikov's avatar
      Fixes Dolphin crash on "Defocus Terminal Panel" menu click if no Konsole is installed. · a9e2f01a
      Nikolai Krasheninnikov authored
      Summary:
      Dolphin crashes if no Konsole is installed and user clicks menu action "Defocus Terminal Panel".
      This fix is pretty straight forward.
      
      Steps to reproduce:
      1. Run Dolphin without Konsole available.
      2. Press F4 to open console window.
      3. Click in service menu "Focus Terminal Panel".
      4. Click in service menu "Defocus Terminal Panel". Observe the crash.
      
      Test Plan:
      1. Run Dolphin without Konsole available.
      2. Press F4 to open console window.
      3. Click in service menu "Focus Teminal Panel".
      4. Click in service menu "Defocus Terminal Panel".
      5. Click in service menu "Focus Terminal Panel".
      6. Press F4 to close console window.
      
      Reviewers: #dolphin, meven, elvisangelaccio, ngraham
      
      Reviewed By: #dolphin, meven, elvisangelaccio, ngraham
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D29345
      a9e2f01a
    • Alexander Lohnau's avatar
      Dolphin: Cleanup kcms · fd827e41
      Alexander Lohnau authored
      Summary: Refactor forearch, adjust formatting, remove unnecessary version checks.
      
      Test Plan: Compiles
      
      Reviewers: #dolphin, ngraham, elvisangelaccio, meven
      
      Reviewed By: #dolphin, ngraham
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D29377
      fd827e41
    • Antonio Prcela's avatar
      Replace the list with the simplified list, instead of concatenate. · ddcca5fb
      Antonio Prcela authored
      Summary: Replace the list m_selectedUrls with a simplified list, instead of concatenating the simplified list to the current one.
      
      Reviewers: dfaure, meven
      
      Reviewed By: dfaure
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D29399
      ddcca5fb
    • Méven Car's avatar
      [Details mode] Allow to fill the column size of directories with actual size · e6ea3ab4
      Méven Car authored
      Summary:
      Allow to compute the recursive size of directories to fill the details view size column.
      A setting allow to set a limit to the recursive level, allowing the user to have some power over the setting.
      
      When sorting by size and the feature is on, we get progressive ordering as the directory size are gathered.
      
      KDirectoryContentsCounter uses a cache internally to keep results so that it can display directory size faster, but counts the dir size of directories each time it is asked to count the size a directory nevertheless and when the size has changed, it is updated.
      KDirectoryContentsCounter uses one worker per instance only, meaning one process per view makes the disk spin.
      
      FIXED-IN: 20.08
      BUG: 190580
      BUG: 158090
      
      Test Plan:
      With some recursion allowed:
      {F8267580}
      
      Without any recursion allowed (default):
      {F8267581}
      
      Reviewers: elvisangelaccio, ngraham, #dolphin
      
      Reviewed By: elvisangelaccio, ngraham, #dolphin
      
      Subscribers: feverfew, anthonyfieroni, iasensio, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D25335
      e6ea3ab4
  14. 03 May, 2020 4 commits
    • Alexander Lohnau's avatar
      Dolphin Service Menu Installer: Launch certain scripts in Konsole · d34559d1
      Alexander Lohnau authored
      Summary:
      In general the issue with installers/uninstallers for the dolphin plugin is
      that a lot of the scripts are intended to be run manually in a terminal.
      For instance if a script uses `sudo make install` the user can't type in the password.
      
      With this patch scripts that are executed without arg variants are
      executed in konsole (if available).
      
      Test Plan:
      Tests still pass. Try to install the "Jetbrains Dolphin Plugin" tar.gz file from the kde store.
      If you have the required dependencies etc. the konsole window should close.
      If the install script fails (type in wrong admin password a couple of times) you
      should have a shell opened.
      
      Reviewers: #dolphin, ngraham, nicolasfella, elvisangelaccio, meven
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D29089
      d34559d1
    • Elvis Angelaccio's avatar
      32308843
    • Alexander Lohnau's avatar
      Dolphin Services: Add search box · e6d4afa9
      Alexander Lohnau authored
      Summary:
      You can now filter the list of installed services.
      This is especially useful if you install additional service menus
      from the kde store, because one instalaton can add a lot of services.
      For instance the ReImage plugin.
      
      Test Plan:
      Compiles, search for a service menu.
      Only services matching the query will show up.
      
      Reviewers: ngraham, elvisangelaccio, meven
      
      Reviewed By: meven
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D29375
      e6d4afa9
    • Méven Car's avatar
      filenamesearch:/ define a title for the query · e076d866
      Méven Car authored
      Summary: CCBUG: 420354
      
      Reviewers: ngraham, elvisangelaccio, #dolphin, #frameworks, iasensio
      
      Reviewed By: elvisangelaccio, #dolphin, iasensio
      
      Subscribers: iasensio, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D29198
      e076d866
  15. 01 May, 2020 1 commit
    • Méven Car's avatar
      Information Panel: show early icons for folders · dcd8c646
      Méven Car authored
      Summary:
      Folders previews can be long to generate.
      This can be noticeable by the user.
      
      This diff displays folder icons after a 100ms timer.
      
      BUG: 420340
      FIXED-IN: 20.08
      
      Test Plan:
      rm -r ~/.cache/thumbnails/
      In dolphin open trash
      Click on download (or any directory with a long to generate preview).
      
      Reviewers: #dolphin, ngraham
      
      Reviewed By: #dolphin, ngraham
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D29204
      dcd8c646