1. 19 Apr, 2021 1 commit
    • Nate Graham's avatar
      Increase default window size · a27b4c5c
      Nate Graham authored
      The current default window size of 750x500 is quite small on today's
      screens, and results in an initial user experience of a very cramped app
      window. The very first action that I see from new users interacting with
      Dolphin is to make the window bigger.
      
      So let's do it for them by making the default window size a bit bigger
      ourselves.
      a27b4c5c
  2. 17 Apr, 2021 1 commit
  3. 10 Feb, 2021 1 commit
  4. 25 Jan, 2021 1 commit
    • Harald Sitter's avatar
      don't crash when building without baloo · 5ed12ed4
      Harald Sitter authored
      show_information_panel is only created when building with baloo. only
      access it when built with baloo, otherwise always report the panel as
      off.
      
      this fixes a nullptr deref because action() would return a nullptr since
      show_information_panel isn't a thing in all build configurations
      
      (full disclosure: I can't reproduce the crash, nor did I build without
      baloo)
      
      BUG: 431730
      5ed12ed4
  5. 10 Jan, 2021 1 commit
  6. 02 Jan, 2021 1 commit
    • Felix Ernst's avatar
      Animate split view mode toggling · f01a61b7
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      Have the secondary ViewContainer slide into/out of view when split view mode is switched on or off by the user.
      
      This should help users understand what split view mode is about. Without the animation it might seem like the only thing the button does is creating a weird vertical line in the middle of the view or something. With the animation it should be clear that the second view is a separate entity that was added. The closing animation will help users understand which of the ViewContainers was just closed.
      f01a61b7
  7. 29 Dec, 2020 1 commit
  8. 28 Dec, 2020 2 commits
    • Chau Duong's avatar
      Share actions with main window to avoid duplicating icon name and text · 238eb86d
      Chau Duong authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      238eb86d
    • Eike Hein's avatar
      Use a faster way to determine kio-stash isn't installed · b339ac1b
      Eike Hein authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      Summary:
      Dolphin needs to figure out whether or not kio-stash is installed
      to set the enabled state of a UI action.
      
      When KProtocolInfo::isKnownProtocol can't find a protocol it gets
      worried its protocol cache might be out of date, so it rebuilds it
      (doing plenty of disk I/O) and looks again. kio-stash is currently
      not yet installed on many systems, so this means most Dolphin
      startups out there.
      
      This patch switches to using QDBusConnectionInterface::isServiceRegistered
      instead to determine whether the stash notifier daemon is running,
      which should be faster than doing disk I/O.
      
      Reviewers: davidedmundson, elvisangelaccio, shortstheory
      
      Subscribers: emmanuelp, alexeymin, ngraham, #dolphin
      
      Differential Revision: https://phabricator.kde.org/D9094
      b339ac1b
  9. 16 Dec, 2020 1 commit
  10. 11 Dec, 2020 1 commit
  11. 09 Dec, 2020 1 commit
  12. 05 Dec, 2020 1 commit
  13. 02 Dec, 2020 1 commit
  14. 19 Nov, 2020 1 commit
    • Felix Ernst's avatar
      Allow having the UrlNavigators below the tab bar · 50ca5af7
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      This commit restores the possibility to have the UrlNavigators below
      the tab bar. This will happen automatically whenever the UrlNavigator
      is removed from the toolbar.
      
      It is also now again possible to have the toolbar on the side. This
      option is disabled while the toolbar contains the UrlNavigators.
      
      This commit makes no changes to the new default which is having the
      UrlNavigators in the toolbar but makes sure that upgrading users won't
      be affected.
      50ca5af7
  15. 18 Nov, 2020 1 commit
  16. 09 Nov, 2020 8 commits
    • Felix Ernst's avatar
      Adress most of the second round of Angelaccio's review comments · 2d4d2ce9
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      This commit applies most suggestions which were made on the MR.
      Most notably the DolphinUrlNavigator class is split up which leads to
      the creation of a DolphinUrlNavigatorsController class.
      
      Additionally some minor coding style and const correctness changes are
      included.
      
      The error value of cached integers is changed from -1 to INT_MIN
      because situations could come up in which -1 would be a valid value.
      2d4d2ce9
    • Felix Ernst's avatar
      Apply Méven Car's suggestions · 42023831
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      42023831
    • Felix Ernst's avatar
      Fix a crash and extract unrelated changes · a418d622
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      The secondary UrlNavigator is now created when and only when:
      - split view mode is activated for the active tab
      OR
      - switching to a tab that has split view already enabled.
      This fixes a crash that occurs when the setting to always start in
      split view mode is enabled.
      
      An animation for activating split view is also removed from this and
      moved into a separate MR. Another unrelated name change left over from
      a previous commit (viewContainers() -> activeViewContainers()) is
      dropped.
      a418d622
    • Felix Ernst's avatar
      Make UrlNavigators in the toolbar the only option · 37327c9b
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      The UrlNavigators will be automatically added to the toolbar. The Sort By
      action is removed from the default toolbar to make space.
      
      Remove all options to have UrlNavigators outside the toolbar and remove
      those code paths.
      
      Make it so the new NavigatorsWidgetAction contains two UrlNavigators when
      in split view mode. Spacing was also added to align these UrlNavigators
      with the ViewContainers when enough space is available.
      
      Force the toolbar to be either at the top or bottom of the window.
      
      Set a sane sizeHint for DolphinUrlNavigator. It would be better to do this
      in KUrlNavigator in the future.
      
      This commit also contains a changes which should be moved to a separate
      merge requests before this gets merged:
      - Add an expansion animation when split view is enabled by the user
      37327c9b
    • Felix Ernst's avatar
      Add the UrlNavigator to the toolbar automatically if needed · 6151a7ae
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      This commit adds the DolphinUrlNavigatorWidgetAction::addToToolbarAndSave()
      method which changes the users toolbar configuration to contain an
      Url Navigator. This way the user doesn't need to do anything manually.
      
      Aside from that a bunch of minor fixes like renaming and reordering
      6151a7ae
    • Felix Ernst's avatar
      Adress the first round of Angelaccio's review comments · b6fc58c3
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      - Split the viewContainers(bool includeInActive) into two methods
          without parameters
      - Prevent users from accidently hiding all Url Navigators by
          preventing the dangerous action and then displaying a helpful
          message instead
      Unrelated to review comments: Remove a useless line of code
      b6fc58c3
    • Felix Ernst's avatar
      trailing whitespaces · 00abc6d2
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      00abc6d2
    • Felix Ernst's avatar
      Add an option to use an UrlNavigator in the toolbar instead · ad5d3367
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      This commit adds a locationInToolbar KToggleAction to switch between
      using a location bar to navigate or using a new custom QWidgetAction
      in the toolbar.
      
      A big portion of this MR is refactoring because until now the
      UrlNavigator was tightly intertwined with the DolphinViewContainer.
      With this MR an UrlNavigator for controlling a View can be freely
      connected or disconnected with a single method call.
      
      A DolphinUrlNavigator class is created in the process which contains all
      Dolphin-specific UrlNavigator code which did previously reside in the
      DolphinViewContainer class. Other application parts that belong to
      UrlNavigator-management are also moved here.
      ad5d3367
  17. 05 Nov, 2020 1 commit
    • Elvis Angelaccio's avatar
      Add support for KUserFeedback · 465e0613
      Elvis Angelaccio authored
      This commit introduces KUserFeedback in dolphin with some basic data
      sources and with a settings page to configure the telemetry values.
      
      There are also a couple custom data sources as proof of concept: a bunch
      of settings and the count of available network shares as listed by Solid.
      
      The settings page is shown only if the user feedback framework is
      enabled, but currently in Plasma we don't have a global kill switch to
      disable it.
      
      At the moment we never show an encouragement message. We need to connect
      to the `Provider::showEncouragementMessage()` signal, but first we
      should agree to a common way to show a non-annoying message to the users.
      465e0613
  18. 23 Oct, 2020 6 commits
  19. 03 Oct, 2020 1 commit
  20. 20 Sep, 2020 1 commit
    • Ahmad Samir's avatar
      Check protocol Class before creating a StatJob · 9b83378c
      Ahmad Samir authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      StatJob::mostLocalUrl only works with ":local" protocols, adjust the code
      accordingly.
      
      Make the code async.
      
      Remove activeContainerLocalPath() method as it isn't needed anymore.
      
      Drive-by change: minimum required version of Qt should be 5.12 because
      that's what KF >= 5.73 already requires.
      9b83378c
  21. 13 Sep, 2020 1 commit
    • Steffen Hartleib's avatar
      Improve Touch support · d7b33b76
      Steffen Hartleib authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      With this patch dolphin now supports the following touch gestures:
      
      * Tap gesture to interact/open with directories, files and so on
      * TapAndHold and release gesture for access to the context menu (main window, panel folder, places and information)
      * TapAndHold and moving gesture for drag and drop action (main windows, panel folder and places)
      * pinch gesture for zoom in main window
      * kinetic scrolling (QScroller) for main window, panel folder, panel places, panel information, setting preview and service
      * two fingers swipe gesture to left, right and up as shortcut to navigate back, forward and up
      * two finger tap gesture to toggle item selection, similar to Ctrl and left mouse click
      
      FEATURE: 385066
      FIXED-IN: 20.11.80
      
       You are currently rebasing branch 'touch' on '85241a92'.
      d7b33b76
  22. 31 Aug, 2020 1 commit
  23. 26 Aug, 2020 1 commit
  24. 25 Aug, 2020 1 commit
  25. 18 Aug, 2020 1 commit
    • Ahmad Samir's avatar
      Port KRun to OpenUrlJob · 257eeebf
      Ahmad Samir authored and David Faure's avatar David Faure committed
      In DolphinMainWindow, since KRun allows running executables by default, use
      setRunExecutables(true) so as not to change the behaviour.
      
      Remove the now redundant slotHandleUrlStatFinished, that whole StatJob
      logic is now handled by OpenUrlJob.
      
      Bump KF required version to 5.73, since that's where
      OpenUrlJob::setShowOpenOrExecuteDialog was introduced.
      257eeebf
  26. 29 Jun, 2020 1 commit
    • Yann Holme-Nielsen's avatar
      ## Summary · 86e3b82e
      Yann Holme-Nielsen authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      * Adds a "Copy location" item, after the "Copy" Context item and Edit Menu, which will attempt to copy the path of the fist item into clipboard.
      
      ## Reasoning
      Most File Managers have this option through one or another way.
      Also using the default Copy option often results in different behaviour depending on the target software, Konsole will take the path. Other Programs will use the URI. Which ultimately could lead to non optimal User Experience.
      
      ## Notes
      * Should the target file **not** be on a local hard drive, this fallback to using the remote URL, feedback is wanted on that matter.
      
      FEATURE: 407004
      86e3b82e
  27. 24 May, 2020 1 commit