1. 15 Dec, 2020 1 commit
  2. 30 Nov, 2020 1 commit
  3. 14 Nov, 2020 1 commit
  4. 23 Oct, 2020 2 commits
  5. 13 Oct, 2020 1 commit
  6. 26 Aug, 2020 1 commit
  7. 25 Aug, 2020 1 commit
  8. 29 Jun, 2020 1 commit
    • Yann Holme-Nielsen's avatar
      ## Summary · 86e3b82e
      Yann Holme-Nielsen authored
      * Adds a "Copy location" item, after the "Copy" Context item and Edit Menu, which will attempt to copy the path of the fist item into clipboard.
      
      ## Reasoning
      Most File Managers have this option through one or another way.
      Also using the default Copy option often results in different behaviour depending on the target software, Konsole will take the path. Other Programs will use the URI. Which ultimately could lead to non optimal User Experience.
      
      ## Notes
      * Should the target file **not** be on a local hard drive, this fallback to using the remote URL, feedback is wanted on that matter.
      
      FEATURE: 407004
      86e3b82e
  9. 15 Mar, 2020 2 commits
    • Nate Graham's avatar
      Add Duplicate feature · 158d12ac
      Nate Graham authored
      Summary: Adds a Duplicate feature to Dolphin, showing up as a menu item in the File menu that appears when one or more items are selected and the directory is writable. Duplicated items receive the names of the original files with " copy" appended before the file extension, if any.
      
      Test Plan:
      
      {F5201386} {F5201393}
      
      Test cases:
      
      - Try to duplicate when nothing is selected: **PASS**: menu item is grayed out
      - Try to duplicate anything on a read-only local volume: **PASS**:  menu item is grayed out
      - Try to duplicate anything on a read-only samba share: **PASS**: menu item is grayed out
      - Duplicate single local file on R/W volume: **PASS**: item is duplicated and named correctly
      - Duplicate multiple local files on R/W volume: **PASS**: 3 items are duplicated, named correctly, and selected
      - Duplicate single local directory on  R/W volume: **PASS**: item is duplicated and named correctly, but a rename operation is not initiated
      - Duplicate multiple local directories on R/W volume: **PASS**: 3 items are duplicated, named correctly, and selected
      - Duplicate single file on R/W samba share: **PASS**: item is duplicated and correctly
      - Duplicate multiple files on R/W samba share: **PASS**: 3 items are duplicated, named correctly, and selected
      - Duplicate single directory on R/W samba share: **PASS**: item is duplicated and named correctly
      - Duplicate multiple directory on R/W samba share: **PASS**: 3 items are duplicated, named correctly, and selected
      - Try to undo a successful duplication: **PASS**: operation is undone
      
      This is my first attempt at a big change like this and I'm sure it's full of issues. I will accept any and all suggestions for improvement. :)
      
      Reviewers: #dolphin, #kde_applications, elvisangelaccio, dfaure, broulik, davidedmundson
      
      Subscribers: kfm-devel, meven, markg, fazevedo, cfeck, #dolphin
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D8208
      158d12ac
    • Nate Graham's avatar
      Add Duplicate feature · 405dd624
      Nate Graham authored
      Summary: Adds a Duplicate feature to Dolphin, showing up as a menu item in the File menu that appears when one or more items are selected and the directory is writable. Duplicated items receive the names of the original files with " copy" appended before the file extension, if any.
      
      Test Plan:
      
      {F5201386} {F5201393}
      
      Test cases:
      
      - Try to duplicate when nothing is selected: **PASS**: menu item is grayed out
      - Try to duplicate anything on a read-only local volume: **PASS**:  menu item is grayed out
      - Try to duplicate anything on a read-only samba share: **PASS**: menu item is grayed out
      - Duplicate single local file on R/W volume: **PASS**: item is duplicated and named correctly
      - Duplicate multiple local files on R/W volume: **PASS**: 3 items are duplicated, named correctly, and selected
      - Duplicate single local directory on  R/W volume: **PASS**: item is duplicated and named correctly, but a rename operation is not initiated
      - Duplicate multiple local directories on R/W volume: **PASS**: 3 items are duplicated, named correctly, and selected
      - Duplicate single file on R/W samba share: **PASS**: item is duplicated and correctly
      - Duplicate multiple files on R/W samba share: **PASS**: 3 items are duplicated, named correctly, and selected
      - Duplicate single directory on R/W samba share: **PASS**: item is duplicated and named correctly
      - Duplicate multiple directory on R/W samba share: **PASS**: 3 items are duplicated, named correctly, and selected
      - Try to undo a successful duplication: **PASS**: operation is undone
      
      This is my first attempt at a big change like this and I'm sure it's full of issues. I will accept any and all suggestions for improvement. :)
      
      Reviewers: #dolphin, #kde_applications, elvisangelaccio, dfaure, broulik, davidedmundson
      
      Subscribers: kfm-devel, meven, markg, fazevedo, cfeck, #dolphin
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D8208
      405dd624
  10. 14 Feb, 2020 1 commit
    • Nate Graham's avatar
      Restore former position of "Create New" menu item in viewport context menu · 4c923a53
      Nate Graham authored
      Summary:
      I've seem various complaints from users about the fact that the {nav Create New...} menu
      item in the viewport context menu is now below {nav Open With} item. All the other
      changes to menus seem to have been well-received but this one has garnered criticism.
      Looking through D23757 and D11884, I can't actually see that this was intentional, so
      it might even be a bug.
      
      Either way, this patch restores the old position of the {nav Create New} menu items at
      the top of the Viewport context menu.
      
      BUG: 417640
      FIXED-IN: 20.04.0
      
      Test Plan: {F8093605}
      
      Reviewers: #vdg, #dolphin, elvisangelaccio, ndavis
      
      Reviewed By: #vdg, ndavis
      
      Subscribers: asturmlechner, markuss, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D27267
      4c923a53
  11. 12 Feb, 2020 1 commit
    • Ilya Bizyaev's avatar
      Swap "Open in New Window" and "Open in New Tab" in context menus · 402f7f30
      Ilya Bizyaev authored
      Summary:
      Since Dolphin's default behaviour became opening in new tabs rather than in new windows
      (a very positive change, in my opinion), I always find myself accidentally opening folders
      in new windows from the context menu. This is because in most browsers with tab workflow
      (e.g. Firefox, Chromium, Falkon) the top context menu action is opening in a new tab, and
      my muscle memory plays a bad trick :) I'm aware of middle-clicking, but I find it
      inconvenient with my touchpad.
      
      I suspect I'm probably not alone in that, so I think it makes sense to swap these actions
      in Dolphin to match widely used apps.
      
      Test Plan:
      Open Dolphin, right click folders in the main view and in the Places panel, ensure the
      actions are indeed swapped
      
      Reviewers: #vdg, ndavis, #dolphin, ngraham
      
      Reviewed By: #vdg, ndavis, #dolphin, ngraham
      
      Subscribers: ngraham, ndavis, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D27318
      402f7f30
  12. 23 Dec, 2019 1 commit
  13. 06 Dec, 2019 1 commit
  14. 02 Dec, 2019 1 commit
  15. 01 Dec, 2019 1 commit
  16. 23 Nov, 2019 1 commit
  17. 15 Sep, 2019 1 commit
    • Nate Graham's avatar
      Clean up hamburger menu and viewport and single-folder context menus · 0303df09
      Nate Graham authored
      Summary:
      Dolphin's hamburger and context menus have grown organically over time,
      becoming a bit messy and somewhat visually overwhelming. This makes them
      harder to parse and more intimidating to use.
      
      This patch cleans up the hamburger menu and viewport and single-folder context
      menus to group items more logically, and remove items that aren't actually relevant
      to the context.
      
      The hamburger menu part of the patch is fairly significant, and draws from the
      principle of only showing actions with a global scope that are not already accessible
      from another visible method (e.g. via the default toolbar). In the end, it manages to be
      shorter than the current hamburger menu with expose actions that are more relevant.
      
      A visible method to display context-specific actions should be explored separately
      (see https://bugs.kde.org/show_bug.cgi?id=411500).
      
      Depends on D23945
      
      Test Plan:
      Before, hamburger menu: {F7334178}
      After, hamburger menu: {F7350958}
      
      Before, viewport: {F7324802}
      After, viewport: {F7330109}
      
      Before, one folder selected: {F7324798}
      After, one folder selected: {F7341163}
      
      No change for the context menus shown when selecting a single item, multiple items, or multiple folders
      
      Reviewers: #vdg, #dolphin, meven, elvisangelaccio, GB_2
      
      Reviewed By: #vdg, #dolphin, meven, elvisangelaccio, GB_2
      
      Subscribers: GB_2, mmustac, elvisangelaccio, meven, ndavis, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D23757
      0303df09
  18. 08 Sep, 2019 1 commit
  19. 04 Sep, 2019 1 commit
    • Luca Beltrame's avatar
      Unbreak context menu showing when right clicking on an empty area · d23fba32
      Luca Beltrame authored
      In D22149, a request was made to remove a variable assignment ("action",
      on line 389 in src/dolphincontextmenu.cpp. However the change went too
      far, and it actually removed the exec() call, not just the assignment
      which should have stayed.
      
      This resulted in the context menu not being shown at all.
      
      Adding back exec(m_pos) at least allows for the context menu to show.
      
      CCMAIL: nate@kde.org
      d23fba32
  20. 01 Sep, 2019 1 commit
    • Nate Graham's avatar
      Add "Add to Places" action to file menu · 7cad80b2
      Nate Graham authored
      Summary:
      It's recommended that actions available in context menus be available in the main menu
      as well for discoverability's sake. This patch does so for the "Add to Places" action.
      
      The action is moved over to the main window, and accessed in the context menu via the
      actionCollection it lives in.
      
      BUG: 390757
      FIXED-IN: 19.08.0
      
      Test Plan:
      - Action still works
      - Action still appears in context menu when relevant
      - Action in the File menu only becomes enabled when only a single directory is selected or nothing is selected
      
      {F7143876}
      
      {F7143877}
      
      {F7143878}
      
      {F7143879}
      
      Reviewers: #dolphin, elvisangelaccio
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: elvisangelaccio, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D22149
      7cad80b2
  21. 07 Jun, 2019 1 commit
  22. 10 Apr, 2019 1 commit
    • Nate Graham's avatar
      Don't show "Open With" menu items for empty directories · 14f0cd52
      Nate Graham authored
      Summary:
      Any app that registers itself as able to open directories generally can't do anything
      useful with an empty directory. So, don't show the {nav Open With} menu items for them.
      
      Test Plan:
      Before: {F6759793}
      
      After: {F6759794}
      
      The {nav Open With} items still appear for non-empty directories.
      
      Reviewers: #dolphin, elvisangelaccio
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: trmdi, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D20396
      14f0cd52
  23. 10 Dec, 2018 3 commits
  24. 06 Dec, 2018 1 commit
  25. 19 Nov, 2018 1 commit
    • Thomas Surrel's avatar
      Show the Delete context menu entry even when disabled · 1340e985
      Thomas Surrel authored
      Summary:
      This is consistent with the HIG, and the 'Rename' entry in
      the context menu already behaves like that.
      
      Test Plan:
      Right click on /home. The context menu should contained
      the 'Delete' entry, but it should be disabled.
      
      Reviewers: #dolphin, #vdg, ngraham
      
      Reviewed By: #dolphin, #vdg, ngraham
      
      Subscribers: ngraham, romangg, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D17012
      1340e985
  26. 05 Sep, 2018 1 commit
  27. 19 Jul, 2018 1 commit
    • David Hallas's avatar
      Fixes small memory leak in DolphinContextMenu · 2cbf3cb1
      David Hallas authored
      Summary: When DolphinContextMenu::baseFileItem is called a KFileItem is allocated and stored in DolphinContextMenu::m_baseFileItem, which is of type KFileItem*, but the destructor failed to delete this.
      
      Test Plan: This leak was found using Address Sanitizer
      
      Reviewers: broulik, elvisangelaccio
      
      Reviewed By: broulik, elvisangelaccio
      
      Subscribers: ngraham, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D14178
      2cbf3cb1
  28. 18 Jul, 2018 1 commit
    • David Hallas's avatar
      Fixes small memory leak in DolphinContextMenu · f186124f
      David Hallas authored
      Summary: When DolphinContextMenu::baseFileItem is called a KFileItem is allocated and stored in DolphinContextMenu::m_baseFileItem, which is of type KFileItem*, but the destructor failed to delete this.
      
      Test Plan: This leak was found using Address Sanitizer
      
      Reviewers: broulik, elvisangelaccio
      
      Reviewed By: broulik, elvisangelaccio
      
      Subscribers: ngraham, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D14178
      f186124f
  29. 02 Jun, 2018 1 commit
    • Nerdopolis Turfwalker's avatar
      Add 'Sort By' and 'View Mode' into Dolphin file context menus · 97801e2c
      Nerdopolis Turfwalker authored
      Summary: This adds the 'Sort By' and 'View Mode'  options into the context menu of Dolphin within the file browser. I keep looking for these option (especially sort by) in the Context Menu, and keep forgetting to go to the menu. It also makes the order of "View Mode" and "Sort By" options consistent in the control menu
      
      Test Plan: Made sure that the options appeared when right clicking on an empty space.
      
      Reviewers: #dolphin, ngraham, elvisangelaccio
      
      Reviewed By: #dolphin, ngraham, elvisangelaccio
      
      Subscribers: question, markg, elvisangelaccio, mmustac, rkflx, ngraham, kfm-devel, #dolphin
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D12911
      97801e2c
  30. 20 May, 2018 1 commit
  31. 14 May, 2018 1 commit
  32. 22 Apr, 2018 1 commit
    • Nate Graham's avatar
      Move "Open" actions to the top of the context menu for files · b9143a55
      Nate Graham authored
      Summary:
      This patch moves the "Open", "Open With", and "Open in" items to the top of the context menu to reap the following benefits:
      - Move the "Open" and "Open With" items closer to the top since they're commonly used items, and right now they're buried in the middle of the menu
      - Group related functionality
      - Consistency with other common platforms (macOS Finder and Windows Explorer both have these items at the top of the context menu)
      
      For folders, the "Open With" entries are moved higher, but not all the way to the top, since the "open in New tab/folder" entries are more useful.
      
      Test Plan:
      Tested all menu items in the context menu for files, folders, and links; all still work.
      
      Context menu for single file:
      {F5806809}
      
      Context menu for multiple files:
      {F5806810}
      
      Context menu for single folder:
      {F5806811}
      
      Context menu for multiple folders:
      {F5806812}
      
      Context menu for symlink to folder:
      {F5806815}
      
      Reviewers: #dolphin, #vdg, elvisangelaccio, abetts
      
      Reviewed By: #dolphin, #vdg, elvisangelaccio, abetts
      
      Subscribers: markg, abetts, elvisangelaccio
      
      Differential Revision: https://phabricator.kde.org/D11884
      b9143a55
  33. 24 Mar, 2018 1 commit
  34. 22 Mar, 2018 1 commit
    • Nate Graham's avatar
      Fix missing entries in context menu for links · f728d728
      Nate Graham authored
      Summary: https://cgit.kde.org/dolphin.git/commit/?id=86f4fcb8cd574f6d886627fc5e01c9edfc84e977 introduced a regression: the context menu for links no longer shows various items that were gated behind being a directory. However, a link can be both a link and a directory, from KIO's perspective. This patch resolves the issue.
      
      Test Plan:
      - Context menus for files, folders, and file links are unchanged.
      - The missing context menu items for folder links have returned: {F5761809}
      
      I should have tested that patch better, and for that I apologize and offer to fix this regression here. I will endeavor to up my reviewing game.
      
      Reviewers: rominf, michaelh, #dolphin, rkflx
      
      Reviewed By: rominf, rkflx
      
      Subscribers: rkflx
      
      Differential Revision: https://phabricator.kde.org/D11562
      f728d728
  35. 21 Mar, 2018 1 commit
  36. 18 Mar, 2018 1 commit