1. 09 Jan, 2021 1 commit
  2. 06 Jan, 2021 1 commit
    • Felix Ernst's avatar
      Fix location bar being wrongly aligned on first startup · 0cee94ce
      Felix Ernst authored
      When starting Dolphin the very first time, the spacing in front of the
      location bar is wrong. This commit fixes this by completely updating
      all cached geometry every time adjustSpacing() is called. Because this
      happens once on a timer 100 ms after every url change, it will happen
      once shortly after the window is shown. At that point all geometry is
      where it should be and spacing calculation works as expected.
      
      The ViewContainer geometry retrieval is refactored into a small nested
      helper class in DolphinNavigatorsWidgetAction by the name
      ViewGeometriesHelper.
      
      Previously the logic of that class was divided between DolphinTabPage
      and DolphinNavigatorsWidgetAction.
      
      BUG: 429447
      FIXED-IN: 21.04.0
      0cee94ce
  3. 27 Dec, 2020 1 commit
    • Nate Graham's avatar
      Make it more obvious that you can connect to servers on remote:/ page · b14f98de
      Nate Graham authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      Right now it is not super obvious how you connect to a remote server
      in Dolphin when you already know the URL. Users will go to the
      "Network" item in the Places panel, but from there it is not totally
      clear. The "Add Network Folder" icon in the view opens a complicated
      wizard and it's also a bit of an odd UX to have it living in the view as
      opposed to being a toolbar button.
      
      Old hands and developers know that the URL navigator is, well, a URL
      navigator, and as such, it accepts arbitrary URLs from any view.
      However this may not be obvious to other more casual users, for
      two reasons:
      1. The URL navigator is in breadcrumbs view nearly all of the time and
         by default, so may users may not know that it can accept text at all
      2. Even when it's displaying URLs, they are almost always local paths,
         so users may not make the connection that it can accept remote URLs
         rather that just local paths
      
      To improve the discoverability of this fea...
      b14f98de
  4. 22 Nov, 2020 1 commit
  5. 19 Nov, 2020 1 commit
    • Felix Ernst's avatar
      Allow having the UrlNavigators below the tab bar · 50ca5af7
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      This commit restores the possibility to have the UrlNavigators below
      the tab bar. This will happen automatically whenever the UrlNavigator
      is removed from the toolbar.
      
      It is also now again possible to have the toolbar on the side. This
      option is disabled while the toolbar contains the UrlNavigators.
      
      This commit makes no changes to the new default which is having the
      UrlNavigators in the toolbar but makes sure that upgrading users won't
      be affected.
      50ca5af7
  6. 13 Nov, 2020 1 commit
  7. 09 Nov, 2020 4 commits
    • Felix Ernst's avatar
      Adress the third round of Angelaccio's review comments · 63f4981f
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      Additionally remove some redundant code concerning UrlNavigator visuals.
      63f4981f
    • Felix Ernst's avatar
      Adress most of the second round of Angelaccio's review comments · 2d4d2ce9
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      This commit applies most suggestions which were made on the MR.
      Most notably the DolphinUrlNavigator class is split up which leads to
      the creation of a DolphinUrlNavigatorsController class.
      
      Additionally some minor coding style and const correctness changes are
      included.
      
      The error value of cached integers is changed from -1 to INT_MIN
      because situations could come up in which -1 would be a valid value.
      2d4d2ce9
    • Felix Ernst's avatar
      Apply Méven Car's suggestions · 42023831
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      42023831
    • Felix Ernst's avatar
      Make UrlNavigators in the toolbar the only option · 37327c9b
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      The UrlNavigators will be automatically added to the toolbar. The Sort By
      action is removed from the default toolbar to make space.
      
      Remove all options to have UrlNavigators outside the toolbar and remove
      those code paths.
      
      Make it so the new NavigatorsWidgetAction contains two UrlNavigators when
      in split view mode. Spacing was also added to align these UrlNavigators
      with the ViewContainers when enough space is available.
      
      Force the toolbar to be either at the top or bottom of the window.
      
      Set a sane sizeHint for DolphinUrlNavigator. It would be better to do this
      in KUrlNavigator in the future.
      
      This commit also contains a changes which should be moved to a separate
      merge requests before this gets merged:
      - Add an expansion animation when split view is enabled by the user
      37327c9b