1. 08 Feb, 2021 4 commits
    • Nicolas Fella's avatar
      Add missing includes · b68abb7d
      Nicolas Fella authored
      b68abb7d
    • Ahmad Samir's avatar
      Port away from deprecated KIO signals · dd9405bf
      Ahmad Samir authored
      Use KDirLister::listingDirCompleted(const QUrl &) instead of
      completed(const QUrl &).
      dd9405bf
    • Felix Ernst's avatar
      Avoid KJob::exec() in DolphinView · a825e1bd
      Felix Ernst authored
      This commit replaces an error-prone usage of KIO::StatJob::exec() in
      DolphinView with the recommended KIO::StatJob::start().
      
      The containing method DolphinView::statusBarText() is changed to be a
      method without return value: requestStatusBarText()
      The new status bar text is instead returned through a new
      setStatusBarText() signal that will be emitted asynchronously if
      necessary.
      
      The calling code that deals with status bar text is refactored to
      correctly work despite the new asynchronicity. The helper method
      calculateItemCount() is moved into requestStatusBarText() and some
      other code from requestStatusBarText() is moved into a new helper
      method emitStatusBarText().
      
      The documentation of KIO::KJob::exec() explains why it should be
      avoided. A reproducible crash is the reason for this commit.
      a825e1bd
    • Script Kiddy's avatar
      GIT_SILENT made messages (after extraction) · 7eae6bba
      Script Kiddy authored
      7eae6bba
  2. 29 Jan, 2021 1 commit
  3. 25 Jan, 2021 2 commits
    • Nate Graham's avatar
      Merge branch 'release/20.12' · c161b895
      Nate Graham authored
      c161b895
    • Harald Sitter's avatar
      don't crash when building without baloo · 5ed12ed4
      Harald Sitter authored
      show_information_panel is only created when building with baloo. only
      access it when built with baloo, otherwise always report the panel as
      off.
      
      this fixes a nullptr deref because action() would return a nullptr since
      show_information_panel isn't a thing in all build configurations
      
      (full disclosure: I can't reproduce the crash, nor did I build without
      baloo)
      
      BUG: 431730
      5ed12ed4
  4. 23 Jan, 2021 3 commits
  5. 21 Jan, 2021 1 commit
  6. 18 Jan, 2021 2 commits
  7. 17 Jan, 2021 2 commits
  8. 16 Jan, 2021 3 commits
  9. 15 Jan, 2021 3 commits
  10. 14 Jan, 2021 1 commit
  11. 12 Jan, 2021 1 commit
  12. 11 Jan, 2021 8 commits
  13. 10 Jan, 2021 3 commits
  14. 09 Jan, 2021 2 commits
  15. 08 Jan, 2021 1 commit
  16. 06 Jan, 2021 1 commit
    • Felix Ernst's avatar
      Fix location bar being wrongly aligned on first startup · 0cee94ce
      Felix Ernst authored
      When starting Dolphin the very first time, the spacing in front of the
      location bar is wrong. This commit fixes this by completely updating
      all cached geometry every time adjustSpacing() is called. Because this
      happens once on a timer 100 ms after every url change, it will happen
      once shortly after the window is shown. At that point all geometry is
      where it should be and spacing calculation works as expected.
      
      The ViewContainer geometry retrieval is refactored into a small nested
      helper class in DolphinNavigatorsWidgetAction by the name
      ViewGeometriesHelper.
      
      Previously the logic of that class was divided between DolphinTabPage
      and DolphinNavigatorsWidgetAction.
      
      BUG: 429447
      FIXED-IN: 21.04.0
      0cee94ce
  17. 05 Jan, 2021 2 commits