1. 08 Feb, 2021 1 commit
  2. 16 Jan, 2021 1 commit
  3. 09 Dec, 2020 1 commit
  4. 22 Nov, 2020 1 commit
  5. 17 Nov, 2020 3 commits
  6. 23 Oct, 2020 2 commits
  7. 14 Oct, 2020 1 commit
    • Elvis Angelaccio's avatar
      Port away from QList::toSet() · 3bf2922e
      Elvis Angelaccio authored
      The QSet range constructor requires Qt 5.14.
      
      In `DolphinView::slotHeaderContextMenuRequested()` the conversion from
      QList to QSet was pointless, so we just use a QList now.
      3bf2922e
  8. 22 Sep, 2020 1 commit
    • Nate Graham's avatar
      Make "Show hidden files" action follow HIG · 15928112
      Nate Graham authored
      The action is a toggle action, for which the HIG prescribes that the
      text should describe the action's checked state, and neither the text
      nor the icon should change when the action is checked. Other toggle
      actions in Dolphin follow these rules, but this one does not.
      
      This commit makes the action follow those rules.
      15928112
  9. 26 Aug, 2020 1 commit
  10. 25 Aug, 2020 1 commit
  11. 29 Jun, 2020 1 commit
    • Yann Holme-Nielsen's avatar
      ## Summary · 86e3b82e
      Yann Holme-Nielsen authored
      * Adds a "Copy location" item, after the "Copy" Context item and Edit Menu, which will attempt to copy the path of the fist item into clipboard.
      
      ## Reasoning
      Most File Managers have this option through one or another way.
      Also using the default Copy option often results in different behaviour depending on the target software, Konsole will take the path. Other Programs will use the URI. Which ultimately could lead to non optimal User Experience.
      
      ## Notes
      * Should the target file **not** be on a local hard drive, this fallback to using the remote URL, feedback is wanted on that matter.
      
      FEATURE: 407004
      86e3b82e
  12. 20 Apr, 2020 1 commit
    • Nate Graham's avatar
      Use new "Show/Hide Hidden Files" standard shortcut · bb48d4f1
      Nate Graham authored
      Summary:
      Note that we lose the F8 shortcut since the KStandardShortcut added in XXXX can only
      accommodate toew default shortcuts, and I thought Ctrl+H and Alt+. were the more important
      ones. Hopefully that's not too high a price to pay.
      
      Depends on D28802
      
      Test Plan:
      - Apply D28802 to kconfig
      - Apply this patch to Dolphin, compile, and launch Dolphin
      - Hit Ctrl+H or Alt+. and see that hidden files are shown or hidden as approproiate
      
      Reviewers: #dolphin, dfaure, elvisangelaccio
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: elvisangelaccio, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D28804
      bb48d4f1
  13. 15 Mar, 2020 2 commits
    • Nate Graham's avatar
      Add Duplicate feature · 158d12ac
      Nate Graham authored
      Summary: Adds a Duplicate feature to Dolphin, showing up as a menu item in the File menu that appears when one or more items are selected and the directory is writable. Duplicated items receive the names of the original files with " copy" appended before the file extension, if any.
      
      Test Plan:
      
      {F5201386} {F5201393}
      
      Test cases:
      
      - Try to duplicate when nothing is selected: **PASS**: menu item is grayed out
      - Try to duplicate anything on a read-only local volume: **PASS**:  menu item is grayed out
      - Try to duplicate anything on a read-only samba share: **PASS**: menu item is grayed out
      - Duplicate single local file on R/W volume: **PASS**: item is duplicated and named correctly
      - Duplicate multiple local files on R/W volume: **PASS**: 3 items are duplicated, named correctly, and selected
      - Duplicate single local directory on  R/W volume: **PASS**: item is duplicated and named correctly, but a rename operation is not initiated
      - Duplicate multiple local directories on R/W volume: **PASS**: 3 items are duplicated, named correctly, and selected
      - Duplicate single file on R/W samba share: **PASS**: item is duplicated and correctly
      - Duplicate multiple files on R/W samba share: **PASS**: 3 items are duplicated, named correctly, and selected
      - Duplicate single directory on R/W samba share: **PASS**: item is duplicated and named correctly
      - Duplicate multiple directory on R/W samba share: **PASS**: 3 items are duplicated, named correctly, and selected
      - Try to undo a successful duplication: **PASS**: operation is undone
      
      This is my first attempt at a big change like this and I'm sure it's full of issues. I will accept any and all suggestions for improvement. :)
      
      Reviewers: #dolphin, #kde_applications, elvisangelaccio, dfaure, broulik, davidedmundson
      
      Subscribers: kfm-devel, meven, markg, fazevedo, cfeck, #dolphin
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D8208
      158d12ac
    • Nate Graham's avatar
      Add Duplicate feature · 405dd624
      Nate Graham authored
      Summary: Adds a Duplicate feature to Dolphin, showing up as a menu item in the File menu that appears when one or more items are selected and the directory is writable. Duplicated items receive the names of the original files with " copy" appended before the file extension, if any.
      
      Test Plan:
      
      {F5201386} {F5201393}
      
      Test cases:
      
      - Try to duplicate when nothing is selected: **PASS**: menu item is grayed out
      - Try to duplicate anything on a read-only local volume: **PASS**:  menu item is grayed out
      - Try to duplicate anything on a read-only samba share: **PASS**: menu item is grayed out
      - Duplicate single local file on R/W volume: **PASS**: item is duplicated and named correctly
      - Duplicate multiple local files on R/W volume: **PASS**: 3 items are duplicated, named correctly, and selected
      - Duplicate single local directory on  R/W volume: **PASS**: item is duplicated and named correctly, but a rename operation is not initiated
      - Duplicate multiple local directories on R/W volume: **PASS**: 3 items are duplicated, named correctly, and selected
      - Duplicate single file on R/W samba share: **PASS**: item is duplicated and correctly
      - Duplicate multiple files on R/W samba share: **PASS**: 3 items are duplicated, named correctly, and selected
      - Duplicate single directory on R/W samba share: **PASS**: item is duplicated and named correctly
      - Duplicate multiple directory on R/W samba share: **PASS**: 3 items are duplicated, named correctly, and selected
      - Try to undo a successful duplication: **PASS**: operation is undone
      
      This is my first attempt at a big change like this and I'm sure it's full of issues. I will accept any and all suggestions for improvement. :)
      
      Reviewers: #dolphin, #kde_applications, elvisangelaccio, dfaure, broulik, davidedmundson
      
      Subscribers: kfm-devel, meven, markg, fazevedo, cfeck, #dolphin
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D8208
      405dd624
  14. 15 Dec, 2019 1 commit
    • Nate Graham's avatar
      Don't overload the word "Properties" to mean multiple things · f6229562
      Nate Graham authored
      Summary:
      Generally "Properties" refers to information about a selected file. However Dolphin also
      uses the word "Properties" in the phrase "View Properties", which refers to the display
      style of the view. Since "properties" is a fairly esoteric and technical term to most
      users, it would probably be wise to avoid using it in multiple contexts.
      
      Accordingly, this patch changes "view properties" to "view display style".
      
      Test Plan: Look at the settings window, hamburger menu, view menu, and docbook
      
      Reviewers: #vdg, #dolphin, ndavis, elvisangelaccio
      
      Reviewed By: #vdg, #dolphin, ndavis, elvisangelaccio
      
      Subscribers: ndavis, kfm-devel, kde-doc-english
      
      Tags: #dolphin, #documentation
      
      Differential Revision: https://phabricator.kde.org/D25987
      f6229562
  15. 09 Nov, 2019 1 commit
  16. 14 Sep, 2019 2 commits
  17. 10 Sep, 2019 1 commit
  18. 09 Sep, 2019 1 commit
    • Nate Graham's avatar
      Fix ascending/descending choosers getting unchecked when re-selecting the same sort order · 60d6a3bd
      Nate Graham authored
      Summary:
      When you select the same sort order that's already selected, the currently-checked
      sort order description (the human-readable ascending/descending items) gets unchecked
      in `slotSortTriggered()` yet the ascending/descending items items only get checked in
      `slotSortOrderChanged()`. Because the order hasn't gotten changed, neither one gets
      checked again.
      
      This patch fixes the problem by not unchecking them in the first place.
      
      BUG: 411223
      FIXED-IN: 19.08.2
      
      Test Plan:
      1. Right-click > Sort By > Click the currently-selected sort order
      2. Right-click > Sort By > See that the item for the current ascending/descending setting has not been changed
      
      Reviewers: elvisangelaccio, #dolphin
      
      Reviewed By: elvisangelaccio, #dolphin
      
      Subscribers: broulik, meven, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D23412
      60d6a3bd
  19. 04 Sep, 2019 1 commit
  20. 14 Aug, 2019 1 commit
  21. 13 Aug, 2019 1 commit
  22. 29 Jul, 2019 1 commit
  23. 04 Jul, 2019 1 commit
    • Nicolas Fella's avatar
      Use more human-readable sort order descriptions · 95270333
      Nicolas Fella authored
      Summary:
      Anecdotal evidence shows that ascending/descending regularly takes people longer to process than necessary. This patch implements more human-friendly sort order descriptions, in particular:
      
      A-Z/Z-A for text
      Newest first/oldest-first for time
      Lowest first/highest first for rating
      smallest first/largest first for sizes
      
      If there is no string for a particular role defined it will fall back to Ascending/Descending.
      
      I'm aware that not every language uses A-Z. In this case the translator can pick any string that represents the concept of text sorting
      
      Test Plan: Sort view in various ways
      
      Reviewers: #dolphin, #vdg, ngraham
      
      Reviewed By: #dolphin, #vdg, ngraham
      
      Subscribers: ngraham, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D22006
      95270333
  24. 23 Jun, 2019 1 commit
    • Felix Ernst's avatar
      Add "What's This?" to nearly everything in the main window · bd788a3f
      Felix Ernst authored
      Summary:
      This commit adds "What's This?" help to nearly everything in the
      Dolphin main window (panels, views, buttons, ...). It adds the "?"
      to the title bar so this help can easily be called.
      
      For links in those help texts to work the WhatsThisClickedEvents are
      handled in the main window class. This doesn't work for menus because
      events from them aren't forwarded to the main window for some
      reason so EventFilters are installed for the Control button menus.
      
      Modifying the "Help" menu of KXmlGui is deprecated so no EventFilter
      can be installed in the menubar. Therefore help texts without links
      are provided for the menubar.
      
      Test Plan:
      Check if the event handling might make any problems.
      Check for any big mistakes in the help messages.
      
      Reviewers: #dolphin, elvisangelaccio
      
      Subscribers: broulik, elvisangelaccio, yurchor, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D20471
      bd788a3f
  25. 05 May, 2019 1 commit
  26. 24 Feb, 2019 1 commit
  27. 24 Oct, 2018 1 commit
  28. 13 Apr, 2018 1 commit
  29. 04 Mar, 2018 1 commit
  30. 03 Mar, 2018 2 commits
  31. 18 Feb, 2018 1 commit
    • Nathaniel Graham's avatar
      Also use standard keyboard shortcut for "show/hide hidden files" · b95cc590
      Nathaniel Graham authored
      Summary:
      Use Ctrl+H as another keyboard shortcut to show and hide hidden files, as it is already the standard used in other GTK-based Linux file managers (Nautilus, Nemo, Caja, Thunar, Pantheon Files). This doesn't replace any existing shortcuts, so existing KDE users' muscle memory is retained.
      
      FEATURE: 390527
      FIXED-IN: KDE Applications 17.12.3
      
      Test Plan:
      - Ctrl+H now shows and hides hidden files
      - Alt+. still works to do the same
      - F8 still works to do the same
      - Toolbar button still changes state appropriately when any of the three shortcuts are used
      
      Reviewers: #dolphin, elvisangelaccio
      
      Reviewed By: elvisangelaccio
      
      Subscribers: emateli, elvisangelaccio
      
      Differential Revision: https://phabricator.kde.org/D10558
      b95cc590
  32. 21 Nov, 2017 1 commit
  33. 16 Oct, 2017 1 commit
  34. 17 Sep, 2017 1 commit
    • Elvis Angelaccio's avatar
      Make sure we always have Shift+Del as shortcut · cdd002c5
      Elvis Angelaccio authored
      After commit 68bb0ec2 the shortcut for the Delete action is not
      necessarily Shift+Del, but whatever the user set in System Setting.
      However DolphinRemoveAction assumes/hardcodes Shift+Del, so we should
      always make sure we have this shortcut around, for consistency.
      
      We just need to add it (if necessary) to the list of shortcuts of the
      action. However:
      
      * for the actual Delete action, we need to append it (if we'd prepend it,
        it would override a custom primary shortcut in the 'Configure Shortcuts' dialog).
      * for DolphinRemoveAction, we need to prepend it in order to have
        Shift+Del (rather than the custom primary shortcut) in the context menu.
      
      Differential Revision: https://phabricator.kde.org/D7655
      cdd002c5