1. 18 Sep, 2020 1 commit
  2. 13 Sep, 2020 1 commit
    • Steffen Hartleib's avatar
      Improve Touch support · d7b33b76
      Steffen Hartleib authored
      With this patch dolphin now supports the following touch gestures:
      
      * Tap gesture to interact/open with directories, files and so on
      * TapAndHold and release gesture for access to the context menu (main window, panel folder, places and information)
      * TapAndHold and moving gesture for drag and drop action (main windows, panel folder and places)
      * pinch gesture for zoom in main window
      * kinetic scrolling (QScroller) for main window, panel folder, panel places, panel information, setting preview and service
      * two fingers swipe gesture to left, right and up as shortcut to navigate back, forward and up
      * two finger tap gesture to toggle item selection, similar to Ctrl and left mouse click
      
      FEATURE: 385066
      FIXED-IN: 20.11.80
      
       You are currently rebasing branch 'touch' on '85241a92'.
      d7b33b76
  3. 25 Aug, 2020 1 commit
  4. 29 Jun, 2020 1 commit
    • Yann Holme-Nielsen's avatar
      ## Summary · 86e3b82e
      Yann Holme-Nielsen authored
      * Adds a "Copy location" item, after the "Copy" Context item and Edit Menu, which will attempt to copy the path of the fist item into clipboard.
      
      ## Reasoning
      Most File Managers have this option through one or another way.
      Also using the default Copy option often results in different behaviour depending on the target software, Konsole will take the path. Other Programs will use the URI. Which ultimately could lead to non optimal User Experience.
      
      ## Notes
      * Should the target file **not** be on a local hard drive, this fallback to using the remote URL, feedback is wanted on that matter.
      
      FEATURE: 407004
      86e3b82e
  5. 01 Jun, 2020 1 commit
    • Nate Graham's avatar
      Show progress when duplicating items · 70b3f61e
      Nate Graham authored
      For unknown reasons, when I implemented this feature, I turned off
      progress notifications. I don't think this makes any sense, and we just
      got a bug report about it.
      
      Accordingly, this patches turns on progress notifications.
      
      BUG: 422335
      FIXED-IN: 20.04.2
      70b3f61e
  6. 31 May, 2020 1 commit
    • Méven Car's avatar
      Prevents warnings · 770d0831
      Méven Car authored
      Warnings such as :
      kf5.kio.core: Invalid URL: QUrl("")
      
      It happened for instance with recentlyused:/ ioslave
      770d0831
  7. 30 May, 2020 1 commit
  8. 18 May, 2020 1 commit
  9. 14 May, 2020 1 commit
  10. 11 May, 2020 2 commits
  11. 06 May, 2020 1 commit
    • Ahmad Samir's avatar
      Port QRegExp to QRegularExpression · e3c03e46
      Ahmad Samir authored
      Summary:
      Port QRegExp::exactMatch() with QRegularExpression::anchoredPattern().
      Port QRegExp::Wildcard with QRegularExpression::wildcardToRegularExpression().
      Note that QRegularExpression::wildcardToRegularExpression() returns an anchored
      pattern.
      
      Test Plan:
      Using the filter bar in dolphin works as before.
      
      All unit tests pass, except:
      - kfileitemmodeltest (which is unrelated AFAICS); it fails on master too
      - placesitemmodeltest, which fails on master too
      
      Reviewers: #dolphin, elvisangelaccio, meven
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D26215
      e3c03e46
  12. 04 May, 2020 1 commit
  13. 18 Apr, 2020 1 commit
  14. 14 Apr, 2020 1 commit
  15. 05 Apr, 2020 1 commit
    • Nate Graham's avatar
      Use same logic for "no extension" case with Duplicate feature · 9b82b08f
      Nate Graham authored
      Summary:
      In the "no extension" case, we weren't separating out the path and the original filename,
      breaking the feature for languages where the word "copy" would be at the beginning of the
      filename, not after it (e.g. "copia de foo" in Spanish, and similar in other romance
      languages). This patch fixes that by separating the original path and filename in the no
      extension case as is done for the other case, which should solve the issue.
      
      BUG: 419070
      FIXED-IN: 20.04.0
      
      Test Plan:
      No changes in English; should fix the issue in Spanish once new translations are done
      (see https://bugs.kde.org/show_bug.cgi?id=419070 for details)
      
      Reviewers: #dolphin, elvisangelaccio, arojas, meven, pino, #localization
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: aacid, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D28227
      9b82b08f
  16. 17 Mar, 2020 1 commit
  17. 15 Mar, 2020 2 commits
    • Nate Graham's avatar
      Add Duplicate feature · 158d12ac
      Nate Graham authored
      Summary: Adds a Duplicate feature to Dolphin, showing up as a menu item in the File menu that appears when one or more items are selected and the directory is writable. Duplicated items receive the names of the original files with " copy" appended before the file extension, if any.
      
      Test Plan:
      
      {F5201386} {F5201393}
      
      Test cases:
      
      - Try to duplicate when nothing is selected: **PASS**: menu item is grayed out
      - Try to duplicate anything on a read-only local volume: **PASS**:  menu item is grayed out
      - Try to duplicate anything on a read-only samba share: **PASS**: menu item is grayed out
      - Duplicate single local file on R/W volume: **PASS**: item is duplicated and named correctly
      - Duplicate multiple local files on R/W volume: **PASS**: 3 items are duplicated, named correctly, and selected
      - Duplicate single local directory on  R/W volume: **PASS**: item is duplicated and named correctly, but a rename operation is not initiated
      - Duplicate multiple local directories on R/W volume: **PASS**: 3 items are duplicated, named correctly, and selected
      - Duplicate single file on R/W samba share: **PASS**: item is duplicated and correctly
      - Duplicate multiple files on R/W samba share: **PASS**: 3 items are duplicated, named correctly, and selected
      - Duplicate single directory on R/W samba share: **PASS**: item is duplicated and named correctly
      - Duplicate multiple directory on R/W samba share: **PASS**: 3 items are duplicated, named correctly, and selected
      - Try to undo a successful duplication: **PASS**: operation is undone
      
      This is my first attempt at a big change like this and I'm sure it's full of issues. I will accept any and all suggestions for improvement. :)
      
      Reviewers: #dolphin, #kde_applications, elvisangelaccio, dfaure, broulik, davidedmundson
      
      Subscribers: kfm-devel, meven, markg, fazevedo, cfeck, #dolphin
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D8208
      158d12ac
    • Nate Graham's avatar
      Add Duplicate feature · 405dd624
      Nate Graham authored
      Summary: Adds a Duplicate feature to Dolphin, showing up as a menu item in the File menu that appears when one or more items are selected and the directory is writable. Duplicated items receive the names of the original files with " copy" appended before the file extension, if any.
      
      Test Plan:
      
      {F5201386} {F5201393}
      
      Test cases:
      
      - Try to duplicate when nothing is selected: **PASS**: menu item is grayed out
      - Try to duplicate anything on a read-only local volume: **PASS**:  menu item is grayed out
      - Try to duplicate anything on a read-only samba share: **PASS**: menu item is grayed out
      - Duplicate single local file on R/W volume: **PASS**: item is duplicated and named correctly
      - Duplicate multiple local files on R/W volume: **PASS**: 3 items are duplicated, named correctly, and selected
      - Duplicate single local directory on  R/W volume: **PASS**: item is duplicated and named correctly, but a rename operation is not initiated
      - Duplicate multiple local directories on R/W volume: **PASS**: 3 items are duplicated, named correctly, and selected
      - Duplicate single file on R/W samba share: **PASS**: item is duplicated and correctly
      - Duplicate multiple files on R/W samba share: **PASS**: 3 items are duplicated, named correctly, and selected
      - Duplicate single directory on R/W samba share: **PASS**: item is duplicated and named correctly
      - Duplicate multiple directory on R/W samba share: **PASS**: 3 items are duplicated, named correctly, and selected
      - Try to undo a successful duplication: **PASS**: operation is undone
      
      This is my first attempt at a big change like this and I'm sure it's full of issues. I will accept any and all suggestions for improvement. :)
      
      Reviewers: #dolphin, #kde_applications, elvisangelaccio, dfaure, broulik, davidedmundson
      
      Subscribers: kfm-devel, meven, markg, fazevedo, cfeck, #dolphin
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D8208
      405dd624
  18. 11 Jan, 2020 1 commit
  19. 06 Jan, 2020 2 commits
    • Nate Graham's avatar
      Revert "Use newly-upstreamed rename dialog from KIO" · 41105103
      Nate Graham authored
      This reverts commit bae6620f.
      
      Frameworks 5.67 doesn't exist yet; this needs to wait another month.
      41105103
    • Nate Graham's avatar
      Use newly-upstreamed rename dialog from KIO · bae6620f
      Nate Graham authored
      Summary:
      With the rename dialog upstreamed in D17595, we can use it from there.
      
      This will require the KF5 dep to be bumped to 5.67, which should be feasible given that we're at the very beginning of a new Applications cycle.
      
      Depends on D17595
      
      Test Plan:
      1. Dolphin Settings > uncheck "rename inline"
      2. Rename one or more files. Observe that it still works
      
      Tests still pass.
      
      Reviewers: #dolphin, elvisangelaccio, meven
      
      Reviewed By: elvisangelaccio, meven
      
      Subscribers: meven, broulik, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D17597
      bae6620f
  20. 09 Nov, 2019 1 commit
  21. 10 Sep, 2019 1 commit
  22. 03 Aug, 2019 1 commit
    • Piotr Henryk Dabrowski's avatar
      [Dolphin] Hide tooltip instantly on key press · ba92917a
      Piotr Henryk Dabrowski authored
      Summary:
      Instantly hide tooltip shown over an element when a key is pressed.
      
      Currently, when pressing an alphanum key to select a different file,
      the tooltip continues to cover much of the window - often hiding that newly selected file from view.
      
      Reviewers: #dolphin, ngraham, elvisangelaccio
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: broulik, elvisangelaccio, kfm-devel, pdabrowski
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D22512
      ba92917a
  23. 09 Mar, 2019 1 commit
    • David Hallas's avatar
      New tab placed after current tab when middle-clicking · e602e532
      David Hallas authored
      Summary:
      New tabs should be placed after the currently active tab when using
      middle click.
      
      Test Plan:
      Open new tab from the places panel using middle click, verify that the
      Open new tab from the folders panel using middle click, verify that the
      tab is opened after the current tab
      Open new tab by middle clicking on the Back button, verify that the tab
      is opened after the current tab
      Open new tab by middle clicking on the Forward button, verify that the tab
      is opened after the current tab
      
      FEATURE: 403690
      
      Reviewers: #dolphin, ngraham, elvisangelaccio
      
      Reviewed By: #dolphin, ngraham, elvisangelaccio
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D19201
      e602e532
  24. 27 Feb, 2019 1 commit
  25. 08 Feb, 2019 1 commit
  26. 02 Feb, 2019 1 commit
  27. 17 Dec, 2018 1 commit
  28. 08 Nov, 2018 1 commit
    • Shubham  .'s avatar
      Warn user before renaming the file/folder to start with a ' . ' · b08cea86
      Shubham . authored
      Summary: For normal "casual" linux users, renaming the file/folder starting with dot may get irritating, they will be wondering their file is deleted.
      
      Test Plan:
      1. Make new file/folder.
      2. Rename it to .foo
      3. Question dialog appears.
      
      Reviewers: elvisangelaccio, ngraham, pino
      
      Reviewed By: elvisangelaccio, ngraham
      
      Subscribers: cfeck, emateli, elvisangelaccio, pino, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D15980
      b08cea86
  29. 27 Oct, 2018 1 commit
  30. 18 Oct, 2018 1 commit
  31. 07 Oct, 2018 1 commit
  32. 03 Oct, 2018 1 commit
    • Andreas Krutzler's avatar
      Fix that dragging a file can trigger inline rename. · ddfc86ab
      Andreas Krutzler authored
      Summary:
      Inline renaming is aborted as soon as an item is dragged. Previously, ’m_dragging' was used to determine if an item was being dragged. However, inline renaming is triggered after a certain amount of
      time, during which time the user may have stopped dragging items.
      
      BUG: 398375
      FIXED-IN: 18.08.2
      
      Test Plan: When dragging an selected item, inline renaming should never be started, regardless of where you drag it (Places panel, other split-view window, out of the Dolphin window, ...).
      
      Reviewers: wbauer, elvisangelaccio, #dolphin, ngraham
      
      Reviewed By: wbauer, elvisangelaccio, #dolphin, ngraham
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D15904
      ddfc86ab
  33. 20 Aug, 2018 1 commit
    • Elvis Angelaccio's avatar
      Port away from kdelibs4support · 6674c9c3
      Elvis Angelaccio authored
      Summary:
      It was only used as fallback when baloo was not found, but
      `KFileMetaDataWidget` is useless without nepomuk.
      
      The result of this patch is that the information panel and the tooltips
      won't be available from platforms without baloo (instead of being
      available but broken). The baloo dependency remains optional.
      
      Closes T8720
      
      Test Plan:
      Build dolphin with `cmake -DCMAKE_DISABLE_FIND_PACKAGE_KF5Baloo=ON ..` and
      make sure it doesn't show tooltips or the information panel.
      
      Reviewers: #dolphin, broulik, ngraham
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Maniphest Tasks: T8720
      
      Differential Revision: https://phabricator.kde.org/D14814
      6674c9c3
  34. 05 Jun, 2018 1 commit
    • Elvis Angelaccio's avatar
      Fix scrolling to renamed file when using the rename dialog · e308985d
      Elvis Angelaccio authored
      Summary:
      The `RenameDialog::slotResult()` slot is currently never called because
      the dialog is deleted first, due to the usage of the `WA_DeleteOnClose`
      attribute. This breaks the scroll-to-renamed-file feature when the
      inline renaming is disabled.
      
      Instead of deleting the dialog on close, we can use `deleteLater()` when
      we are sure the dialog has actually finished its job, which is when the
      KIO move job emits the `result` signal.
      
      Test Plan:
      - Disable inline renaming
      - Rename a file so that it goes out of the view
      - Check whether the view scrolls to the renamed file.
      
      Reviewers: #dolphin, emateli
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D13304
      e308985d
  35. 04 Mar, 2018 1 commit
  36. 03 Mar, 2018 1 commit
  37. 21 Jan, 2018 1 commit
    • Andreas Krutzler's avatar
      Fix renamed file reclaims focus · bba44ae9
      Andreas Krutzler authored
      Summary:
      After renaming a file and then selecting another file immediately the just selected file stays selected.
      
      BUG: 388555
      
      Test Plan:
      Steps to reproduce:
      $ mkdir /tmp/test
      $ cd /tmp/test
      $ touch a.tmp b.tmp
      $ dolphin /tmp/test
      
      In dolphin:
      * select a.tmp
      * <F2>
      * type aaa
      * select b.tmp immediately
      
      Expected result:
      * a.tmp renamed to aaa.tmp
      * b.tmp stays selected, aaa.tmp stays unselected
      
      Reviewers: ngraham, michaelh, #dolphin, elvisangelaccio
      
      Reviewed By: ngraham, michaelh, #dolphin, elvisangelaccio
      
      Subscribers: emateli, elvisangelaccio, #dolphin
      
      Differential Revision: https://phabricator.kde.org/D9711
      bba44ae9