1. 14 Oct, 2020 1 commit
  2. 25 Aug, 2020 1 commit
  3. 09 Nov, 2019 1 commit
  4. 04 Mar, 2018 1 commit
  5. 03 Mar, 2018 1 commit
  6. 27 Jan, 2018 1 commit
    • Elvis Angelaccio's avatar
      Port away from deprecated QStyle::SH_Widget_Animate · 7caef6d2
      Elvis Angelaccio authored
      Summary:
      Use the new QStyle::SH_Widget_Animation_Duration instead,
      which allows us to not manually hardcode the duration.
      We still use 1 if animations are disabled,
      otherwise the scroll would not work at all.
      
      See also D5883 for some background.
      
      Test Plan: Played with different values in the Animation tab of the Breeze config dialog.
      
      Reviewers: #dolphin, broulik
      
      Reviewed By: broulik
      
      Subscribers: broulik
      
      Differential Revision: https://phabricator.kde.org/D10005
      7caef6d2
  7. 21 Nov, 2017 1 commit
  8. 31 May, 2017 1 commit
    • Elvis Angelaccio's avatar
      Revert "Increase smooth scrolling animation duration from 100 to 300 ms and... · 883b908b
      Elvis Angelaccio authored
      Revert "Increase smooth scrolling animation duration from 100 to 300 ms and set easing curve to InOutQuart"
      
      This reverts commit 58c5eae1.
      
      Reasons against this change:
      
      1. Scroll is now too fast with devices such as touchpads or trackpoints.
      2. Scroll behavior is now inconsistent between Dolphin and other applications
         (e.g. the Plasma file dialog). Breeze's default animation duration is 100 ms.
      3. Many people complained and this feature is currently not configurable. We
         should introduce a QStyle::SH_Widget_Animation_Duration hint that would
         allow us to not hardcode durations in Dolphin (i.e. respect whatever
         duration the users set in their QStyle).
         Proposal in https://codereview.qt-project.org/#/c/195712/
      
      Reviewers: #vdg, #plasma, emmanuelp, davidedmundson
      
      Reviewed By: #plasma, davidedmundson
      
      Differential Revision: https://phabricator.kde.org/D5883
      883b908b
  9. 26 Feb, 2017 1 commit
    • Vishal Rao's avatar
      Increase smooth scrolling animation duration from 100 to 300 ms and set easing curve to InOutQuart · 58c5eae1
      Vishal Rao authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      Summary:
      The current animation duration for smooth scrolling is 100 ms which feels as if there is no smooth scroll animation in the first place. Bumping this up to something like 300 ms seems to make the scrolling actually appear smooth.
      
      Also, based on diff comments the easing curve is set to InOutQuart.
      
      Test Plan: Built this change locally and tried scrolling a folder with many items both single step mouse wheel and also larger steps of the mouse wheel.
      
      Reviewers: elvisangelaccio, emmanuelp
      
      Reviewed By: emmanuelp
      
      Subscribers: htietze, colomar, andreask, emmanuelp, elvisangelaccio
      
      Differential Revision: https://phabricator.kde.org/D4560
      58c5eae1
  10. 16 Jul, 2016 2 commits
  11. 12 Jan, 2016 1 commit
  12. 01 Sep, 2015 1 commit
    • Maxim Mikityanskiy's avatar
      Scrolling fixes for Dolphin · 10944d41
      Maxim Mikityanskiy authored and Emmanuel Pescosta's avatar Emmanuel Pescosta committed
      KItemListSmoothScroller::handleWheelEvent has some issues:
      1. When I scroll file list holding mouse over the list, one mouse wheel tick corresponds
         to 1/4 page interval, but when I hover on QScrollBar, one wheel tick corresponds to
         1 page interval.
      2. In KItemListSmoothScroller::eventFilter we don't return true, so that QScrollBar also
         handles this event, and total scroll interval is m_scrollBar->pageStep() +
         m_scrollBar->singleStep().
      3. When I use touchpad that supports smooth scrolling via XInput2, and I hover it over
         QScrollBar, I can only scroll content if I move my fingers very fast, because
         numSteps = event->delta() / 8 / 15 is just zero unless I move very fast
         (event->delta() in this case is less than 120).
      4. Holding Shift while scrolling has no effect when holding mouse over QScrollBar in
         contrast to scrolling faster when holding mouse over file list.
      
      The patch eliminates all these issues making the behavior of KItemListSmoothScroller the
      same as in KItemListContainer::wheelEvent, adding support for QWheelEvent::pixelDelta()
      and removing usage of deprecated QWheelEvent::delta().
      
      REVIEW: 124670
      FIXED-IN: 15.12.0
      10944d41
  13. 06 Feb, 2015 1 commit
  14. 30 Jan, 2015 1 commit
  15. 27 Oct, 2014 1 commit
  16. 29 Jun, 2014 1 commit
  17. 05 May, 2014 1 commit
    • Alex Richardson's avatar
      dolphin: convert kitemviews/ to qt5 signal slot syntax · bb642c92
      Alex Richardson authored
      This conversion was performed automatically using convert2qt5signalslot.
      The only manual changes required were changing the overloaded signal
      KDirLister::redirection and KDirLister::completed from KUrl to QUrl. All
      other cases were no problem since these signals are not overloaded and a
      static_cast for disambiguation is not necessary.
      
      Code inside HAVE_BALOO is not converted yet, will do that once I can build
      a version with Baloo.
      bb642c92
  18. 22 Jul, 2013 1 commit
    • Frank Reininghaus's avatar
      Do not try to smooth-scroll past the end of the view · 0ad86983
      Frank Reininghaus authored
      KItemListSmoothScroller::scrollTo(qreal position) did not check if
      'position' is a valid value. Even if the view is scrolled to the bottom
      already, it tried to scroll further and activated "smooth scrolling"
      when the mouse wheel is used. Because it never got out of the "smooth
      scrolling" state then, it got confused when changing the directory, and
      restoring the correct scroll offset could fail.
      
      BUG: 322212
      FIXED-IN: 4.11.0
      REVIEW: 111557
      0ad86983
  19. 11 Apr, 2012 1 commit
    • Peter Penz's avatar
      KItemViews: Internal directory restructuration · 6c3d9acb
      Peter Penz authored
      - Move all private headers from the kitemviews-directory into
      the 'private' subdirectory.
      
      - Get rid of DolphinDirLister and just use a directory-lister
        internally in KFileItemModel.
      
      - Minor interface-cleanups for signals
      6c3d9acb
  20. 17 Jan, 2012 2 commits
    • Peter Penz's avatar
      Disable smooth-scrolling dependent on the graphics-effect level · ab61a617
      Peter Penz authored
      If the graphics-effect-level has been set to NoEffects (systemsettings -> Appearance
      -> Style -> Fine Tuning), the smooth scrolling in Dolphin will be disabled.
      
      Additionally the duration for the smooth-scrolling has been decreased from 200 ms
      to 100 ms to reduce the lag.
      
      A wrong calculation of the end-value has been fixed that might trigger
      a wrong position of the content.
      
      BUG: 291740
      BUG: 291607
      FIXED-IN: 4.8.0
      ab61a617
    • Peter Penz's avatar
      Disable smooth-scrolling dependent on the graphics-effect level · 52b6f68b
      Peter Penz authored
      If the graphics-effect-level has been set to NoEffects (systemsettings -> Appearance
      -> Style -> Fine Tuning), the smooth scrolling in Dolphin will be disabled.
      
      Additionally the duration for the smooth-scrolling has been decreased from 200 ms
      to 100 ms to reduce the lag.
      
      A wrong calculation of the end-value has been fixed that might trigger
      a wrong position of the content.
      
      BUG: 291740
      BUG: 291607
      FIXED-IN: 4.8.0
      52b6f68b
  21. 18 Dec, 2011 1 commit
    • Peter Penz's avatar
      Turn off animations if they are globally disabled · 45a42d6a
      Peter Penz authored
      Respect the graphicseffect level in the system settings. This will disable
      all item-animations if the graphicseffect level is "NoEffect".
      
      The smooth scrolling won't be disabled in this case, but the duration has been
      made smaller so that it is not recognized as an animation.
      
      BUG: 289238
      FIXED-IN: 4.8.0
      45a42d6a
  22. 30 Sep, 2011 1 commit