1. 04 May, 2020 2 commits
    • Antonio Prcela's avatar
      Replace the list with the simplified list, instead of concatenate. · ddcca5fb
      Antonio Prcela authored
      Summary: Replace the list m_selectedUrls with a simplified list, instead of concatenating the simplified list to the current one.
      Reviewers: dfaure, meven
      Reviewed By: dfaure
      Subscribers: kfm-devel
      Tags: #dolphin
      Differential Revision: https://phabricator.kde.org/D29399
    • Méven Car's avatar
      [Details mode] Allow to fill the column size of directories with actual size · e6ea3ab4
      Méven Car authored
      Allow to compute the recursive size of directories to fill the details view size column.
      A setting allow to set a limit to the recursive level, allowing the user to have some power over the setting.
      When sorting by size and the feature is on, we get progressive ordering as the directory size are gathered.
      KDirectoryContentsCounter uses a cache internally to keep results so that it can display directory size faster, but counts the dir size of directories each time it is asked to count the size a directory nevertheless and when the size has changed, it is updated.
      KDirectoryContentsCounter uses one worker per instance only, meaning one process per view makes the disk spin.
      FIXED-IN: 20.08
      BUG: 190580
      BUG: 158090
      Test Plan:
      With some recursion allowed:
      Without any recursion allowed (default):
      Reviewers: elvisangelaccio, ngraham, #dolphin
      Reviewed By: elvisangelaccio, ngraham, #dolphin
      Subscribers: feverfew, anthonyfieroni, iasensio, kfm-devel
      Tags: #dolphin
      Differential Revision: https://phabricator.kde.org/D25335
  2. 03 May, 2020 4 commits
    • Alexander Lohnau's avatar
      Dolphin Service Menu Installer: Launch certain scripts in Konsole · d34559d1
      Alexander Lohnau authored
      In general the issue with installers/uninstallers for the dolphin plugin is
      that a lot of the scripts are intended to be run manually in a terminal.
      For instance if a script uses `sudo make install` the user can't type in the password.
      With this patch scripts that are executed without arg variants are
      executed in konsole (if available).
      Test Plan:
      Tests still pass. Try to install the "Jetbrains Dolphin Plugin" tar.gz file from the kde store.
      If you have the required dependencies etc. the konsole window should close.
      If the install script fails (type in wrong admin password a couple of times) you
      should have a shell opened.
      Reviewers: #dolphin, ngraham, nicolasfella, elvisangelaccio, meven
      Reviewed By: #dolphin, elvisangelaccio
      Subscribers: kfm-devel
      Tags: #dolphin
      Differential Revision: https://phabricator.kde.org/D29089
    • Elvis Angelaccio's avatar
    • Alexander Lohnau's avatar
      Dolphin Services: Add search box · e6d4afa9
      Alexander Lohnau authored
      You can now filter the list of installed services.
      This is especially useful if you install additional service menus
      from the kde store, because one instalaton can add a lot of services.
      For instance the ReImage plugin.
      Test Plan:
      Compiles, search for a service menu.
      Only services matching the query will show up.
      Reviewers: ngraham, elvisangelaccio, meven
      Reviewed By: meven
      Subscribers: kfm-devel
      Tags: #dolphin
      Differential Revision: https://phabricator.kde.org/D29375
    • Méven Car's avatar
      filenamesearch:/ define a title for the query · e076d866
      Méven Car authored
      Summary: CCBUG: 420354
      Reviewers: ngraham, elvisangelaccio, #dolphin, #frameworks, iasensio
      Reviewed By: elvisangelaccio, #dolphin, iasensio
      Subscribers: iasensio, kfm-devel
      Tags: #dolphin
      Differential Revision: https://phabricator.kde.org/D29198
  3. 01 May, 2020 1 commit
    • Méven Car's avatar
      Information Panel: show early icons for folders · dcd8c646
      Méven Car authored
      Folders previews can be long to generate.
      This can be noticeable by the user.
      This diff displays folder icons after a 100ms timer.
      BUG: 420340
      FIXED-IN: 20.08
      Test Plan:
      rm -r ~/.cache/thumbnails/
      In dolphin open trash
      Click on download (or any directory with a long to generate preview).
      Reviewers: #dolphin, ngraham
      Reviewed By: #dolphin, ngraham
      Subscribers: kfm-devel
      Tags: #dolphin
      Differential Revision: https://phabricator.kde.org/D29204
  4. 30 Apr, 2020 1 commit
  5. 29 Apr, 2020 1 commit
  6. 27 Apr, 2020 2 commits
    • Yuri Chornoivan's avatar
      Update docs for startup page of configuration · 7f085a5b
      Yuri Chornoivan authored
      Summary: After several resurfaces of GUI the current docs are not up-to-date.
      Test Plan: I used an impression from D11382 to write this. Tested with checkXML5. An updated screenshot is needed.
      Reviewers: #dolphin, ngraham
      Reviewed By: #dolphin, ngraham
      Subscribers: ngraham, kfm-devel, kde-doc-english
      Tags: #dolphin, #documentation
      Differential Revision: https://phabricator.kde.org/D29220
    • René J.V. Bertin's avatar
      prevent a QFileInfo warning · d3813ee6
      René J.V. Bertin authored
      DolphinSearchBox::init() can generate a terminal warning depending on
      the user's search history:
      QFileInfo::absolutePath: Constructed with empty filename
      The warning can seem to appear randomly if you don't use the search
      feature often, because of its dependency on previous search activity.
      Prevent this warning by adding a simple check if the current
      m_searchPath is valid or not. This check has no effect on the value
      returned by DolphinSearchBox::isIndexingEnabled() and is in line with
      the fact that m_searchPath == QUrl() indicates that no search path has
      been set.
      Differential Revision: https://phabricator.kde.org/D29194
  7. 26 Apr, 2020 1 commit
    • Nate Graham's avatar
      Add an option to show tabs from last time when Dolphin starts · caf2fe1c
      Nate Graham authored
      All modern web browsers offer a function to show tabs from last time when a browser starts, and many apps today
      restore their prior state when they're launched. This patch implements thatfunctionality as an option and turns it on by default.
      The settings window is accordingly adjusted to be clear about what applies when:
      FEATURE: 413564
      FIXED-IN: 20.08.0
      Depends on D25106
      Depends on D25219
      Test Plan:
      With the new setting turned off:
      - No behavioral changes at all
      With the new setting turned on:
      - When launched from the GUI or CLI without any URLs, dolphin restores session
      - When rebooting with Dolphin open, it restores session normally after the system comes back (i.e. no behavioral change here)
      - When launched with URLs, Dolphin window is opened showing those URLs instead of restoring session
      - When Dolphin is already running and a new window is opened, that new window shows a single tab with the same URL as was visible in the previously-open Dolphin instance (i.e. no behavioral change here)
      - "Open Containing folder" functionality in other apps works regardless of whether or not Dolphin is running
      Reviewers: #dolphin, #vdg, feverfew, meven, elvisangelaccio, ndavis
      Reviewed By: #dolphin, #vdg, feverfew, elvisangelaccio, ndavis
      Subscribers: davidedmundson, ndavis, intika, feverfew, kfm-devel, ngraham, broulik, #dolphin
      Tags: #dolphin
      Differential Revision: https://phabricator.kde.org/D11382
  8. 25 Apr, 2020 2 commits
  9. 21 Apr, 2020 3 commits
    • Alexander Lohnau's avatar
      Merge branch 'release/20.04' · e78fe032
      Alexander Lohnau authored
    • Alexander Lohnau's avatar
      Dolphin Service Installer: Run uninstall scripts, rename methods · 5bbdf66f
      Alexander Lohnau authored
      Now scripts starting with `uninstall` are being executed.
      Addtionally the `runInstallerScriptOnce` method has been renamed, because it is used to run the install/uninstall scripts.
      Same for `runInstallerScript`.
      Depends on D28801
      Test Plan: Compile, run tests. Try to uninstall a dolphin service which has a uninstall.sh script.
      Reviewers: #dolphin, ngraham, nicolasfella, elvisangelaccio
      Reviewed By: #dolphin, elvisangelaccio
      Subscribers: cfeck, kfm-devel
      Tags: #dolphin
      Differential Revision: https://phabricator.kde.org/D28836
    • Méven Car's avatar
      Information Panel: Make icons as big as previews · cb085066
      Méven Car authored
      Make icons match the preview size.
      It prevents a user that had a wide information panel,
      seeing a size difference between a preview and an icon despite they can look similar (i.e folder preview).
      Test Plan:
      {F8248373, size=full}
      {F8248370, size=full}
      Reviewers: #dolphin, ngraham, elvisangelaccio
      Reviewed By: #dolphin, ngraham, elvisangelaccio
      Subscribers: kfm-devel
      Tags: #dolphin
      Differential Revision: https://phabricator.kde.org/D29002
  10. 20 Apr, 2020 1 commit
    • Nate Graham's avatar
      Use new "Show/Hide Hidden Files" standard shortcut · bb48d4f1
      Nate Graham authored
      Note that we lose the F8 shortcut since the KStandardShortcut added in XXXX can only
      accommodate toew default shortcuts, and I thought Ctrl+H and Alt+. were the more important
      ones. Hopefully that's not too high a price to pay.
      Depends on D28802
      Test Plan:
      - Apply D28802 to kconfig
      - Apply this patch to Dolphin, compile, and launch Dolphin
      - Hit Ctrl+H or Alt+. and see that hidden files are shown or hidden as approproiate
      Reviewers: #dolphin, dfaure, elvisangelaccio
      Reviewed By: #dolphin, elvisangelaccio
      Subscribers: elvisangelaccio, kfm-devel
      Tags: #dolphin
      Differential Revision: https://phabricator.kde.org/D28804
  11. 18 Apr, 2020 3 commits
  12. 17 Apr, 2020 2 commits
    • Alexander Lohnau's avatar
      Merge branch 'release/20.04' · 8fa3e7c1
      Alexander Lohnau authored
    • Alexander Lohnau's avatar
      Dolphin Service Menu installer cleanup · 76f9d9a5
      Alexander Lohnau authored
      This patch contains some smaller formatting/coding style changes
      to avoid unrelated changes in other patches.
      - Use {} instead of QStringList{} consistently
      - Use parehthesese in `UncompressCommand({})` consistently
      - Use `QStringList name = {}` instead of `auto name = QStringList{}`
      - Add one qAsConst, remove qAsConst if value is already const
      Test Plan: Compile, install and run tests
      Reviewers: #dolphin, ngraham, nicolasfella
      Subscribers: kfm-devel
      Tags: #dolphin
      Differential Revision: https://phabricator.kde.org/D28801
  13. 15 Apr, 2020 4 commits
  14. 14 Apr, 2020 6 commits
  15. 13 Apr, 2020 2 commits
  16. 12 Apr, 2020 1 commit
    • Martin Tobias Holmedahl Sandsmark's avatar
      Fix crashing on starting and quitting · 35b4c6d4
      Martin Tobias Holmedahl Sandsmark authored
      QCollator (especially with Qt 5.14 and ICU 65.1) is very unhappy with
      To avoid having to lock and unlock the mutex everywhere (and ensure it
      is unlocked before calling other things that might lock it, etc.), we do
      it as locally as possible. Even if for some reason Qt and ICU make
      QCollator threadsafe in the future locking here should have minimal
      BUG: 419585
      Differential Revision: https://phabricator.kde.org/D28659
  17. 07 Apr, 2020 1 commit
    • Alexander Saoutkin's avatar
      Sync terminal with KIOFuse mount when browing remote directories · 5351db95
      Alexander Saoutkin authored
      Adds the capability to sync the terminal with a KIOFuse mount if the URL is remote.
      Partly based on the existence of another DBus currenly in review:
      Syncing works in both "directions". Changing the URL to a remote URLin the
      DolphinView will change the URL in the terminal to the KIOFuse local path equivalent.
      Conversely changing the URL in the terminal to one that happens to be in a KIOFuse
      mount will change the URL in the DolphinView to the remote URL equivalent.
      Test Plan:
      Manual testing (see video in comments).
      1. Checking that changing directory in DolphinView from remote/local to local doesn't
      cause any regressions.
      2. Checking that changing directory in terminal from local to local (but not in
      KIOFUse mount) doesn't cause any regressions.
      3. Checking that changing directory in DolphinView from remote/local to remote
      correctly changes URL in terminal to KIOFuse equivalent.
      4. Checking that changing directory in terminal from local to KIOFuse path
      correctly changes the URL in the DolphinView to the remote equivalent.
      5. Checking the KIOFuse not being installed doesn't cause any regressions.
      6. Changing directories very quickly does not cause any slowdown.
      Reviewers: #dolphin, fvogt, elvisangelaccio
      Reviewed By: #dolphin, fvogt, elvisangelaccio
      Subscribers: elvisangelaccio, fvogt, kfm-devel, ngraham
      Tags: #dolphin
      Differential Revision: https://phabricator.kde.org/D28290
  18. 06 Apr, 2020 2 commits
  19. 05 Apr, 2020 1 commit