1. 04 May, 2020 1 commit
  2. 18 Apr, 2020 1 commit
  3. 14 Apr, 2020 1 commit
  4. 05 Apr, 2020 1 commit
    • Nate Graham's avatar
      Use same logic for "no extension" case with Duplicate feature · 9b82b08f
      Nate Graham authored
      Summary:
      In the "no extension" case, we weren't separating out the path and the original filename,
      breaking the feature for languages where the word "copy" would be at the beginning of the
      filename, not after it (e.g. "copia de foo" in Spanish, and similar in other romance
      languages). This patch fixes that by separating the original path and filename in the no
      extension case as is done for the other case, which should solve the issue.
      
      BUG: 419070
      FIXED-IN: 20.04.0
      
      Test Plan:
      No changes in English; should fix the issue in Spanish once new translations are done
      (see https://bugs.kde.org/show_bug.cgi?id=419070 for details)
      
      Reviewers: #dolphin, elvisangelaccio, arojas, meven, pino, #localization
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: aacid, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D28227
      9b82b08f
  5. 17 Mar, 2020 1 commit
  6. 15 Mar, 2020 2 commits
    • Nate Graham's avatar
      Add Duplicate feature · 158d12ac
      Nate Graham authored
      Summary: Adds a Duplicate feature to Dolphin, showing up as a menu item in the File menu that appears when one or more items are selected and the directory is writable. Duplicated items receive the names of the original files with " copy" appended before the file extension, if any.
      
      Test Plan:
      
      {F5201386} {F5201393}
      
      Test cases:
      
      - Try to duplicate when nothing is selected: **PASS**: menu item is grayed out
      - Try to duplicate anything on a read-only local volume: **PASS**:  menu item is grayed out
      - Try to duplicate anything on a read-only samba share: **PASS**: menu item is grayed out
      - Duplicate single local file on R/W volume: **PASS**: item is duplicated and named correctly
      - Duplicate multiple local files on R/W volume: **PASS**: 3 items are duplicated, named correctly, and selected
      - Duplicate single local directory on  R/W volume: **PASS**: item is duplicated and named correctly, but a rename operation is not initiated
      - Duplicate multiple local directories on R/W volume: **PASS**: 3 items are duplicated, named correctly, and selected
      - Duplicate single file on R/W samba share: **PASS**: item is duplicated and correctly
      - Duplicate multiple files on R/W samba share: **PASS**: 3 items are duplicated, named correctly, and selected
      - Duplicate single directory on R/W samba share: **PASS**: item is duplicated and named correctly
      - Duplicate multiple directory on R/W samba share: **PASS**: 3 items are duplicated, named correctly, and selected
      - Try to undo a successful duplication: **PASS**: operation is undone
      
      This is my first attempt at a big change like this and I'm sure it's full of issues. I will accept any and all suggestions for improvement. :)
      
      Reviewers: #dolphin, #kde_applications, elvisangelaccio, dfaure, broulik, davidedmundson
      
      Subscribers: kfm-devel, meven, markg, fazevedo, cfeck, #dolphin
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D8208
      158d12ac
    • Nate Graham's avatar
      Add Duplicate feature · 405dd624
      Nate Graham authored
      Summary: Adds a Duplicate feature to Dolphin, showing up as a menu item in the File menu that appears when one or more items are selected and the directory is writable. Duplicated items receive the names of the original files with " copy" appended before the file extension, if any.
      
      Test Plan:
      
      {F5201386} {F5201393}
      
      Test cases:
      
      - Try to duplicate when nothing is selected: **PASS**: menu item is grayed out
      - Try to duplicate anything on a read-only local volume: **PASS**:  menu item is grayed out
      - Try to duplicate anything on a read-only samba share: **PASS**: menu item is grayed out
      - Duplicate single local file on R/W volume: **PASS**: item is duplicated and named correctly
      - Duplicate multiple local files on R/W volume: **PASS**: 3 items are duplicated, named correctly, and selected
      - Duplicate single local directory on  R/W volume: **PASS**: item is duplicated and named correctly, but a rename operation is not initiated
      - Duplicate multiple local directories on R/W volume: **PASS**: 3 items are duplicated, named correctly, and selected
      - Duplicate single file on R/W samba share: **PASS**: item is duplicated and correctly
      - Duplicate multiple files on R/W samba share: **PASS**: 3 items are duplicated, named correctly, and selected
      - Duplicate single directory on R/W samba share: **PASS**: item is duplicated and named correctly
      - Duplicate multiple directory on R/W samba share: **PASS**: 3 items are duplicated, named correctly, and selected
      - Try to undo a successful duplication: **PASS**: operation is undone
      
      This is my first attempt at a big change like this and I'm sure it's full of issues. I will accept any and all suggestions for improvement. :)
      
      Reviewers: #dolphin, #kde_applications, elvisangelaccio, dfaure, broulik, davidedmundson
      
      Subscribers: kfm-devel, meven, markg, fazevedo, cfeck, #dolphin
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D8208
      405dd624
  7. 11 Jan, 2020 1 commit
  8. 06 Jan, 2020 2 commits
    • Nate Graham's avatar
      Revert "Use newly-upstreamed rename dialog from KIO" · 41105103
      Nate Graham authored
      This reverts commit bae6620f.
      
      Frameworks 5.67 doesn't exist yet; this needs to wait another month.
      41105103
    • Nate Graham's avatar
      Use newly-upstreamed rename dialog from KIO · bae6620f
      Nate Graham authored
      Summary:
      With the rename dialog upstreamed in D17595, we can use it from there.
      
      This will require the KF5 dep to be bumped to 5.67, which should be feasible given that we're at the very beginning of a new Applications cycle.
      
      Depends on D17595
      
      Test Plan:
      1. Dolphin Settings > uncheck "rename inline"
      2. Rename one or more files. Observe that it still works
      
      Tests still pass.
      
      Reviewers: #dolphin, elvisangelaccio, meven
      
      Reviewed By: elvisangelaccio, meven
      
      Subscribers: meven, broulik, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D17597
      bae6620f
  9. 09 Nov, 2019 1 commit
  10. 10 Sep, 2019 1 commit
  11. 03 Aug, 2019 1 commit
    • Piotr Henryk Dabrowski's avatar
      [Dolphin] Hide tooltip instantly on key press · ba92917a
      Piotr Henryk Dabrowski authored
      Summary:
      Instantly hide tooltip shown over an element when a key is pressed.
      
      Currently, when pressing an alphanum key to select a different file,
      the tooltip continues to cover much of the window - often hiding that newly selected file from view.
      
      Reviewers: #dolphin, ngraham, elvisangelaccio
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: broulik, elvisangelaccio, kfm-devel, pdabrowski
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D22512
      ba92917a
  12. 09 Mar, 2019 1 commit
    • David Hallas's avatar
      New tab placed after current tab when middle-clicking · e602e532
      David Hallas authored
      Summary:
      New tabs should be placed after the currently active tab when using
      middle click.
      
      Test Plan:
      Open new tab from the places panel using middle click, verify that the
      Open new tab from the folders panel using middle click, verify that the
      tab is opened after the current tab
      Open new tab by middle clicking on the Back button, verify that the tab
      is opened after the current tab
      Open new tab by middle clicking on the Forward button, verify that the tab
      is opened after the current tab
      
      FEATURE: 403690
      
      Reviewers: #dolphin, ngraham, elvisangelaccio
      
      Reviewed By: #dolphin, ngraham, elvisangelaccio
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D19201
      e602e532
  13. 27 Feb, 2019 1 commit
  14. 08 Feb, 2019 1 commit
  15. 02 Feb, 2019 1 commit
  16. 17 Dec, 2018 1 commit
  17. 08 Nov, 2018 1 commit
    • Shubham  .'s avatar
      Warn user before renaming the file/folder to start with a ' . ' · b08cea86
      Shubham . authored
      Summary: For normal "casual" linux users, renaming the file/folder starting with dot may get irritating, they will be wondering their file is deleted.
      
      Test Plan:
      1. Make new file/folder.
      2. Rename it to .foo
      3. Question dialog appears.
      
      Reviewers: elvisangelaccio, ngraham, pino
      
      Reviewed By: elvisangelaccio, ngraham
      
      Subscribers: cfeck, emateli, elvisangelaccio, pino, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D15980
      b08cea86
  18. 27 Oct, 2018 1 commit
  19. 18 Oct, 2018 1 commit
  20. 07 Oct, 2018 1 commit
  21. 03 Oct, 2018 1 commit
    • Andreas Krutzler's avatar
      Fix that dragging a file can trigger inline rename. · ddfc86ab
      Andreas Krutzler authored
      Summary:
      Inline renaming is aborted as soon as an item is dragged. Previously, ’m_dragging' was used to determine if an item was being dragged. However, inline renaming is triggered after a certain amount of
      time, during which time the user may have stopped dragging items.
      
      BUG: 398375
      FIXED-IN: 18.08.2
      
      Test Plan: When dragging an selected item, inline renaming should never be started, regardless of where you drag it (Places panel, other split-view window, out of the Dolphin window, ...).
      
      Reviewers: wbauer, elvisangelaccio, #dolphin, ngraham
      
      Reviewed By: wbauer, elvisangelaccio, #dolphin, ngraham
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D15904
      ddfc86ab
  22. 20 Aug, 2018 1 commit
    • Elvis Angelaccio's avatar
      Port away from kdelibs4support · 6674c9c3
      Elvis Angelaccio authored
      Summary:
      It was only used as fallback when baloo was not found, but
      `KFileMetaDataWidget` is useless without nepomuk.
      
      The result of this patch is that the information panel and the tooltips
      won't be available from platforms without baloo (instead of being
      available but broken). The baloo dependency remains optional.
      
      Closes T8720
      
      Test Plan:
      Build dolphin with `cmake -DCMAKE_DISABLE_FIND_PACKAGE_KF5Baloo=ON ..` and
      make sure it doesn't show tooltips or the information panel.
      
      Reviewers: #dolphin, broulik, ngraham
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Maniphest Tasks: T8720
      
      Differential Revision: https://phabricator.kde.org/D14814
      6674c9c3
  23. 05 Jun, 2018 1 commit
    • Elvis Angelaccio's avatar
      Fix scrolling to renamed file when using the rename dialog · e308985d
      Elvis Angelaccio authored
      Summary:
      The `RenameDialog::slotResult()` slot is currently never called because
      the dialog is deleted first, due to the usage of the `WA_DeleteOnClose`
      attribute. This breaks the scroll-to-renamed-file feature when the
      inline renaming is disabled.
      
      Instead of deleting the dialog on close, we can use `deleteLater()` when
      we are sure the dialog has actually finished its job, which is when the
      KIO move job emits the `result` signal.
      
      Test Plan:
      - Disable inline renaming
      - Rename a file so that it goes out of the view
      - Check whether the view scrolls to the renamed file.
      
      Reviewers: #dolphin, emateli
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D13304
      e308985d
  24. 04 Mar, 2018 1 commit
  25. 03 Mar, 2018 1 commit
  26. 21 Jan, 2018 1 commit
    • Andreas Krutzler's avatar
      Fix renamed file reclaims focus · bba44ae9
      Andreas Krutzler authored
      Summary:
      After renaming a file and then selecting another file immediately the just selected file stays selected.
      
      BUG: 388555
      
      Test Plan:
      Steps to reproduce:
      $ mkdir /tmp/test
      $ cd /tmp/test
      $ touch a.tmp b.tmp
      $ dolphin /tmp/test
      
      In dolphin:
      * select a.tmp
      * <F2>
      * type aaa
      * select b.tmp immediately
      
      Expected result:
      * a.tmp renamed to aaa.tmp
      * b.tmp stays selected, aaa.tmp stays unselected
      
      Reviewers: ngraham, michaelh, #dolphin, elvisangelaccio
      
      Reviewed By: ngraham, michaelh, #dolphin, elvisangelaccio
      
      Subscribers: emateli, elvisangelaccio, #dolphin
      
      Differential Revision: https://phabricator.kde.org/D9711
      bba44ae9
  27. 21 Nov, 2017 1 commit
  28. 11 Nov, 2017 1 commit
  29. 27 Oct, 2017 1 commit
    • Andreas Krutzler's avatar
      Two clicks on file/folder to rename · 54542830
      Andreas Krutzler authored
      Summary:
      Make renaming of files/folders faster by clicking a second time on the items text to start renaming.
      BUG: 205157
      
      Test Plan:
      This feature works as follows:
      
      1. select an item by single-click, or one is already selected
      2. wait the "double-click-interval"
      3. click on the items text
      4. none of the cancellations (see below) happens within the double-click-interval
      5. inline-renaming starts
      
      Cancellations:
      * open any file/folder
      * select different item(s)
      * start dragging items
      * Dolphin loses focus
      
      This feature is just enabled while "Double-click to open files and folders" in system-settings and "Rename inline" in Dolphin are enabled.
      
      Reviewers: #dolphin, #kde_applications, elvisangelaccio, emmanuelp, ngraham, markg, rkflx
      
      Reviewed By: #dolphin, #kde_applications, elvisangelaccio, ngraham, rkflx
      
      Subscribers: rkflx, markg, funkybomber, sars, elvisangelaccio, ngraham
      
      Differential Revision: https://phabricator.kde.org/D7647
      54542830
  30. 17 Sep, 2017 1 commit
    • Emirald Mateli's avatar
      Keep renamed file(s) in view · 478f404b
      Emirald Mateli authored
      When renaming a file, if its new name causes it to scroll out of view,
      Dolphin will not scroll to the location of the new file.
      This patch aims to address that. This affects all view modes.
      
      CCBUG: 354330
      
      Test Plan:
      1. Have many files in a directory (or several files, just zoom in a lot)
      2. Rename a file so that it will move out of view
      
      Differential Revision: https://phabricator.kde.org/D6312
      478f404b
  31. 27 Jul, 2017 1 commit
    • Elvis Angelaccio's avatar
      Fix drop menu position with urlnavigator drops · c3de8676
      Elvis Angelaccio authored
      Commit 1e251d2f6a in kio broke drop menus when dropping on the URL
      navigator (menus show up in the DolphinView rather than the URL bar).
      This happens because in DolphinView::dropUrls() we set `this` as the
      widget passed to KJobWidgets::setWindow() (in DragAndDropHelper::dropUrls()).
      
      We need to replace `this` with the actual widget that received the QDropEvent
      and that can mapToGlobal() the relative pos of the drop event.
      Unfortunately this widget is not KUrlNavigator itself, but one of its
      KUrlNavigatorButton children (private class, not exported). So
      unfortunately we need a new API in KIO that exposes this child widget.
      
      Differential Revision: https://phabricator.kde.org/D6684
      c3de8676
  32. 13 Jul, 2017 1 commit
  33. 08 May, 2017 1 commit
    • Elvis Angelaccio's avatar
      Don't ignore tag clicks in the tooltips · 73f885f9
      Elvis Angelaccio authored
      Summary:
      Now that we can use the metadata widgets in the tooltips, we can also
      open the tags:// url if the user clicks some tag in a tooltip.
      
      The behavior is now consistent with the metadata widget in the information panel.
      
      Test Plan: Click a tag when the metadata tooltip shows up.
      
      Reviewers: emmanuelp
      
      Subscribers: #konqueror, #dolphin
      
      Differential Revision: https://phabricator.kde.org/D5658
      73f885f9
  34. 18 Feb, 2017 4 commits
  35. 06 Feb, 2017 1 commit