1. 03 May, 2020 1 commit
  2. 27 Apr, 2020 1 commit
    • René J.V. Bertin's avatar
      prevent a QFileInfo warning · d3813ee6
      René J.V. Bertin authored
      DolphinSearchBox::init() can generate a terminal warning depending on
      the user's search history:
      
      QFileInfo::absolutePath: Constructed with empty filename
      
      The warning can seem to appear randomly if you don't use the search
      feature often, because of its dependency on previous search activity.
      
      Prevent this warning by adding a simple check if the current
      m_searchPath is valid or not. This check has no effect on the value
      returned by DolphinSearchBox::isIndexingEnabled() and is in line with
      the fact that m_searchPath == QUrl() indicates that no search path has
      been set.
      
      Differential Revision: https://phabricator.kde.org/D29194
      d3813ee6
  3. 18 Apr, 2020 1 commit
    • Shlomi Fish's avatar
      Move from the searchbox to the results with the down arrow key · 196f4553
      Shlomi Fish authored
      Summary:
      Move from the searchbox to the search results listbox/view using the
      down arrow key in addition to the existing methods using the tab key,
      return key, or the mouse.
      
      Test Plan:
      use ctrl+f to search in a directory tree, press down arrow key
      to go to the results
      
      Reviewers: ngraham, #dolphin
      
      Reviewed By: ngraham, #dolphin
      
      Subscribers: meven, elvisangelaccio, ngraham, iasensio, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D26362
      196f4553
  4. 29 Dec, 2019 1 commit
    • Ismael Asensio's avatar
      Clean-up DolphinFacetsWidget · c331d706
      Ismael Asensio authored
      Summary:
      Small refactor patch to clean-up some logic on setter and getter:
      - Search terms are previously splitted and set separately, so no need
        for extra splitting and `foreach` loop
      - Return search terms on a `QStringList` rather than join first
      
      Depends on: D26029
      
      Test Plan: No behavior changes
      
      Reviewers: #dolphin, elvisangelaccio
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D26150
      c331d706
  5. 26 Dec, 2019 1 commit
  6. 21 Dec, 2019 1 commit
    • Ismael Asensio's avatar
      fix(search): Correctly parse filename and/or content search · 616d4e6b
      Ismael Asensio authored
      Summary:
      Currently, the search url parsing does not detect if the search is based on Content or Filename, and it just keeps the last selection which can be inconsistent with the actual search.
      
      This patch add such detection, and since an advanced user can combine filename and content search (using the keyword `filename:`), now the parsing detects both items and handles the four possible cases:
      
      | Content | Filename | Search text | Search type |
      |---|---|------------------------|------------------|
      | T | T | abc filename:"xyz"  | Content          |
      | T | F | abc                           | Content          |
      | F | T | xyz                           | Filename         |
      | F | F |                                  | do not set       |
      
      Depends on: D25260
      
      Test Plan: `bin/dolphinquerytest`: Added new test cases for searches with content text and/or filename
      
      Reviewers: elvisangelaccio, bruns, #dolphin
      
      Reviewed By: elvisangelaccio, #dolphin
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D25416
      616d4e6b
  7. 09 Dec, 2019 1 commit
  8. 13 Nov, 2019 1 commit
    • Ismael Asensio's avatar
      refactor(search): De-couple baloo URL parsing logic from UI · 8d92c8be
      Ismael Asensio authored
      Summary:
      Extracts the logic that parses `baloosearch:` urls into a new model class. The parser logic itself is kept as is.
      The search box UI is later updated using the model fields.
      
      This refactor has been proposed by @bruns in the review of D24422, as it largely simplifies the unit tests and further expansion/improvements.
      
      Test Plan:
      No behavior changes.
      Test case is added in the follow-up revision: D25258
      
      Reviewers: #dolphin, elvisangelaccio, bruns
      
      Reviewed By: #dolphin, elvisangelaccio, bruns
      
      Subscribers: ngraham, bruns, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D25257
      8d92c8be
  9. 09 Nov, 2019 1 commit
  10. 07 Nov, 2019 1 commit
    • Ismael Asensio's avatar
      Make the search box more compact · 7949aee2
      Ismael Asensio authored
      Summary:
      Reduce the spacing between widgets and remove the content margins on the extended search options to have a more compact and space-saving layout.
      Currently, some widgets are not even aligned.
      This will be even more important if we remove the toggle button for 'More Options'.
      
      CCBUG: 386754
      
      Test Plan:
      BEFORE: {F7681182}
      AFTER: {F7681184}
      
      Reviewers: elvisangelaccio, ngraham, #dolphin, #vdg
      
      Reviewed By: elvisangelaccio, ngraham, #dolphin, #vdg
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D25028
      7949aee2
  11. 03 Nov, 2019 1 commit
    • Ismael Asensio's avatar
      Get rid of search "More Options" toggle button · 54bd267e
      Ismael Asensio authored
      Summary:
      With the new compact search filters (type/date/rating) it makes sense to show these options whenever available, and save some horizontal space on the main bar (specially for verbose languages).
      These options will be hidden nevertheless if the search is non-indexed or Baloo is disabled.
      For some nicer aesthetics D25029 should be also applied.
      
      CCBUG: 386754
      
      Test Plan:
      Current: {F7681182}
      After: {F7687380}
      Along with D25029: {F7687385}
      
      Reviewers: elvisangelaccio, ngraham, #dolphin, #vdg
      
      Reviewed By: ngraham, #vdg
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D25057
      54bd267e
  12. 20 Oct, 2019 2 commits
    • Ismael Asensio's avatar
      [dolphin/search] Reset search options when needed · c540b4ee
      Ismael Asensio authored
      Summary:
      Adds a method to reset the options in `facetsWidget` in two cases: when disabled and before parsing a new search URL.
      Otherwise, controls for a parameter (ex. `rating`) which are not found in the new URL would stay on the old positions, instead of the default "any".
      See D24422
      
      Test Plan: Controls on `facetsWidget` go back to the default in such two cases.
      
      Reviewers: #dolphin, elvisangelaccio, meven, ngraham
      
      Reviewed By: ngraham
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D24450
      c540b4ee
    • Ismael Asensio's avatar
      [dolphin/search] Fix search behavior when selecting "Your Files" · 167d5184
      Ismael Asensio authored
      Summary:
      Fix the search box forgetting the location where the user was previously searching into.
      
      To do a search on "All Files" instead of setting the `m_searchPath` to `$HOME`, it checks the button state, so the "From Here" location is not lost.
      As an added benefit, selecting "Your Files" when in a non-indexed folder will use the baloo search instead of a fully non-indexed search from $HOME.
      
      This issue is the last remaining one of the series started with D24422, with the purpose of fixing the searchbox parsing and update.
      
      Test Plan:
      - Toggle between "From Here/Your Files" and navigate between locations
      - The search box remembers the location and keeps a coherent state
      
      {F7575402}
      
      Reviewers: #dolphin, elvisangelaccio
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D24577
      167d5184
  13. 13 Oct, 2019 1 commit
    • Ismael Asensio's avatar
      Hide search extra options when not available · c144701c
      Ismael Asensio authored
      Summary:
      Hide the search extra options when they are not available, because the current location is not indexed or Baloo is not enabled.
      The button is disabled and shows a tooltip to provide feedback of why it's not available.
      Depends on D24478
      
      {F7531893}
      
      CCBUG: 396898
      FEATURE: 318580
      FEATURE: 408680
      FIXED-IN: 19.11.80
      
      Test Plan:
       - `Ctrl-F` on a non-indexed location
       - `balooctl disable` and `Ctrl-F` on an indexed location
      
      On both cases the extra options are not shown, the button is disabled and the reason is shown in the tooltip
      The user selection is remembered between indexed locations.
      
      Reviewers: #dolphin, elvisangelaccio, meven, ngraham
      
      Reviewed By: meven
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D24446
      c144701c
  14. 08 Oct, 2019 1 commit
  15. 07 Oct, 2019 1 commit
    • Ismael Asensio's avatar
      [dolphin/search] Avoid unnecesary reloads on setSearchPath · e3035734
      Ismael Asensio authored
      Summary:
      Check in `setSearchPath()` if the `url` passed is already the `searchPath`
      This was causing an effect where reloading the same search URL results on buttons `From Here/Everywhere` toggling.
      See D24422
      
      Test Plan:
      On your home folder press `Ctrl-F` several times
      Buttons `From Here/Everywhere` should now not toggle each time
      
      Reviewers: #dolphin, elvisangelaccio, meven, ngraham
      
      Reviewed By: #dolphin, ngraham
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D24449
      e3035734
  16. 08 Sep, 2019 1 commit
  17. 22 Apr, 2019 1 commit
  18. 09 Apr, 2019 1 commit
    • Stefan Brüns's avatar
      Make buttons in seach bar nicer (icon, tooltip, autoselect) · 9ce757b3
      Stefan Brüns authored
      Summary:
      The "Everywhere" button actually selects the home directory, so use
      an appropriate label ("Your files") and add a "user-home" icon.
      
      Pre-select the right button when entering search, depending on the
      location where the "Find ..." action was triggered.
      
      Add tooltips for both buttons, stating where to look for files. Most
      importantly, this includes the full path for "From here".
      
      Canonicalize the path correctly (always strip trailing slash), otherwise
      QUrl::fileName() will be an empty string, resulting in "From Here (/)"
      
      Do not hide the buttons in case the url is non-local, as it is confusing:
      1. The state depends on the previous search. When the user hits "Find"
          when browsing e.g an SMB share, the search was probably in the home dir.
      2. The current search location was hidden
      3. The user may want to do a local search, give the option to do so.
      
      Reviewers: #dolphin, ngraham, elvisangelaccio
      
      Reviewed By: #dolphin, ngraham, elvisangelaccio
      
      Subscribers: loh.tar, meven, elvisangelaccio, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D20357
      9ce757b3
  19. 27 Feb, 2019 1 commit
  20. 13 Jun, 2018 1 commit
    • Elvis Angelaccio's avatar
      Fix loop of FocusIn events · 9616edbb
      Elvis Angelaccio authored
      Summary:
      Commit 43da84ee introduced the risk of entering an endless loop of
      `FocusIn`/`FocusOut` events sent to two DolphinSearchBox instances when
      opening a second tab (see D11871).
      
      This happens because we deactivate the first tab when we open a new one, but
      since the `setActive(true)` is delayed with a QTimer, both the old tab
      and the new one become active and receive their own `FocusIn` event
      (which starts the loop of focus in/out events).
      
      To prevent this issue, we schedule the searchbox activation only if the
      searchbox is not already active.
      
      Test Plan:
      - Search something in dolphin
      - Open a new tab after the search ends
      - Check that dolphin does not eat the CPU
      
      Reviewers: #dolphin, anthonyfieroni
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D13152
      9616edbb
  21. 04 Mar, 2018 1 commit
  22. 03 Mar, 2018 1 commit
  23. 14 Dec, 2017 1 commit
  24. 21 Nov, 2017 1 commit
  25. 01 Nov, 2017 1 commit
    • Nathaniel Graham's avatar
      Make Saved Search feature discoverable · 64cfc43b
      Nathaniel Graham authored
      Summary:
      FEATURE: 269332
      
      Make Dolphin's Saved Search feature discoverable by adding a button inside the search field. The button only becomes enabled when there is a valid search term. When pushed, it saves the search to the Places panel, providing a visible-by-default way to do this to complement the existing implementation that is only visible in the context menu.
      
      Also harmonized the label text so that it's consistent no matter how you create a saved search (button or context menu)
      
      Test Plan:
      Tested in KDE Neon. Works great:
      {F5449508}
      
      Reviewers: #dolphin, broulik, dfaure, markg, emateli, elvisangelaccio
      
      Reviewed By: #dolphin, markg, emateli, elvisangelaccio
      
      Subscribers: anthonyfieroni, markg, emateli, elvisangelaccio, cfeck, #dolphin
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D8454
      64cfc43b
  26. 22 May, 2017 1 commit
  27. 20 Jan, 2017 1 commit
    • Gregor Mi's avatar
      DolphinSearchBox: Add a "More search tools..." menu button · 728e6712
      Gregor Mi authored
      Additionally, moves the "More/Fewer options" button from right to left to reduce the mouse travelling distance when the dolphin is maximized on a large screen (see screenshots)
      
      The current location url will be passed to the search tool to set the initial search root directory.
      
      REVIEW: 123883
      728e6712
  28. 01 Jan, 2017 1 commit
  29. 16 Mar, 2016 1 commit
  30. 25 Nov, 2015 1 commit
  31. 11 May, 2015 2 commits
  32. 29 Apr, 2015 1 commit
  33. 26 Feb, 2015 3 commits
  34. 10 Nov, 2014 1 commit
  35. 21 Oct, 2014 1 commit
  36. 18 Oct, 2014 1 commit