1. 17 Nov, 2018 3 commits
    • Thomas Surrel's avatar
      Do not disconnect all StorageAccess signals when unmounting · e710a643
      Thomas Surrel authored
      The problem is caused by the fact device interfaces returned by
      Solid (e.g. item->device().as<Solid::StorageAccess>()) are not
      full objects, but only references/pointers to a per-device-object,
      i.e. requesting the same interface for a device will return the same
      address every time.
      If the interface is used used in multiple places, calling disconnect
      on the interface address disconnects the signals for all users.
      BUG: 400992
      Test Plan:
      In Dolphin, mount a local partition (e.g. a Windows partition)
      then unmount it (right click on it in Places, then Unmount).
      Try to access it again by clicking on it in Places, we should
      get access to it correctly.
      Reviewers: #dolphin, #frameworks, bruns, elvisangelaccio
      Reviewed By: #dolphin, elvisangelaccio
      Subscribers: elvisangelaccio, kfm-devel
      Tags: #dolphin
      Differential Revision: https://phabricator.kde.org/D16857
    • Chris Rizzitello's avatar
      Improve Ux for the places panel's hidden items · c900f7d2
      Chris Rizzitello authored
      BUG: 400860
      FIXED-IN: 18.12.0
      Clean up the context menu for the places panel.
       - Change Text "Show All Entries" -> "Show Hidden Places"
       - Use State dependent icon (like hidden files)
       - Disable instead of hide if not places are hidden.
       - Toggle to unchecked if last item of group is unhidden.
      Create a copy of this "Show Hidden Places" entry in the main dolphin menu View->Places.
      Test Plan:
      With Hidden Places
      Context Menu:
      Without Hidden Places.
      Reviewers: #dolphin, #vdg, elvisangelaccio, ngraham
      Reviewed By: #dolphin, #vdg, elvisangelaccio, ngraham
      Subscribers: cfeck, elvisangelaccio, veqz, davidc, ngraham, kfm-devel
      Tags: #dolphin
      Maniphest Tasks: T8349
      Differential Revision: https://phabricator.kde.org/D16767
    • Harald Sitter's avatar
      move kcrash link to dolphin app (which is the effective user) · a4cddf75
      Harald Sitter authored
      to successfully use kcrash when linking with as-needed (which is a default
      flag on many linux distros) one also needs to call KCrash::initialize.
      this call happens in the app's main.cpp. as such the kcrash link target
      on the dolphinprivate library doesn't do anything for dolphinprivate but
      only kicks into action for dolphin itself.
      to avoid confusion and make it clear that kcrash is only initialized in the
      application scope the KF5::Crash link target is now on the application
      target, not the library target.
      (this makes no difference in the output, kcrash was still correctly linked
       via dolphinprivate; but only for kdeinit_dolphin, dolphinprivate did
       not get linked to it with as-needed)
      Test Plan: builds; links as expected
      Reviewers: elvisangelaccio, #dolphin
      Reviewed By: elvisangelaccio, #dolphin
      Subscribers: kfm-devel
      Tags: #dolphin
      Differential Revision: https://phabricator.kde.org/D16896
  2. 16 Nov, 2018 1 commit
  3. 11 Nov, 2018 1 commit
  4. 09 Nov, 2018 1 commit
  5. 08 Nov, 2018 1 commit
    • Shubham  .'s avatar
      Warn user before renaming the file/folder to start with a ' . ' · b08cea86
      Shubham . authored
      Summary: For normal "casual" linux users, renaming the file/folder starting with dot may get irritating, they will be wondering their file is deleted.
      Test Plan:
      1. Make new file/folder.
      2. Rename it to .foo
      3. Question dialog appears.
      Reviewers: elvisangelaccio, ngraham, pino
      Reviewed By: elvisangelaccio, ngraham
      Subscribers: cfeck, emateli, elvisangelaccio, pino, kfm-devel
      Tags: #dolphin
      Differential Revision: https://phabricator.kde.org/D15980
  6. 07 Nov, 2018 1 commit
  7. 05 Nov, 2018 1 commit
  8. 04 Nov, 2018 2 commits
  9. 02 Nov, 2018 1 commit
  10. 01 Nov, 2018 1 commit
  11. 28 Oct, 2018 1 commit
  12. 27 Oct, 2018 5 commits
  13. 25 Oct, 2018 2 commits
  14. 24 Oct, 2018 3 commits
  15. 18 Oct, 2018 2 commits
  16. 14 Oct, 2018 1 commit
  17. 13 Oct, 2018 6 commits
  18. 11 Oct, 2018 1 commit
    • Thomas Surrel's avatar
      Disable unmount option for / or /home · ddd74667
      Thomas Surrel authored
      This removes the 'Unmount' context menu in the Places panel for discs
      corresponding to / and /home.
      It does not make much sense to offer an option that will always fail.
      BUG: 399659
      Reviewers: #dolphin, #vdg, elvisangelaccio
      Reviewed By: #dolphin, elvisangelaccio
      Subscribers: sefaeyeoglu, elvisangelaccio, ngraham, broulik, bruns, kfm-devel
      Tags: #dolphin
      Differential Revision: https://phabricator.kde.org/D15989
  19. 10 Oct, 2018 4 commits
  20. 09 Oct, 2018 2 commits