1. 04 Jul, 2021 1 commit
  2. 17 Apr, 2021 1 commit
  3. 08 Feb, 2021 1 commit
    • Felix Ernst's avatar
      Avoid KJob::exec() in DolphinView · a825e1bd
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      This commit replaces an error-prone usage of KIO::StatJob::exec() in
      DolphinView with the recommended KIO::StatJob::start().
      
      The containing method DolphinView::statusBarText() is changed to be a
      method without return value: requestStatusBarText()
      The new status bar text is instead returned through a new
      setStatusBarText() signal that will be emitted asynchronously if
      necessary.
      
      The calling code that deals with status bar text is refactored to
      correctly work despite the new asynchronicity. The helper method
      calculateItemCount() is moved into requestStatusBarText() and some
      other code from requestStatusBarText() is moved into a new helper
      method emitStatusBarText().
      
      The documentation of KIO::KJob::exec() explains why it should be
      avoided. A reproducible crash is the reason for this commit.
      a825e1bd
  4. 16 Dec, 2020 1 commit
  5. 15 Dec, 2020 1 commit
  6. 24 Nov, 2020 1 commit
  7. 21 Nov, 2020 1 commit
    • Felix Ernst's avatar
      Select last visited folder when going up/back · 76070081
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      This commit fixes a regression introduced by
      ad5d3367. A lot of connections were
      changed there and at least one of them was wrong. The connections can
      be separated into GUI connections and internal ones. This commit makes
      it so the GUI stuff is connected to m_urlNavigatorConnected and
      everything else to m_urlNavigator.
      
      BUG: 429097
      76070081
  8. 09 Nov, 2020 6 commits
    • Felix Ernst's avatar
      Adress the third round of Angelaccio's review comments · 63f4981f
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      Additionally remove some redundant code concerning UrlNavigator visuals.
      63f4981f
    • Felix Ernst's avatar
      Adress most of the second round of Angelaccio's review comments · 2d4d2ce9
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      This commit applies most suggestions which were made on the MR.
      Most notably the DolphinUrlNavigator class is split up which leads to
      the creation of a DolphinUrlNavigatorsController class.
      
      Additionally some minor coding style and const correctness changes are
      included.
      
      The error value of cached integers is changed from -1 to INT_MIN
      because situations could come up in which -1 would be a valid value.
      2d4d2ce9
    • Felix Ernst's avatar
      Make UrlNavigators in the toolbar the only option · 37327c9b
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      The UrlNavigators will be automatically added to the toolbar. The Sort By
      action is removed from the default toolbar to make space.
      
      Remove all options to have UrlNavigators outside the toolbar and remove
      those code paths.
      
      Make it so the new NavigatorsWidgetAction contains two UrlNavigators when
      in split view mode. Spacing was also added to align these UrlNavigators
      with the ViewContainers when enough space is available.
      
      Force the toolbar to be either at the top or bottom of the window.
      
      Set a sane sizeHint for DolphinUrlNavigator. It would be better to do this
      in KUrlNavigator in the future.
      
      This commit also contains a changes which should be moved to a separate
      merge requests before this gets merged:
      - Add an expansion animation when split view is enabled by the user
      37327c9b
    • Felix Ernst's avatar
      Add the UrlNavigator to the toolbar automatically if needed · 6151a7ae
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      This commit adds the DolphinUrlNavigatorWidgetAction::addToToolbarAndSave()
      method which changes the users toolbar configuration to contain an
      Url Navigator. This way the user doesn't need to do anything manually.
      
      Aside from that a bunch of minor fixes like renaming and reordering
      6151a7ae
    • Felix Ernst's avatar
      Adress the first round of Angelaccio's review comments · b6fc58c3
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      - Split the viewContainers(bool includeInActive) into two methods
          without parameters
      - Prevent users from accidently hiding all Url Navigators by
          preventing the dangerous action and then displaying a helpful
          message instead
      Unrelated to review comments: Remove a useless line of code
      b6fc58c3
    • Felix Ernst's avatar
      Add an option to use an UrlNavigator in the toolbar instead · ad5d3367
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      This commit adds a locationInToolbar KToggleAction to switch between
      using a location bar to navigate or using a new custom QWidgetAction
      in the toolbar.
      
      A big portion of this MR is refactoring because until now the
      UrlNavigator was tightly intertwined with the DolphinViewContainer.
      With this MR an UrlNavigator for controlling a View can be freely
      connected or disconnected with a single method call.
      
      A DolphinUrlNavigator class is created in the process which contains all
      Dolphin-specific UrlNavigator code which did previously reside in the
      DolphinViewContainer class. Other application parts that belong to
      UrlNavigator-management are also moved here.
      ad5d3367
  9. 23 Oct, 2020 2 commits
  10. 05 Oct, 2020 1 commit
  11. 25 Aug, 2020 1 commit
  12. 18 Aug, 2020 1 commit
    • Ahmad Samir's avatar
      Port KRun to OpenUrlJob · 257eeebf
      Ahmad Samir authored and David Faure's avatar David Faure committed
      In DolphinMainWindow, since KRun allows running executables by default, use
      setRunExecutables(true) so as not to change the behaviour.
      
      Remove the now redundant slotHandleUrlStatFinished, that whole StatJob
      logic is now handled by OpenUrlJob.
      
      Bump KF required version to 5.73, since that's where
      OpenUrlJob::setShowOpenOrExecuteDialog was introduced.
      257eeebf
  13. 04 May, 2020 1 commit
    • Méven Car's avatar
      [Details mode] Allow to fill the column size of directories with actual size · e6ea3ab4
      Méven Car authored
      Summary:
      Allow to compute the recursive size of directories to fill the details view size column.
      A setting allow to set a limit to the recursive level, allowing the user to have some power over the setting.
      
      When sorting by size and the feature is on, we get progressive ordering as the directory size are gathered.
      
      KDirectoryContentsCounter uses a cache internally to keep results so that it can display directory size faster, but counts the dir size of directories each time it is asked to count the size a directory nevertheless and when the size has changed, it is updated.
      KDirectoryContentsCounter uses one worker per instance only, meaning one process per view makes the disk spin.
      
      FIXED-IN: 20.08
      BUG: 190580
      BUG: 158090
      
      Test Plan:
      With some recursion allowed:
      {F8267580}
      
      Without any recursion allowed (default):
      {F8267581}
      
      Reviewers: elvisangelaccio, ngraham, #dolphin
      
      Reviewed By: elvisangelaccio, ngraham, #dolphin
      
      Subscribers: feverfew, anthonyfieroni, iasensio, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D25335
      e6ea3ab4
  14. 18 Apr, 2020 1 commit
    • Shlomi Fish's avatar
      Move from the searchbox to the results with the down arrow key · 196f4553
      Shlomi Fish authored and Nate Graham's avatar Nate Graham committed
      Summary:
      Move from the searchbox to the search results listbox/view using the
      down arrow key in addition to the existing methods using the tab key,
      return key, or the mouse.
      
      Test Plan:
      use ctrl+f to search in a directory tree, press down arrow key
      to go to the results
      
      Reviewers: ngraham, #dolphin
      
      Reviewed By: ngraham, #dolphin
      
      Subscribers: meven, elvisangelaccio, ngraham, iasensio, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D26362
      196f4553
  15. 15 Apr, 2020 1 commit
    • Antonio Prcela's avatar
      Do not display full path in the title of the tab · 26f8e688
      Antonio Prcela authored and Nate Graham's avatar Nate Graham committed
      Summary:
      Displays the full path only in the window title, not in the tab title.
      
      Screenshot for comparison: ( Dolphin on the right is without D28815 , Dolphin on left has both D28815 and this patch)
      
      {F8240079}
      
      Reviewers: #vdg, #dolphin, ngraham, meven
      
      Reviewed By: #vdg, #dolphin, ngraham, meven
      
      Subscribers: ngraham, elvisangelaccio, meven, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D28857
      26f8e688
  16. 14 Apr, 2020 1 commit
  17. 20 Jan, 2020 1 commit
  18. 11 Jan, 2020 1 commit
    • Piotr Henryk Dabrowski's avatar
      Hide tooltip instantly on filter change · f729f6f5
      Piotr Henryk Dabrowski authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      Summary:
      Instantly hide tooltip shown over an element when filter bar changes.
      
      Currently the tooltip stays even when filtering causes the file under the mouse to change or disappears entirely.
      The tooltip also continues to cover much of the window - hiding the new filtering results from user.
      
      This is an enhancement to D22512
      
      Test Plan:
      1. place the mouse pointer over a file to show the tooltip
      2. press "/" to activate filter bar
      3. type in filter phrase
      
      Reviewers: #dolphin, elvisangelaccio, ngraham
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D26576
      f729f6f5
  19. 09 Nov, 2019 1 commit
  20. 06 Oct, 2019 1 commit
  21. 03 Oct, 2019 2 commits
    • Ismael Asensio's avatar
      Update searchbox on URL changes (Fix D24369) · 3d65fa9a
      Ismael Asensio authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      Summary:
      In D24369 I introduced a regression: Where now the searchbox is updated on url changes for search urls, it is not updated anymore for regular folders. The effect is that not-indexed folders can have the extra options enabled or vice-versa. This patch fixes it, moving back the updating logic to `setSearchModeEnable`.
      
      Test Plan: - Searchbox updates properly when changing between search urls and regular folders, either indexed or nor-indexed.
      
      Reviewers: #dolphin, elvisangelaccio
      
      Subscribers: kfm-devel, elvisangelaccio
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D24376
      3d65fa9a
    • Ismael Asensio's avatar
      Update searchbox on URL changes (Fix D24369) · 8599a42a
      Ismael Asensio authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      Summary:
      In D24369 I introduced a regression: Where now the searchbox is updated on url changes for search urls, it is not updated anymore for regular folders. The effect is that not-indexed folders can have the extra options enabled or vice-versa. This patch fixes it, moving back the updating logic to `setSearchModeEnable`.
      
      Test Plan: - Searchbox updates properly when changing between search urls and regular folders, either indexed or nor-indexed.
      
      Reviewers: #dolphin, elvisangelaccio
      
      Subscribers: kfm-devel, elvisangelaccio
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D24376
      8599a42a
  22. 02 Oct, 2019 1 commit
    • Ismael Asensio's avatar
      Update searchbar parameters on URL change · b3120cb9
      Ismael Asensio authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      Summary:
      Searchbar options (text and options) were only updated when toggling the search on, $
      Main use case is when changing between stored search urls in Places panel.
      
      Test Plan:
      - Store two search urls in Places panel
      - Navigate between them
      - The searchbar text and parameters change accordingly
      
      BEFORE:
      {F7500811}
      AFTER:
      {F7500813}
      
      Reviewers: #dolphin, elvisangelaccio
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D24369
      b3120cb9
  23. 15 Sep, 2019 1 commit
    • Nazar Kalinowski's avatar
      Fix wrong window titles · 681d8bb6
      Nazar Kalinowski authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      Summary:
      BUG: 389135
      FIXED-IN: 19.11.80
      
      Currently dolphin shows a folder's name instead of a "place" name if the current path has trailing slash and place's name doesn't, or vice versa.
      This patch fixes this behavior, so that dolphin always shows a "place" name.
      
      The QUrl::FullyEncoded string conversion is required because that's how
      the places model stores the places URLs in the XML bookmarks file.
      
      Test Plan:
      Test configuration: https://imgur.com/a/U4zBp8c
      Before (wrong window titles are in red): https://imgur.com/a/dB4xRwo
      After (all window titles are correct): https://imgur.com/a/W7virBn
      
      Reviewers: #dolphin, elvisangelaccio
      
      Subscribers: elvisangelaccio, ngraham, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D23706
      681d8bb6
  24. 08 Sep, 2019 1 commit
  25. 02 Sep, 2019 2 commits
    • Elvis Angelaccio's avatar
      Fix places text when the URL has a trailing slash · c5a71376
      Elvis Angelaccio authored
      Summary: QUrl::fileName() returns an empty string if the URL ends with a slash.
      
      Test Plan:
      1. Run `dolphin /tmp` from command line
      2. Right-click from viewport and click 'Add to Places'
      
      Reviewers: ngraham
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D23654
      c5a71376
    • Kai Uwe Broulik's avatar
      Reset progress bar text when directory loading starts · ada16756
      Kai Uwe Broulik authored
      Dolphin shows a different text for whether it is loading the directory or currently sorting its contents.
      However, when entering a folder that causes sort criteria to change (e.g. because of different view properties in that folder),
      the status bar text is changed to "Sorting..." while it is still actually loading the folder.
      When loading a directory starts, reset any status bar text to ensure "Loading..." is displayed in this case.
      
      Differential Revision: >https://phabricator.kde.org/D23459
      ada16756
  26. 01 Sep, 2019 1 commit
    • Ismael Asensio's avatar
      [dolphin] Add an action to toggle the searchbar · 3a758690
      Ismael Asensio authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      Summary:
      Make search action toggle the searchbar instead of just launching it.
      
      The search action in dolphin did only bring up the search bar, but to close it again you had to go to the closing button on the same searchbar.
      This behavior in inconsistent with other dolphin actions which toggle panels or tools.
      
      BEFORE:
      {F7256652}
      
      AFTER:
      {F7256862}
      
      BUG: 344617
      FIXED-IN: 19.12.0
      Closes T8473
      
      Depends on D23075
      
      Test Plan:
      - Enable the search mode: the searchbar appears and the toolbar button gets checked
      - Press the search button again, and it goes back to normal mode.
      - The search button state is coherent with the searchbox
      - Coherence is kept when changing to a split view or different tab
      - Shorcut <Ctrl-F> does not close the searchbar, but moves the focus to it.
      
      Reviewers: #dolphin, ngraham, #vdg, elvisangelaccio
      
      Reviewed By: ngraham, #vdg
      
      Subscribers: ndavis, felixernst, elvisangelaccio, kfm-devel
      
      Tags: #dolphin
      
      Maniphest Tasks: T8473
      
      Differential Revision: https://phabricator.kde.org/D23232
      3a758690
  27. 23 Jun, 2019 1 commit
    • Felix Ernst's avatar
      Add "What's This?" to nearly everything in the main window · bd788a3f
      Felix Ernst authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      Summary:
      This commit adds "What's This?" help to nearly everything in the
      Dolphin main window (panels, views, buttons, ...). It adds the "?"
      to the title bar so this help can easily be called.
      
      For links in those help texts to work the WhatsThisClickedEvents are
      handled in the main window class. This doesn't work for menus because
      events from them aren't forwarded to the main window for some
      reason so EventFilters are installed for the Control button menus.
      
      Modifying the "Help" menu of KXmlGui is deprecated so no EventFilter
      can be installed in the menubar. Therefore help texts without links
      are provided for the menubar.
      
      Test Plan:
      Check if the event handling might make any problems.
      Check for any big mistakes in the help messages.
      
      Reviewers: #dolphin, elvisangelaccio
      
      Subscribers: broulik, elvisangelaccio, yurchor, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D20471
      bd788a3f
  28. 26 May, 2019 1 commit
    • Nate Graham's avatar
      When filter bar is focused, switch to view when tab key is pressed · c22df71d
      Nate Graham authored
      Summary:
      Various people have requested that the tab key move keyboard focus from the filter bar's
      text edit field to the main view. It already does this when the Enter and return keys
      are pressed, but apparently this is not very intuitive and people expect Tab to work too.
      
      This patch makes that behavior possible by moving the Lock button to the left of the
      text edit field, and re-arranging the code so that the filter bar is initialized first.
      This works because Qt assigns tab ordering by default according to the order of widget
      construction. So if we simply construct the main view right after the filter bar, then
      the tab ordering is set up this way automatically.
      
      BUG: 403379
      BUG: 403356
      FIXED-IN: 19.08.0
      
      Test Plan:
      1. Activate Filter bar
      2. Hit Tab key
      3. View has become focused
      4. Play around in Dolphin for a while and notice no regressions or crashes
      
      Reviewers: #dolphin, elvisangelaccio
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D21177
      c22df71d
  29. 18 Mar, 2019 1 commit
  30. 27 Feb, 2019 1 commit
  31. 17 Feb, 2019 1 commit
    • Nate Graham's avatar
      Word-wrap KMessageWidget text · cf2da56c
      Nate Graham authored
      Summary:
      Word-wrap KMessageWidget text to prevent the window from being widened
      when the text is very long.
      
      CCBUG: 404232
      
      Only `CCBUG: ` because word wrap only works where QLabel detects a word boundary;
      it will not wrap a string with no spaces or other word boundaries (e.g.
      "aaaaaaaaaaaaaaaaaaaa...")
      
      Test Plan:
      - Create a new text file with a 300-character name that has spaces in it
      - In the KMessageWidget's error message, the file name is wrapped at the word
      boundaries
      
      Reviewers: #dolphin, #frameworks, cfeck, elvisangelaccio
      
      Reviewed By: #dolphin, cfeck, elvisangelaccio
      
      Subscribers: elvisangelaccio, cfeck, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D18968
      cf2da56c
  32. 15 Jan, 2019 1 commit