1. 18 Jul, 2018 1 commit
    • David Hallas's avatar
      Fixes small memory leak in DolphinContextMenu · f186124f
      David Hallas authored
      Summary: When DolphinContextMenu::baseFileItem is called a KFileItem is allocated and stored in DolphinContextMenu::m_baseFileItem, which is of type KFileItem*, but the destructor failed to delete this.
      
      Test Plan: This leak was found using Address Sanitizer
      
      Reviewers: broulik, elvisangelaccio
      
      Reviewed By: broulik, elvisangelaccio
      
      Subscribers: ngraham, kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D14178
      f186124f
  2. 02 Jun, 2018 1 commit
    • Nerdopolis Turfwalker's avatar
      Add 'Sort By' and 'View Mode' into Dolphin file context menus · 97801e2c
      Nerdopolis Turfwalker authored
      Summary: This adds the 'Sort By' and 'View Mode'  options into the context menu of Dolphin within the file browser. I keep looking for these option (especially sort by) in the Context Menu, and keep forgetting to go to the menu. It also makes the order of "View Mode" and "Sort By" options consistent in the control menu
      
      Test Plan: Made sure that the options appeared when right clicking on an empty space.
      
      Reviewers: #dolphin, ngraham, elvisangelaccio
      
      Reviewed By: #dolphin, ngraham, elvisangelaccio
      
      Subscribers: question, markg, elvisangelaccio, mmustac, rkflx, ngraham, kfm-devel, #dolphin
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D12911
      97801e2c
  3. 20 May, 2018 1 commit
  4. 14 May, 2018 1 commit
  5. 22 Apr, 2018 1 commit
    • Nate Graham's avatar
      Move "Open" actions to the top of the context menu for files · b9143a55
      Nate Graham authored
      Summary:
      This patch moves the "Open", "Open With", and "Open in" items to the top of the context menu to reap the following benefits:
      - Move the "Open" and "Open With" items closer to the top since they're commonly used items, and right now they're buried in the middle of the menu
      - Group related functionality
      - Consistency with other common platforms (macOS Finder and Windows Explorer both have these items at the top of the context menu)
      
      For folders, the "Open With" entries are moved higher, but not all the way to the top, since the "open in New tab/folder" entries are more useful.
      
      Test Plan:
      Tested all menu items in the context menu for files, folders, and links; all still work.
      
      Context menu for single file:
      {F5806809}
      
      Context menu for multiple files:
      {F5806810}
      
      Context menu for single folder:
      {F5806811}
      
      Context menu for multiple folders:
      {F5806812}
      
      Context menu for symlink to folder:
      {F5806815}
      
      Reviewers: #dolphin, #vdg, elvisangelaccio, abetts
      
      Reviewed By: #dolphin, #vdg, elvisangelaccio, abetts
      
      Subscribers: markg, abetts, elvisangelaccio
      
      Differential Revision: https://phabricator.kde.org/D11884
      b9143a55
  6. 24 Mar, 2018 1 commit
  7. 22 Mar, 2018 1 commit
    • Nate Graham's avatar
      Fix missing entries in context menu for links · f728d728
      Nate Graham authored
      Summary: https://cgit.kde.org/dolphin.git/commit/?id=86f4fcb8cd574f6d886627fc5e01c9edfc84e977 introduced a regression: the context menu for links no longer shows various items that were gated behind being a directory. However, a link can be both a link and a directory, from KIO's perspective. This patch resolves the issue.
      
      Test Plan:
      - Context menus for files, folders, and file links are unchanged.
      - The missing context menu items for folder links have returned: {F5761809}
      
      I should have tested that patch better, and for that I apologize and offer to fix this regression here. I will endeavor to up my reviewing game.
      
      Reviewers: rominf, michaelh, #dolphin, rkflx
      
      Reviewed By: rominf, rkflx
      
      Subscribers: rkflx
      
      Differential Revision: https://phabricator.kde.org/D11562
      f728d728
  8. 21 Mar, 2018 1 commit
  9. 18 Mar, 2018 1 commit
  10. 14 Mar, 2018 1 commit
  11. 11 Mar, 2018 1 commit
  12. 10 Mar, 2018 1 commit
  13. 05 Mar, 2018 1 commit
  14. 04 Mar, 2018 2 commits
  15. 14 Dec, 2017 1 commit
  16. 21 Nov, 2017 1 commit
  17. 03 Nov, 2017 1 commit
  18. 01 Nov, 2017 1 commit
    • Nathaniel Graham's avatar
      Make Saved Search feature discoverable · 64cfc43b
      Nathaniel Graham authored
      Summary:
      FEATURE: 269332
      
      Make Dolphin's Saved Search feature discoverable by adding a button inside the search field. The button only becomes enabled when there is a valid search term. When pushed, it saves the search to the Places panel, providing a visible-by-default way to do this to complement the existing implementation that is only visible in the context menu.
      
      Also harmonized the label text so that it's consistent no matter how you create a saved search (button or context menu)
      
      Test Plan:
      Tested in KDE Neon. Works great:
      {F5449508}
      
      Reviewers: #dolphin, broulik, dfaure, markg, emateli, elvisangelaccio
      
      Reviewed By: #dolphin, markg, emateli, elvisangelaccio
      
      Subscribers: anthonyfieroni, markg, emateli, elvisangelaccio, cfeck, #dolphin
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D8454
      64cfc43b
  19. 07 Sep, 2017 1 commit
  20. 09 Aug, 2017 1 commit
  21. 27 Jul, 2017 1 commit
  22. 06 Jun, 2017 1 commit
  23. 13 Mar, 2017 1 commit
    • Elvis Angelaccio's avatar
      Port to KStandardAction::DeleteFile · 68bb0ec2
      Elvis Angelaccio authored
      Summary:
      It was introduced in kconfig 5.25 and it properly handles the shift+del
      shortcut (together with kxmlgui >= 5.30). This allows us to drop the
      custom delete shortcut as well as the shift+del workaround in
      DolphinMainWindow.
      
      Test Plan: Shift+Del still deletes files, without the 'ambiguous shortcut' warning dialog.
      
      Reviewers: emmanuelp
      
      Differential Revision: https://phabricator.kde.org/D5010
      68bb0ec2
  24. 05 Feb, 2017 1 commit
  25. 18 Jan, 2017 1 commit
  26. 03 Jan, 2017 1 commit
  27. 02 Oct, 2016 1 commit
  28. 10 Sep, 2016 2 commits
  29. 23 Aug, 2016 1 commit
    • Elvis Angelaccio's avatar
      Filter json-only KFileItemAction plugins by mimetype · 809ba746
      Elvis Angelaccio authored
      Commit d48b7334 introduced support for kfileitemaction plugins with json
      metadata, but forgot to filter them by the commonMimeType (like
      KMimeTypeTrader::query() does with old-style plugins).
      
      So we need to load a plugin only when commonMimeType is equal to (or child of) one
      of the mimetypes supported by the plugin.
      809ba746
  30. 18 Jun, 2016 1 commit
  31. 08 Jun, 2016 1 commit
  32. 16 Mar, 2016 1 commit
  33. 10 Feb, 2016 1 commit
  34. 21 Mar, 2015 1 commit
  35. 04 Feb, 2015 1 commit
  36. 28 Jan, 2015 1 commit
  37. 25 Dec, 2014 1 commit
  38. 14 Dec, 2014 1 commit