1. 01 Mar, 2020 1 commit
    • Alexander Saoutkin's avatar
      Fix files not being highlighted if directory of file is already open · fef7eebc
      Alexander Saoutkin authored
      Summary:
      In DolphinTabWidget::openFiles it assumes openDirectories will open new tabs, so it
      only marks the URL selection for the newly opened tabs. This assumption is incorrect
       as Dolphin might reuse tabs when the folder is already open.
      
      Even then, markUrlsAsSelected does nothing when the folder is already opened.
      The selection seems to only be used when the folder finishes loading, calls made after
      that only change a variable without updating the actual selection.
      
      A call to DolphinView::updateViewState() is required to restore the intended behaviour, so long as DolphinView::clearSelection() has been called on the relevant tab, otherwise updateViewState() is a no-op.
      
      BUG: 417230
      FIXED-IN: 19.12.3
      
      Test Plan:
      1. In any application that has an "open containing folder" select that option
      2. and then do the same for another file in the same folder
      
      Reviewers: broulik
      
      Reviewed By: broulik
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D27389
      fef7eebc
  2. 11 Jan, 2020 1 commit
    • Piotr Henryk Dabrowski's avatar
      Hide tooltip instantly on filter change · f729f6f5
      Piotr Henryk Dabrowski authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      Summary:
      Instantly hide tooltip shown over an element when filter bar changes.
      
      Currently the tooltip stays even when filtering causes the file under the mouse to change or disappears entirely.
      The tooltip also continues to cover much of the window - hiding the new filtering results from user.
      
      This is an enhancement to D22512
      
      Test Plan:
      1. place the mouse pointer over a file to show the tooltip
      2. press "/" to activate filter bar
      3. type in filter phrase
      
      Reviewers: #dolphin, elvisangelaccio, ngraham
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D26576
      f729f6f5
  3. 10 Sep, 2019 1 commit
  4. 03 Aug, 2019 1 commit
    • Piotr Henryk Dabrowski's avatar
      [Dolphin] Hide tooltip instantly on key press · ba92917a
      Piotr Henryk Dabrowski authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      Summary:
      Instantly hide tooltip shown over an element when a key is pressed.
      
      Currently, when pressing an alphanum key to select a different file,
      the tooltip continues to cover much of the window - often hiding that newly selected file from view.
      
      Reviewers: #dolphin, ngraham, elvisangelaccio
      
      Reviewed By: #dolphin, elvisangelaccio
      
      Subscribers: broulik, elvisangelaccio, kfm-devel, pdabrowski
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D22512
      ba92917a
  5. 09 Mar, 2019 1 commit
    • David Hallas's avatar
      New tab placed after current tab when middle-clicking · e602e532
      David Hallas authored
      Summary:
      New tabs should be placed after the currently active tab when using
      middle click.
      
      Test Plan:
      Open new tab from the places panel using middle click, verify that the
      Open new tab from the folders panel using middle click, verify that the
      tab is opened after the current tab
      Open new tab by middle clicking on the Back button, verify that the tab
      is opened after the current tab
      Open new tab by middle clicking on the Forward button, verify that the tab
      is opened after the current tab
      
      FEATURE: 403690
      
      Reviewers: #dolphin, ngraham, elvisangelaccio
      
      Reviewed By: #dolphin, ngraham, elvisangelaccio
      
      Subscribers: kfm-devel
      
      Tags: #dolphin
      
      Differential Revision: https://phabricator.kde.org/D19201
      e602e532
  6. 25 Oct, 2018 1 commit
  7. 04 Mar, 2018 1 commit
  8. 20 Nov, 2017 1 commit
  9. 27 Oct, 2017 1 commit
    • Andreas Krutzler's avatar
      Two clicks on file/folder to rename · 54542830
      Andreas Krutzler authored and Nate Graham's avatar Nate Graham committed
      Summary:
      Make renaming of files/folders faster by clicking a second time on the items text to start renaming.
      BUG: 205157
      
      Test Plan:
      This feature works as follows:
      
      1. select an item by single-click, or one is already selected
      2. wait the "double-click-interval"
      3. click on the items text
      4. none of the cancellations (see below) happens within the double-click-interval
      5. inline-renaming starts
      
      Cancellations:
      * open any file/folder
      * select different item(s)
      * start dragging items
      * Dolphin loses focus
      
      This feature is just enabled while "Double-click to open files and folders" in system-settings and "Rename inline" in Dolphin are enabled.
      
      Reviewers: #dolphin, #kde_applications, elvisangelaccio, emmanuelp, ngraham, markg, rkflx
      
      Reviewed By: #dolphin, #kde_applications, elvisangelaccio, ngraham, rkflx
      
      Subscribers: rkflx, markg, funkybomber, sars, elvisangelaccio, ngraham
      
      Differential Revision: https://phabricator.kde.org/D7647
      54542830
  10. 17 Sep, 2017 1 commit
    • Emirald Mateli's avatar
      Keep renamed file(s) in view · 478f404b
      Emirald Mateli authored and Elvis Angelaccio's avatar Elvis Angelaccio committed
      When renaming a file, if its new name causes it to scroll out of view,
      Dolphin will not scroll to the location of the new file.
      This patch aims to address that. This affects all view modes.
      
      CCBUG: 354330
      
      Test Plan:
      1. Have many files in a directory (or several files, just zoom in a lot)
      2. Rename a file so that it will move out of view
      
      Differential Revision: https://phabricator.kde.org/D6312
      478f404b
  11. 27 Jul, 2017 1 commit
    • Elvis Angelaccio's avatar
      Fix drop menu position with urlnavigator drops · c3de8676
      Elvis Angelaccio authored
      Commit 1e251d2f6a in kio broke drop menus when dropping on the URL
      navigator (menus show up in the DolphinView rather than the URL bar).
      This happens because in DolphinView::dropUrls() we set `this` as the
      widget passed to KJobWidgets::setWindow() (in DragAndDropHelper::dropUrls()).
      
      We need to replace `this` with the actual widget that received the QDropEvent
      and that can mapToGlobal() the relative pos of the drop event.
      Unfortunately this widget is not KUrlNavigator itself, but one of its
      KUrlNavigatorButton children (private class, not exported). So
      unfortunately we need a new API in KIO that exposes this child widget.
      
      Differential Revision: https://phabricator.kde.org/D6684
      c3de8676
  12. 08 May, 2017 1 commit
    • Elvis Angelaccio's avatar
      Don't ignore tag clicks in the tooltips · 73f885f9
      Elvis Angelaccio authored
      Summary:
      Now that we can use the metadata widgets in the tooltips, we can also
      open the tags:// url if the user clicks some tag in a tooltip.
      
      The behavior is now consistent with the metadata widget in the information panel.
      
      Test Plan: Click a tag when the metadata tooltip shows up.
      
      Reviewers: emmanuelp
      
      Subscribers: #konqueror, #dolphin
      
      Differential Revision: https://phabricator.kde.org/D5658
      73f885f9
  13. 18 Feb, 2017 1 commit
    • Emmanuel Pescosta's avatar
      Restore the view state after the URL of the DolphinView has been changed, · 41b0e429
      Emmanuel Pescosta authored
      as stated in the documentation of KUrlNavigator::saveLocationState.
      
      The historyChanged signal of the KUrlNavigator is emitted before the urlChanged
      signal and so the view state restoring happens before the view URL has been
      changed. This makes it impossible to save and restore the selected URLs, because
      DolphinView::setUrl clears the list of selected items (which has been restored
      right before). This changes removes the history changed slot and restores the
      view state after the setUrl call.
      41b0e429
  14. 03 Jan, 2017 1 commit
  15. 04 Sep, 2016 1 commit
  16. 03 Sep, 2015 1 commit
  17. 25 Feb, 2015 1 commit
  18. 05 Jan, 2015 1 commit
  19. 03 Nov, 2014 1 commit
  20. 02 Nov, 2014 2 commits
  21. 21 Oct, 2014 1 commit
  22. 20 Oct, 2014 1 commit
  23. 18 Oct, 2014 1 commit
  24. 10 Oct, 2014 1 commit
  25. 22 Sep, 2014 1 commit
  26. 22 Aug, 2014 1 commit
  27. 31 Jul, 2014 1 commit
  28. 05 May, 2014 1 commit
    • Alex Richardson's avatar
      Allow compiling Dolphin with KF5 · 2f045c60
      Alex Richardson authored
      This does not work properly yet, there are probably quite a few bad signal/
      slot connections due to KUrl -> QUrl. However dolphin starts without
      crashing.
      
      Accessibility is not ported since that changed quite a lot from Qt4 -> Qt5
      and I have no idea how it is supposed to be used.
      
      This is the first commit for review 117395
      2f045c60
  29. 05 Mar, 2014 1 commit
  30. 06 Feb, 2014 1 commit
  31. 30 Oct, 2013 1 commit
    • Frank Reininghaus's avatar
      Store the selected items in a more efficient way · fc2ab478
      Frank Reininghaus authored
      Since Dolphin 2.0, we have stored the selected items in a QSet<int>,
      which is neither space-efficient nor particularly fast when inserting
      many items which are in a consecutive range.
      
      This commit replaces the QSet<int> by a new class "KItemSet", which
      stores the items in a sorted list of ranges. For each range, we only
      store the first index and the length of the range, so we need a lot
      less memory for most common selection patterns, and we also save quite
      a few CPU cycles in many situations, because adding an item to the
      KItemSet will in many cases not need a memory allocation at all, and
      it's particularly easy when inserting sorted items into the KItemSet in
      a row.
      
      KItemSet contains a minimal subset of QSet's API which makes it
      suitable as a drop-in replacement for our needs. It also has iterators,
      such that the items can be iterated through easily, also with foreach.
      One advantage of KItemSet compared to QSet<int> is that the items are
      always iterated through in ascending order.
      
      REVIEW: 113488
      fc2ab478
  32. 16 Oct, 2013 1 commit
  33. 22 Jun, 2013 1 commit
  34. 13 Jun, 2013 1 commit
  35. 10 Jun, 2013 2 commits
  36. 04 Jun, 2013 1 commit
  37. 23 Apr, 2013 1 commit
  38. 09 Jan, 2013 1 commit