Revert "contextmenu: Use default terminal's icons for "Open Terminal" and...

Nate Grahamrequested to merge
work/ngraham/more-generic-terminal-action into master

Revert "contextmenu: Use default terminal's icons for "Open Terminal" and "Open Terminal Here" actions"

This reverts commit eaaeb1b7.

This change is problematic because it intends to produce greater specificity regarding the icon of the terminal app that it cannot actually provide. There are two reasons for this:

  1. checking the value of TerminalService in kdeglobals is not good enough as it misses the default case (not set, fall back to Konsole) and also fails to check TerminalApplication.
  2. Even if that were fixed, the code in KTerminalLauncherJob to determine a terminal app is complex and accounts for numerous edge cases, making the actually returned terminal app potentially different from what those config file keys specifies.

As a result, we simply cannot reliably get the icon of the terminal app that will actually launch.

Instead, show a generic symbolic icon, which isn't wrong for anything. This is also a better match for the generic name ("Terminal") shown in the menu items.

Here's how it looks:

Screenshot_20250723_093054

BUG: 501435
FIXED-IN: 25.08.0

Merge request reports