Skip to content

Make "open path" and "open path in new tab" scroll to the selected item when searching for it

Akseli Lahtinen requested to merge work/akselmo/fix-scrolling-to-item-on-open-path into master

Open Path

When user clicks on "Open Path" after searching for an item, user expects the view to show the item immediately.

Currently KItemListSmoothScroller animation gets interrupted immediately due to geometry changes, which are caused by the FileSearch box closing.

This MR adds a patch that waits for the KItemListSmoothScroller to be done with its animation before the scrollbar sizes are being changed.

Open Path in New Tab

When user selects "Open Path in New Tab", we open a new tab to the folder where the file is. However, the item selection is never given to the new tab, so it wont scroll to it.

If we give a file to a new tab instead of directory, we should open the directory that file is in and wait for user to activate the tab, then scroll to the item.

BUG:495613

Testcase:

  1. Create folder in home with a lot of files, then a specifically named file
  2. Start search from home folder for this specific file, make sure "Your files" is selected
  3. When file is found, right click, select open path
  4. The scrollbar wont move to the file, instead is halfway to it due to smooth scrolling
Edited by Akseli Lahtinen

Merge request reports