Commit 69c3eba0 authored by Elvis Angelaccio's avatar Elvis Angelaccio

Fix knewstuff popup menu position on wayland

On Wayland we need to pass a parent to popup menus.
See https://community.kde.org/Guidelines_and_HOWTOs/Wayland_Porting_Notes#Popup_Menus

So we use the new setParentWidget() method from KNewStuff (introduced in
Frameworks 5.37).
parent aa771da3
......@@ -27,7 +27,7 @@
#include <KLocalizedString>
#include <KNS3/KMoreToolsMenuFactory>
#include <KIO/Job>
#include <knewstuff_version.h>
StatusBarSpaceInfo::StatusBarSpaceInfo(QWidget* parent) :
KCapacityBar(KCapacityBar::DrawTextInline, parent),
......@@ -78,6 +78,9 @@ void StatusBarSpaceInfo::mousePressEvent(QMouseEvent* event)
// Note that this object must live long enough in case the user opens
// the "Configure..." dialog
KMoreToolsMenuFactory menuFactory(QStringLiteral("dolphin/statusbar-diskspace-menu"));
#if KNEWSTUFF_VERSION >= QT_VERSION_CHECK(5, 37, 0)
menuFactory.setParentWidget(this);
#endif
auto menu = menuFactory.createMenuFromGroupingNames(
{ "disk-usage", "more:", "disk-partitions" }, m_url);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment