Members of the KDE Community are recommended to subscribe to the kde-community mailing list at https://mail.kde.org/mailman/listinfo/kde-community to allow them to participate in important discussions and receive other important announcements

Commit 8cea647c authored by Nathaniel Graham's avatar Nathaniel Graham

Change "Empty Search" to just "Search" to handle searches with no search text

Summary:
BUG: 387854

The pre-defined searches (Documents, Videos, etc) all default to no search text. https://cgit.kde.org/dolphin.git/commit/?id=702429ac8e64a5aff4e110a56f526b96ecb795fd changed their window title from "baloosearch - /" to "Empty Search", but the search isn't really empty; it just lacks a search string. It's still looking for documents, or videos, or whatever.

Test Plan:
Is it too late to get this into 5.12?

Tested in KDE Neon. Before:
{F5545170}

After:
{F5545171}

Reviewers: #dolphin, elvisangelaccio, broulik

Reviewed By: broulik

Differential Revision: https://phabricator.kde.org/D9305
parent 504545c5
......@@ -1003,7 +1003,7 @@ void DolphinMainWindow::setUrlAsCaption(const QUrl& url)
if (m_activeViewContainer->isSearchModeEnabled()) {
if(m_activeViewContainer->currentSearchText().isEmpty()){
setWindowTitle(i18n("Empty Search"));
setWindowTitle(i18n("Search"));
} else {
const auto searchText = i18n("Search for %1", m_activeViewContainer->currentSearchText());
setWindowTitle(searchText);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment