Commit a9e2f01a authored by Nikolai Krasheninnikov's avatar Nikolai Krasheninnikov
Browse files

Fixes Dolphin crash on "Defocus Terminal Panel" menu click if no Konsole is installed.

Summary:
Dolphin crashes if no Konsole is installed and user clicks menu action "Defocus Terminal Panel".
This fix is pretty straight forward.

Steps to reproduce:
1. Run Dolphin without Konsole available.
2. Press F4 to open console window.
3. Click in service menu "Focus Terminal Panel".
4. Click in service menu "Defocus Terminal Panel". Observe the crash.

Test Plan:
1. Run Dolphin without Konsole available.
2. Press F4 to open console window.
3. Click in service menu "Focus Teminal Panel".
4. Click in service menu "Defocus Terminal Panel".
5. Click in service menu "Focus Terminal Panel".
6. Press F4 to close console window.

Reviewers: #dolphin, meven, elvisangelaccio, ngraham

Reviewed By: #dolphin, meven, elvisangelaccio, ngraham

Subscribers: kfm-devel

Tags: #dolphin

Differential Revision: https://phabricator.kde.org/D29345
parent fd827e41
......@@ -308,5 +308,9 @@ void TerminalPanel::slotKonsolePartCurrentDirectoryChanged(const QString& dir)
bool TerminalPanel::terminalHasFocus() const
{
return m_terminalWidget->hasFocus();
if (m_terminalWidget) {
return m_terminalWidget->hasFocus();
}
return hasFocus();
}
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment