Members of the KDE Community are recommended to subscribe to the kde-community mailing list at https://mail.kde.org/mailman/listinfo/kde-community to allow them to participate in important discussions and receive other important announcements

Commit ecbab345 authored by Elvis Angelaccio's avatar Elvis Angelaccio

Fix all krazy #include warnings

- "include own header first line"
- "put config.h in angle brackets line"
- "do not include QtModule/QtClass line"

`QElapsedTimer` was implicitly included by
kfileitemmodelsortalgorithm.h, now we need to explicitly include it in
kfileitemmodel.cpp.

We also need to explicitly link to `Qt5::Concurrent`, otherwise we
cannot `#include <QtConcurrentRun>`.
parent 219e40cf
......@@ -137,6 +137,7 @@ generate_export_header(dolphinprivate BASE_NAME dolphin)
target_link_libraries(
dolphinprivate PUBLIC
dolphinvcs
Qt5::Concurrent
Qt5::Gui
KF5::Crash
KF5::I18n
......
......@@ -17,16 +17,15 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
*/
#include <QApplication>
#include <QIcon>
#include <KRun>
#include "global.h"
#include "dolphindebug.h"
#include "dolphin_generalsettings.h"
#include <KRun>
#include <QApplication>
#include <QIcon>
QList<QUrl> Dolphin::validateUris(const QStringList& uriList)
{
const QString currentDir = QDir::currentPath();
......
......@@ -31,6 +31,7 @@
#include "private/kfileitemmodelsortalgorithm.h"
#include "private/kfileitemmodeldirlister.h"
#include <QElapsedTimer>
#include <QMimeData>
#include <QTimer>
#include <QWidget>
......
......@@ -24,10 +24,10 @@
#include "dolphin_export.h"
#include <QtCore/qpointer.h>
#include <qaccessible.h>
#include <qaccessibleobject.h>
#include <QtWidgets/qaccessiblewidget.h>
#include <QAccessible>
#include <QAccessibleObject>
#include <QAccessibleWidget>
#include <QPointer>
class KItemListView;
class KItemListContainer;
......
......@@ -22,7 +22,7 @@
#ifndef KFILEITEMMODELSORTALGORITHM_H
#define KFILEITEMMODELSORTALGORITHM_H
#include <QtConcurrent/QtConcurrent>
#include <QtConcurrentRun>
#include <algorithm>
......
......@@ -22,7 +22,7 @@
#include <QDialog>
#include <KFileItem>
#include "config-baloo.h"
#include <config-baloo.h>
#ifndef HAVE_BALOO
class KFileMetaDataConfigurationWidget;
......
......@@ -20,10 +20,11 @@
#ifndef INFORMATIONPANELCONTENT_H
#define INFORMATIONPANELCONTENT_H
#include "config-baloo.h"
#include <config-baloo.h>
#include <KFileItem>
#include <QUrl>
#include <QUrl>
#include <QPointer>
#include <QWidget>
......
......@@ -17,11 +17,11 @@
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA *
***************************************************************************/
#include <KIO/FileSystemFreeSpaceJob>
#include "mountpointobserver.h"
#include "mountpointobservercache.h"
#include <KIO/FileSystemFreeSpaceJob>
MountPointObserver::MountPointObserver(const QUrl& url, QObject* parent) :
QObject(parent),
m_url(url),
......
......@@ -23,7 +23,7 @@
#define DOLPHINFILEMETADATAWIDGET_H
#include <QWidget>
#include "config-baloo.h"
#include <config-baloo.h>
class KFileItemList;
class QLabel;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment