Skip to content

GitLab

Commit 1a3eab7e authored by Laurent Montel's avatar Laurent Montel 😁
Browse files

Rename some variables

parent 3e3adc45
Hide whitespace changes
Inline Side-by-side
src/crontabPrinter.cpp
View file @ 1a3eab7e
......@@ -28,62 +28,42 @@
class CrontabPrinterPrivate
{
public:
/**
* Pointer a printer options object
*/
CrontabPrinterWidget *crontabPrinterWidget = nullptr;
/**
* Pointer to parent widget
*/
CrontabWidget *crontabWidget = nullptr;
QPainter *painter = nullptr;
QPrinter *printer = nullptr;
QRect *printView = nullptr;
int page = 0;
int currentRowPosition = 0;
};
CrontabPrinter::CrontabPrinter(CrontabWidget *crontabWidget)
: d(new CrontabPrinterPrivate())
{
d->crontabWidget = crontabWidget;
mCrontabWidget = crontabWidget;
}
CrontabPrinter::~CrontabPrinter()
{
delete d->crontabPrinterWidget;
delete d->painter;
delete d->printer;
delete d->printView;
delete mCrontabPrinterWidget;
delete d;
delete mPainter;
delete mPrinter;
delete mPrintView;
}
bool CrontabPrinter::start()
{
logDebug() << "Printing selection...";
if (!d->printer) {
d->printer = new QPrinter();
if (!mPrinter) {
mPrinter = new QPrinter();
}
// do some printer initialization
d->printer->setFullPage(true);
mPrinter->setFullPage(true);
/*
CrontabPrinterWidget* dialogPage = new CrontabPrinterWidget(d->crontabWidge);
d->printer->addDialogPage(dialogPage);
CrontabPrinterWidget* dialogPage = new CrontabPrinterWidget(crontabWidge);
printer->addDialogPage(dialogPage);
*/
// initialize the printer using the print dialog
QPrintDialog *printDialog = new QPrintDialog(d->printer, nullptr);
printDialog->setOptionTabs(QList<QWidget *>() << d->crontabWidget);
QPrintDialog *printDialog = new QPrintDialog(mPrinter, nullptr);
printDialog->setOptionTabs(QList<QWidget *>() << mCrontabWidget);
printDialog->setEnabledOptions(QAbstractPrintDialog::PrintToFile);
if (printDialog->exec() == QDialog::Rejected) {
logDebug() << "Printing canceled";
......@@ -94,16 +74,16 @@ bool CrontabPrinter::start()
delete printDialog;
// create a painter to paint on the printer object
d->painter = new QPainter();
mPainter = new QPainter();
// start painting
d->painter->begin(d->printer);
mPainter->begin(mPrinter);
const int margin = computeMargin();
d->printView = new QRect(margin, margin, d->painter->device()->width() - 2*margin, d->painter->device()->height() - 2*margin);
mPrintView = new QRect(margin, margin, mPainter->device()->width() - 2*margin, mPainter->device()->height() - 2*margin);
d->page = 1;
d->currentRowPosition = 0;
mPage = 1;
mCurrentRowPosition = 0;
drawMainTitle();
......@@ -112,7 +92,7 @@ bool CrontabPrinter::start()
void CrontabPrinter::printTasks()
{
CTCron *cron = d->crontabWidget->currentCron();
CTCron *cron = mCrontabWidget->currentCron();
drawTitle(i18n("Scheduled Tasks"));
......@@ -145,10 +125,10 @@ void CrontabPrinter::printTasks()
void CrontabPrinter::printVariables()
{
CTCron *cron = d->crontabWidget->currentCron();
CTCron *cron = mCrontabWidget->currentCron();
d->painter->translate(0, 20);
d->currentRowPosition = 0;
mPainter->translate(0, 20);
mCurrentRowPosition = 0;
//Environment Variables
......@@ -157,23 +137,23 @@ void CrontabPrinter::printVariables()
//QList<QStringList> variablesContent;
const auto variables = cron->variables();
for (CTVariable *variable : variables) {
d->painter->drawText(*(d->printView), Qt::AlignLeft | Qt::TextWordWrap, variable->variable + QLatin1String(" = ") + variable->value);
mPainter->drawText(*(mPrintView), Qt::AlignLeft | Qt::TextWordWrap, variable->variable + QLatin1String(" = ") + variable->value);
const int moveBy = computeStringHeight(variable->variable);
d->painter->translate(0, moveBy);
mPainter->translate(0, moveBy);
}
}
void CrontabPrinter::drawMainTitle()
{
CTCron *cron = d->crontabWidget->currentCron();
CTCron *cron = mCrontabWidget->currentCron();
QFont originalFont = d->painter->font();
QFont originalFont = mPainter->font();
QFont titleFont(originalFont);
titleFont.setPixelSize(20);
titleFont.setBold(true);
d->painter->setFont(titleFont);
mPainter->setFont(titleFont);
QString mainTitle;
if (cron->isSystemCron()) {
......@@ -184,40 +164,40 @@ void CrontabPrinter::drawMainTitle()
mainTitle = i18nc("Crontab of user login", "Crontab of user %1", cron->userLogin());
}
d->painter->drawText(*(d->printView), Qt::AlignHCenter | Qt::TextWordWrap, mainTitle);
mPainter->drawText(*(mPrintView), Qt::AlignHCenter | Qt::TextWordWrap, mainTitle);
d->painter->translate(0, computeStringHeight(mainTitle));
mPainter->translate(0, computeStringHeight(mainTitle));
d->painter->setFont(originalFont);
mPainter->setFont(originalFont);
}
void CrontabPrinter::drawTitle(const QString &title)
{
QFont originalFont = d->painter->font();
QFont originalFont = mPainter->font();
QFont titleFont(originalFont);
titleFont.setPixelSize(16);
titleFont.setBold(true);
d->painter->setFont(titleFont);
mPainter->setFont(titleFont);
d->painter->drawText(*(d->printView), Qt::AlignLeft | Qt::TextWordWrap, title);
mPainter->drawText(*(mPrintView), Qt::AlignLeft | Qt::TextWordWrap, title);
d->painter->translate(0, computeStringHeight(title));
mPainter->translate(0, computeStringHeight(title));
d->painter->setFont(originalFont);
mPainter->setFont(originalFont);
}
void CrontabPrinter::drawHeader(const QList<int> &columnWidths, const QStringList &headers)
{
QFont originalFont = d->painter->font();
QFont originalFont = mPainter->font();
QFont titleFont(originalFont);
titleFont.setBold(true);
d->painter->setFont(titleFont);
mPainter->setFont(titleFont);
drawContentRow(columnWidths, headers);
d->painter->setFont(originalFont);
mPainter->setFont(originalFont);
}
void CrontabPrinter::drawContentRow(const QList<int> &columnWidths, const QStringList &contents)
......@@ -231,9 +211,9 @@ void CrontabPrinter::drawContentRow(const QList<int> &columnWidths, const QStrin
firstColumn = content;
}
d->painter->drawText(*(d->printView), Qt::AlignLeft | Qt::TextWordWrap, QLatin1String(" ") + content);
mPainter->drawText(*(mPrintView), Qt::AlignLeft | Qt::TextWordWrap, QLatin1String(" ") + content);
d->painter->translate(columnWidths[index], 0);
mPainter->translate(columnWidths[index], 0);
totalWidths += columnWidths[index];
......@@ -248,28 +228,28 @@ void CrontabPrinter::drawContentRow(const QList<int> &columnWidths, const QStrin
void CrontabPrinter::finish()
{
// stop painting, this will automatically send the print data to the printer
d->painter->end();
mPainter->end();
}
void CrontabPrinter::printPageNumber()
{
logDebug() << "Printing page number...";
d->painter->translate(0, -d->currentRowPosition);
d->printView->moveTo(QPoint(0, d->printView->height()));
d->painter->translate(0, -d->printView->height());
d->painter->drawText(d->printView->right() - d->painter->fontMetrics().boundingRect(QString::number(d->page)).width(), d->printView->bottom()+ d->painter->fontMetrics().ascent() + 5, QString::number(d->page));
mPainter->translate(0, -mCurrentRowPosition);
mPrintView->moveTo(QPoint(0, mPrintView->height()));
mPainter->translate(0, -mPrintView->height());
mPainter->drawText(mPrintView->right() - mPainter->fontMetrics().boundingRect(QString::number(mPage)).width(), mPrintView->bottom()+ mPainter->fontMetrics().ascent() + 5, QString::number(mPage));
}
void CrontabPrinter::changeRow(int x, int y)
{
d->painter->translate(x, y);
d->currentRowPosition = d->currentRowPosition + y;
mPainter->translate(x, y);
mCurrentRowPosition = mCurrentRowPosition + y;
}
int CrontabPrinter::computeMargin() const
{
const int dpiy = d->painter->device()->logicalDpiY();
const int dpiy = mPainter->device()->logicalDpiY();
const int margin = (int)((2/2.54)*dpiy); // 2 cm margins
return margin;
......@@ -277,8 +257,8 @@ int CrontabPrinter::computeMargin() const
int CrontabPrinter::computeStringHeight(const QString &text) const
{
const int fontHeight = d->painter->fontMetrics().height();
const int lines = d->painter->fontMetrics().boundingRect(text).width() / d->printView->width() + 1;
const int fontHeight = mPainter->fontMetrics().height();
const int lines = mPainter->fontMetrics().boundingRect(text).width() / mPrintView->width() + 1;
const int moveBy = (fontHeight + 2) * lines;
return moveBy;
......@@ -289,7 +269,7 @@ int CrontabPrinter::computeStringHeight(const QString &text) const
*/
bool CrontabPrinter::isPrintCrontab() const
{
return d->crontabPrinterWidget->printCrontab();
return mCrontabPrinterWidget->printCrontab();
}
/**
......@@ -297,12 +277,12 @@ bool CrontabPrinter::isPrintCrontab() const
*/
bool CrontabPrinter::isAllUsers() const
{
return d->crontabPrinterWidget->printAllUsers();
return mCrontabPrinterWidget->printAllUsers();
}
void CrontabPrinter::drawTable(const QList<int> &columnWidths)
{
d->painter->translate(0, -d->currentRowPosition + computeMargin());
mPainter->translate(0, -mCurrentRowPosition + computeMargin());
int columnWidthsTotal = 0;
for (int columnWidth : columnWidths) {
......@@ -312,33 +292,33 @@ void CrontabPrinter::drawTable(const QList<int> &columnWidths)
const int margin = computeMargin();
int linePositionX = margin;
QPen originalPen = d->painter->pen();
QPen originalPen = mPainter->pen();
QPen pen(originalPen);
pen.setWidth(1);
d->painter->setPen(pen);
mPainter->setPen(pen);
//First horizontal line
d->painter->drawLine(QPoint(margin, 0), QPoint(margin + columnWidthsTotal, 0));
mPainter->drawLine(QPoint(margin, 0), QPoint(margin + columnWidthsTotal, 0));
//Second horizontal line
d->painter->drawLine(QPoint(margin, 0+computeStringHeight(QStringLiteral(" "))), QPoint(margin + columnWidthsTotal, 0+computeStringHeight(QStringLiteral(" "))));
mPainter->drawLine(QPoint(margin, 0+computeStringHeight(QStringLiteral(" "))), QPoint(margin + columnWidthsTotal, 0+computeStringHeight(QStringLiteral(" "))));
//First vertical line
d->painter->drawLine(QPoint(linePositionX, 0), QPoint(linePositionX, d->currentRowPosition));
mPainter->drawLine(QPoint(linePositionX, 0), QPoint(linePositionX, mCurrentRowPosition));
for (int columnWidth : columnWidths) {
linePositionX += columnWidth;
d->painter->drawLine(QPoint(linePositionX, 0), QPoint(linePositionX, d->currentRowPosition));
mPainter->drawLine(QPoint(linePositionX, 0), QPoint(linePositionX, mCurrentRowPosition));
}
//Last horizontal line
d->painter->drawLine(QPoint(margin, d->currentRowPosition), QPoint(margin + columnWidthsTotal, d->currentRowPosition));
mPainter->drawLine(QPoint(margin, mCurrentRowPosition), QPoint(margin + columnWidthsTotal, mCurrentRowPosition));
d->painter->setPen(originalPen);
mPainter->setPen(originalPen);
d->painter->translate(0, d->currentRowPosition - computeMargin());
mPainter->translate(0, mCurrentRowPosition - computeMargin());
}
QList<int> CrontabPrinter::findMaxWidths(const QList<QStringList> &contents, int columnCount)
......@@ -351,7 +331,7 @@ QList<int> CrontabPrinter::findMaxWidths(const QList<QStringList> &contents, int
for (const QStringList &content : contents) {
int columnIndex = 0;
while (columnIndex < columnWidths.count()) {
const int valueWidth = d->painter->fontMetrics().boundingRect(content.at(columnIndex)).width();
const int valueWidth = mPainter->fontMetrics().boundingRect(content.at(columnIndex)).width();
if (columnWidths[columnIndex] < valueWidth) {
columnWidths[columnIndex] = valueWidth;
}
......@@ -368,7 +348,7 @@ QList<int> CrontabPrinter::findColumnWidths(const QList<QStringList> &contents,
QList<int> columnWidths = findMaxWidths(contents, columnCount);
int margin = computeMargin();
int pageWidth = d->painter->device()->width() - 2*margin;
int pageWidth = mPainter->device()->width() - 2*margin;
int columnWidthSum = 0;
for (int width : qAsConst(columnWidths)) {
......@@ -396,10 +376,10 @@ QList<int> CrontabPrinter::findColumnWidths(const QList<QStringList> &contents,
void CrontabPrinter::needNewPage()
{
const int margin = computeMargin();
if (d->currentRowPosition + margin >= d->printView->height()) {
if (mCurrentRowPosition + margin >= mPrintView->height()) {
printPageNumber();
d->printer->newPage();
d->page++;
d->currentRowPosition = 0;
mPrinter->newPage();
mPage++;
mCurrentRowPosition = 0;
}
}
src/crontabPrinter.h
View file @ 1a3eab7e
......@@ -19,7 +19,7 @@ class QString;
class CrontabWidget;
class CrontabPrinterPrivate;
class QPrinter;
/**
*Provides a wrapper for simple printing of text.
*/
......@@ -81,7 +81,24 @@ private:
QList<int> findMaxWidths(const QList<QStringList> &tasksContent, int columnCount);
QList<int> findColumnWidths(const QList<QStringList> &tasksContent, int columnCount);
CrontabPrinterPrivate *const d;
/**
* Pointer a printer options object
*/
CrontabPrinterWidget *mCrontabPrinterWidget = nullptr;
/**
* Pointer to parent widget
*/
CrontabWidget *mCrontabWidget = nullptr;
QPainter *mPainter = nullptr;
QPrinter *mPrinter = nullptr;
QRect *mPrintView = nullptr;
int mPage = 0;
int mCurrentRowPosition = 0;
};
#endif
src/crontablib/ctGlobalCron.cpp
View file @ 1a3eab7e
......@@ -28,7 +28,7 @@ CTGlobalCron::CTGlobalCron(CTHost *_ctHost)
d->userLogin = i18n("All users");
ctHost = _ctHost;
mCtHost = _ctHost;
}
CTGlobalCron::~CTGlobalCron()
......@@ -40,7 +40,7 @@ QList<CTTask *> CTGlobalCron::tasks() const
logDebug() << "Global Cron Tasks";
QList<CTTask *> tasks;
foreach (CTCron *cron, ctHost->crons) {
foreach (CTCron *cron, mCtHost->crons) {
if (cron->isSystemCron()) {
continue;
}
......@@ -57,7 +57,7 @@ QList<CTVariable *> CTGlobalCron::variables() const
logDebug() << "Global Cron Variables";
QList<CTVariable *> variables;
foreach (CTCron *cron, ctHost->crons) {
foreach (CTCron *cron, mCtHost->crons) {
if (cron->isSystemCron()) {
continue;
}
......@@ -74,7 +74,7 @@ void CTGlobalCron::addTask(CTTask *task)
{
logDebug() << "Global Cron addTask";
CTCron *actualCron = ctHost->findUserCron(task->userLogin);
CTCron *actualCron = mCtHost->findUserCron(task->userLogin);
actualCron->addTask(task);
}
......@@ -82,7 +82,7 @@ void CTGlobalCron::addVariable(CTVariable *variable)
{
logDebug() << "Global Cron addVariable";
CTCron *actualCron = ctHost->findUserCron(variable->userLogin);
CTCron *actualCron = mCtHost->findUserCron(variable->userLogin);
actualCron->addVariable(variable);
}
......@@ -90,7 +90,7 @@ void CTGlobalCron::modifyTask(CTTask *task)
{
logDebug() << "Global Cron modifyTask";
CTCron *actualCron = ctHost->findCronContaining(task);
CTCron *actualCron = mCtHost->findCronContaining(task);
/*
* actualCron could be NULL is the task came from clipboard because those tasks are never
......@@ -101,7 +101,7 @@ void CTGlobalCron::modifyTask(CTTask *task)
actualCron->removeTask(task);
}
CTCron *newCron = ctHost->findUserCron(task->userLogin);
CTCron *newCron = mCtHost->findUserCron(task->userLogin);
newCron->addTask(task);
}
}
......@@ -110,7 +110,7 @@ void CTGlobalCron::modifyVariable(CTVariable *variable)
{
logDebug() << "Global Cron modifyVariable";
CTCron *actualCron = ctHost->findCronContaining(variable);
CTCron *actualCron = mCtHost->findCronContaining(variable);
/*
* actualCron could be NULL is the task came from clipboard because those tasks are never
......@@ -121,7 +121,7 @@ void CTGlobalCron::modifyVariable(CTVariable *variable)
actualCron->removeVariable(variable);
}
CTCron *newCron = ctHost->findUserCron(variable->userLogin);
CTCron *newCron = mCtHost->findUserCron(variable->userLogin);
newCron->addVariable(variable);
}
}
......@@ -130,7 +130,7 @@ void CTGlobalCron::removeTask(CTTask *task)
{
logDebug() << "Global Cron removeTask";
CTCron *actualCron = ctHost->findCronContaining(task);
CTCron *actualCron = mCtHost->findCronContaining(task);
actualCron->removeTask(task);
}
......@@ -138,6 +138,6 @@ void CTGlobalCron::removeVariable(CTVariable *variable)
{
logDebug() << "Global Cron removeVariable";
CTCron *actualCron = ctHost->findCronContaining(variable);
CTCron *actualCron = mCtHost->findCronContaining(variable);
actualCron->removeVariable(variable);
}
src/crontablib/ctGlobalCron.h
View file @ 1a3eab7e
......@@ -46,7 +46,7 @@ public:
void removeTask(CTTask *task) override;
private:
CTHost *ctHost;
CTHost *mCtHost = nullptr;
};
#endif // CT_GLOBAL_CRON_H
src/crontablib/ctInitializationError.h
View file @ 1a3eab7e
......@@ -17,17 +17,17 @@ public:
QString errorMessage() const
{
return error;
return mError;
}
void setErrorMessage(const QString &errorMessage)
{
this->error = errorMessage;
this->mError = errorMessage;
}
bool hasErrorMessage()
{
if (error.isEmpty() == true) {
if (mError.isEmpty() == true) {
return false;
}
......@@ -35,7 +35,7 @@ public:
}
private:
QString error;
QString mError;
};
#endif // CT_INITIALIZATION_ERROR
src/crontablib/ctSaveStatus.h
View file @ 1a3eab7e
......@@ -17,37 +17,37 @@ public:
CTSaveStatus()
{
this->errorStatus = false;
this->mErrorStatus = false;
}
CTSaveStatus(const QString &errorMessage, const QString &detailErrorMessage)
{
this->errorStatus = true;
this->error = errorMessage;
this->detailError = detailErrorMessage;
this->mErrorStatus = true;
this->mError = errorMessage;
this->mDetailError = detailErrorMessage;
}
QString errorMessage() const
{
return error;
return mError;
}
QString detailErrorMessage() const
{
return detailError;
return mDetailError;
}
bool isError() const
{
return errorStatus;
return mErrorStatus;
}
private:
bool errorStatus;
bool mErrorStatus;
QString error;
QString mError;
QString detailError;
QString mDetailError;
};
#endif // CT_SAVE_STATUS
src/crontablib/cthost.cpp
View file @ 1a3eab7e
......@@ -28,7 +28,7 @@ CTHost::CTHost(const QString &cronBinary, CTInitializationError &ctInitializatio
{
struct passwd *userInfos = nullptr;
this->crontabBinary = cronBinary;
this->mCrontabBinary = cronBinary;
// If it is the root user
if (getuid() == 0) {
......@@ -166,7 +166,7 @@ bool CTHost::isDirty()
CTCron *CTHost::createSystemCron()
{
CTCron *p = new CTSystemCron(crontabBinary);
CTCron *p = new CTSystemCron(mCrontabBinary);
crons.append(p);
......@@ -181,7 +181,7 @@ QString CTHost::createCTCron(const struct passwd *userInfos)
}
CTInitializationError ctInitializationError;
CTCron *p = new CTCron(crontabBinary, userInfos, currentUserCron, ctInitializationError);
CTCron *p = new CTCron(mCrontabBinary, userInfos, currentUserCron, ctInitializationError);
if (ctInitializationError.hasErrorMessage()) {
delete p;
return ctInitializationError.errorMessage();
......
src/crontablib/cthost.h
View file @ 1a3eab7e
......@@ -110,7 +110,7 @@ private:
*/
bool allowDeny(char *name);
QString crontabBinary;
QString mCrontabBinary;
};
#endif // CTHOST_H
src/crontablib/cttask.cpp
View file @ 1a3eab7e
......@@ -19,7 +19,7 @@
#include "logging.h"