GitLab

Also decode it using the right encoding.

If ki18n >= 5.20.0 is available, use KLocalizedString::languages()
to get the list of configured languages for translations.
This fixes the lookup of translated content, such as TOCs, mirroring
what was done with commit 37bc9831fe097b01bb100f622ecd0ef19f77b80f in
kio.git.

- remove endl and '\n', since they are added automatically
- remove extra spaces
- remove extra quoting (done automatically for QString)
- raise some khcDebug to khcWarning, since they are not usual situations
- other general fixups

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

- remove the double QTreeWidget vs QTreeWidgetItem behaviour by using
  only items (including the root of the tree) as parents
- keep track of the items created for each DocEntry, and reuse them as
  parents when iterating on the children of the DocEntry's: properly
  mark temporary items as such, eventually removing only them when
  empty

As related change, pass only the SearchEngine and not the whole
SearchWidget, since there is no real need for it.

as a consequence of the changes above, remove the supporting API no more
needed in SearchWidget and ScopeItem.

Use Prefs::showMissingDocs() directly where needed.

It does not need to be a class member, and thus createChildrenList can
be static now.

There is a (undocumented) configuration key that switches the search
for any handler to a preset program. However, there are different issues
with it:
- letting handlers to create their indexes as needed, but then not using
  them, makes no sense -- my blind guess is in that far past some distro
  used this to integrate with their own system, but I cannot find more
  hints about that
- the common program seems to behave like a CGI
- the internal implementation is synchronously in a buggy way (cfr
  bug #158282)
- it has not been tested nor used for a decade

Hence, just drop this implementation.
BUG: 158282

This sort of reverts commit 1e349d94,
since DocInfo uses Prefs again.

- keep the whole list of current languages, and not only the first;
  this brings the behaviour as it was before the frameworks porting
- read the "pretty name" of languages only once and when needed,
  instead of batch reading the kf5_entry.desktop files for all the
  configured languages at startup

- switch to a simple enum value for its type
- get rid of the inner Observer class (and the related code), as it is
  not used at all (and it was not even working)

GIT_SILENT

Check for them earlier and only create the NavigatorAppItem in that
case, switching back to NavigatorItem for all the other kind of
"special" items.

Merge scrollkeeper.desktop into the .directory of the Scrollkeeper
directory, since a single item for it is enough: this allows us to
handle the scrollkeeper tree creation much like other "special" trees.

Also remove in ScrollKeeperTreeBuilder the need for the "after" item,
since all the subtrees can added to the right top-level item.

Make use of NavigatorAppItem where we might expect a TOC to be found,
like konqueror docs, KCM docs, and kioslave docs.

Turn a bit away from the URL-like representation of the scope list,
to not model the internals based on a CGI indexing/searching system.

- set the application name to "khelpcenter", so the correct metainfo
  dirs are read
- remove KAboutData usage, not needed
- use QByteArray for indentation in debug output
- avoid "..." in indentation strings

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

Move the TOC handling of NavigatorItem in a new NavigatorAppItem,
representing an application in the XDG menu.

This avoids the potential TOC generation also for other kind of
NavigatorItem subtypes, e.g. TOCItem: thus, (double-)clicking on a TOC
item will not try to spawn meinproc (failing) anymore.

Since it really represents a group of applications in the XDG menu,
give it a better fitting name; this frees the "NavigatorAppItem" name
for actual items representing applications.

Delay the expansion of a newly populated TOC tree of an application,
so it works properly.

QTreeWidgetItem::setExpanded is not virtual, so the reimplementation in
NavigatorItem will not be called when acting on a QTreeWidgetItem*
(and not on NavigatorItem*).
To make sure items are always notified when they are expanded/collapsed,
connect to the signals emitted by QTreeWidget, and call itemExpanded
(the former setExpanded implementation).  Feels like a kludge though.

Integrate the proposed text from bug #250956, thanks!
BUG: 250956

Dynamically show it when needed, so it's easier to place the shortcuts
of configurable actions.

Use a switch case to filter on the event type, so more type handlers
can be added later easily.

This is just code motion, with no actual behaviour change.

This way they can be properly identified also outside of the internal
handling, including as saved in bookmarks.

This requires to authorize redirections for glossentry URLs to help
ones, otherwise they cannot load the stylesheets.

Easy way to know the ID of a glossary entry.

Apparently unused, and it eases further modifications in Glossary.

Add a bookmark menu and all the internal machinery to handle bookmarks
using the KBookmarks framework.

BUG: 62925

There are different configuration settings read manually (i.e.
KSharedConfig + KConfigGroup) all over the place, which makes tracking
them a bit difficult; since there is a KConfigXT setup already, move
most of them there.

Improve the helper script for performing the search on man pages:
- pass the language and the search method (and/or) to it
- use an array to compose the command line of apropos
- pass the language to apropos
- if the search method is "and", pass --and to apropos (its default is
  like "or)
- split the search string by "+"; it is a kludge, but needed due to the
  internal handling of search in khelpcenter currently

BUG: 103265