Design decision: Make close button icons consistent
# The issue
Right now the `window-close` icon is a red circle with a white X in it, and we use it in many places outside of the window titlebar. This is problematic for two reasons:
- We use the red color for destructive actions, but closing is not an inherently destructive action. Ideally it never should be.
- It's visually inconsistent with windows' own close buttons, which are a black X (they turn into a red circle with a white X on hover, but that's a separate topic.
{width=600px}
However it a good thing for a significant reason: fanciness in notifications. Right now the circular timeout indicator hugs the Breeze icon and it looks very fancy.
The current situation is not ideal.
We have three options:
## 1. Use a black circle with a white X for all close icons:
This is implemented with https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/348
{width=600px}
## 2. Use a black X for all close icons and don't care that notifications' timeout indicators look a little bit odd
This is implemented with https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/349#note_1027178
{width=600px}
## 3. Use a black X for all close icons and then come up with a different way of showing notifications' timeout indicators
One example of an implementation is https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/4292:

# Desired outcome
I would like for us to try to select one of those three options.
# Facilitator
@linuxpusher
The discussion is beginning on 12 September 2024.
issue