lldb: port foreach -> range-based for

plugins/lldb/controllers/variable.cpp

@@ -80,7 +80,7 @@ void LldbVariable::formatChanged()
 {
     if(childCount())
     {
-        foreach(TreeItem* item, childItems) {
+        for (TreeItem* item : qAsConst(childItems)) {
             Q_ASSERT(qobject_cast<MIVariable*>(item));
             if (auto* var = qobject_cast<MIVariable*>(item)) {
                 var->setFormat(format());

plugins/lldb/debugsession.cpp

@@ -242,7 +242,8 @@ void DebugSession::configInferior(ILaunchConfiguration *cfg, IExecutePlugin *iex
     if (breakOnStart) {
         BreakpointModel* m = ICore::self()->debugController()->breakpointModel();
         bool found = false;
-        foreach (Breakpoint *b, m->breakpoints()) {
+        const auto breakpoints = m->breakpoints();
+        for (Breakpoint* b : breakpoints) {
             if (b->location() == QLatin1String("main")) {
                 found = true;
                 break;

plugins/lldb/unittests/test_lldb.cpp

@@ -1828,7 +1828,8 @@ void LldbTest::testDebugInExternalTerminal()
 {
     TestLaunchConfiguration cfg;
 
-    foreach (const QString & console, QStringList() << "konsole" << "xterm" << "xfce4-terminal" << "gnome-terminal") {
+    const QStringList consoles { "konsole", "xterm", "xfce4-terminal", "gnome-terminal" };
+    for (const QString& console : consoles) {
 
         if (QStandardPaths::findExecutable(console).isEmpty()) {
             continue;