GitLab

Left-over from 7002f69e (2008)

Summary:
Commit 9ec8eee2 had removed the custom
actions prev_error & next_error in favour of some global actions with
global shortcut, which would dynamically decide which result tool view to
apply the action (e.g. by shortcut) on. Two things were forgotten:

a) the plugin still installed a ui.rc file for those actions

b) The OutputWidget still tried to get the two actions by their id from
the plugin, to insert it into its own UI. Later the commit
fc8d34f0 also added generic actions to
the widget. As a result of the failing action fetching two warnings
QWidget::insertAction: Attempt to insert null action
were seen on the log.

This commit fixes both by removing the no longer useful code.

Test Plan:
Output widget still works WRT item navigation, both from main menu and from
toolview actions.

Reviewers: #kdevelop, kfunk

Reviewed By: #kdevelop, kfunk

Subscribers: kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D15432

Introspection data useful e.g. in debugging, so default to using it

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

*BSD seem to have catched up some years ago and dropped the need
for their custom O_NDELAY

Change done based on feedback from FreeBSD only, given no contact to
other *BSD currently

Summary:
Having a defined destruction order allows to make more assumptions
in other code referring to the widgets and avoids extra work to track
the addditional lifetime of the widget objects (like e.g. needed with
the KTextEditor::View widget objects, which require the
KTextEditor::MainWindow to exists as long as there is a View object).

With the Sublime::View and the QWidget objects both bound to the same
thread which is the UI objects thread by current design, there is also
no need to defer the deletion into the QWidget object thread.

Test Plan: Have been running this for more than a month, no issues seen.

Reviewers: #kdevelop, kfunk

Reviewed By: #kdevelop, kfunk

Subscribers: kfunk, kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D15198

Summary:
Not in use since many years (somewhere in 2007-2010, failed to determine
exact drop on non-empty string values)

Test Plan: Still builds.

Reviewers: #kdevelop, kfunk

Reviewed By: #kdevelop, kfunk

Subscribers: kdevelop-devel

Tags: #kdevelop

Differential Revision: https://phabricator.kde.org/D15199

Old Visual Studio versions were broken WRT concatenation of string
literals, VS 2017 has that fixed (and older versions no longer interesting)

Okay'ed by kfunk on irc

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

BUG: 398056

FIXED-IN: 5.2.80

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"

In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"