1. 20 Nov, 2018 4 commits
  2. 19 Nov, 2018 4 commits
  3. 17 Nov, 2018 3 commits
  4. 16 Nov, 2018 6 commits
    • Friedrich W. H. Kossebau's avatar
    • Friedrich W. H. Kossebau's avatar
      Merge branch '5.3' · 352ddbe7
      Friedrich W. H. Kossebau authored
      352ddbe7
    • Friedrich W. H. Kossebau's avatar
      Auto-find Clazy documentation also with clazy >= 1.4 · fee3dd68
      Friedrich W. H. Kossebau authored
      Summary:
      BUG: 401075
      FIXED-IN: 5.3.1
      
      Test Plan:
      Remove entries from kdeveloprc, paths are auto.detected both with
      clazy 1.4 and clazy 1.3 (well, its simulated doc path).
      
      Reviewers: #kdevelop, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: kfunk, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D16910
      fee3dd68
    • Friedrich W. H. Kossebau's avatar
      Disable plugin project config if project without a IBuildSystemManager dep · a3c782ac
      Friedrich W. H. Kossebau authored
      Summary:
      The Clazy plugin relies on the project providing a buildsystem manager
      to query for the toplevel build directory. If a project has no such manager,
      showing the Clazy plugin config pages in the project settings has no
      purpose.
      As a session might contain different projects, some with a buildsystem
      manager, some without, simply disabling the Clazy plugin might not be
      wanted for the projects with a buildsystem manager.
      So we need to have some condition whether to show some plugins per-project
      config pages or not.
      For a start, motivated by the crash with the Clazy plugin which has a
      hard assumption of project->buildSystemManager() being != nullptr,
      this patch adds to the code to collect the config pages for the project
      settings dialog some special code which makes use of the plugin metadata
      to skip plugins which require a org.kdevelop.IBuildSystemManager, if
      there is no buildsystem manager available for the project.
      As well adds the (so far missing) entry
      X-KDevelop-IRequired: [org.kdevelop.IBuildSystemManager]
      to the metadata.
      
      BUG: 400769
      
      Test Plan:
      Clazy config is no longer shown in the project settings dialog if the
      project is used with the generic project manager.
      
      Reviewers: #kdevelop, apol
      
      Reviewed By: #kdevelop, apol
      
      Subscribers: kfunk, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D16915
      a3c782ac
    • Kevin Funk's avatar
      Drop format.config.uncrustify.2_spaces · 11c7f9e9
      Kevin Funk authored
      11c7f9e9
    • Rolf Eike Beer's avatar
      tests: fix naming of test lines · 7b9572d3
      Rolf Eike Beer authored and Kevin Funk's avatar Kevin Funk committed
      (cherry picked from commit 2e82c3e5)
      7b9572d3
  5. 15 Nov, 2018 9 commits
  6. 14 Nov, 2018 2 commits
  7. 13 Nov, 2018 1 commit
  8. 04 Nov, 2018 4 commits
  9. 03 Nov, 2018 1 commit
  10. 31 Oct, 2018 4 commits
    • Friedrich W. H. Kossebau's avatar
      cmake: fix missing addition of policies to documentation index · c8847264
      Friedrich W. H. Kossebau authored
      Summary:
      Since cmake 3.0 cmake also supports --help-policy-list, matching the
      general --help* pattern. The KDevelop cmake documentation plugin
      already has an entry for "Policies", just it is not filled with any
      content.
      This patch extends the content indexing by also including the policy.
      For cmake < 3.0 the process CMakeCommandsContents::processOutput will
      catch the failing call by the exit code, and things are as before.
      
      Reviewers: #kdevelop, apol
      
      Reviewed By: #kdevelop, apol
      
      Subscribers: kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D15882
      
      (cherry picked from commit 2f0f3da7)
      c8847264
    • Bernd Buschinski's avatar
      808adc41
    • Bernd Buschinski's avatar
      FunctionDefinition: only look for (new/other) function definition if we don't have one · 3c51faa2
      Bernd Buschinski authored
      Summary:
      FunctionDefinition::definition always looks for FunctionDefinition based on the DeclarationId, but we don't need to do that if we already have a FunctionDefinition.
      This could cause problems if we have multiple (same) definitions.
      
      Test Plan:
      - create a small cmake (or whatever) project with 3 targets
      -- util1.c / util2.c / util3.c (same content):
      
      ```
      #include <stdio.h>
      #include <stdlib.h>
      
      void configure()
      {
          printf("do stuff in %s\n", __FILE__);
      }
      
      int main(int argc, char *argv[])
      {
          configure();
          puts("Hello, UTIL!");
          exit(EXIT_SUCCESS);
      }
      ```
      
      -- CMakeLists.txt:
      ```
      add_executable(util1 util1.c)
      add_executable(util2 util2.c)
      add_executable(util3 util3.c)
      ```
      
      - open util1.c
      - open the outline and select "configure"
      - EXPECTED: it should open the configure in util1.c (or the currently opened file)
      - repeat with util2 and util3
      - ACTUAL: only one of them works, the other two point to the wrong file.
      
      Reviewers: #kdevelop, mwolff
      
      Reviewed By: #kdevelop, mwolff
      
      Subscribers: mwolff, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D16356
      3c51faa2
    • Bernd Buschinski's avatar
      Fix memleaks in duchain unittests · c3c30113
      Bernd Buschinski authored
      Summary:
      The TypeSystem::create test was changed as now the destruction is also taken into account for QBENCHMARK
      
      The TopDUContext dtor is protected, however you can execute
      delete TopDUContext; but it will NOT call the protected TopDUContext dtor but the public DUContext dtor.
      
      Test Plan:
      - compile kdevelop unitest with ASAN&LSAN
      - execute test_duchain
      
      Reviewers: #kdevelop, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: kfunk, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D16458
      c3c30113
  11. 28 Oct, 2018 2 commits