1. 17 Aug, 2018 2 commits
  2. 16 Aug, 2018 2 commits
  3. 15 Aug, 2018 14 commits
  4. 14 Aug, 2018 4 commits
    • Sven Brauch's avatar
      Set version number to 5.2.80 · aa167a2d
      Sven Brauch authored
    • Bernd Buschinski's avatar
    • Bernd Buschinski's avatar
      Fix last > rowCount() assert in ClassModel Node dtor · 04f522f5
      Bernd Buschinski authored
      This patch fixes another assert in the classmodel.
      This time it is the assert triggered from
      Node::~Node -> ClassModel::nodesAboutToBeRemoved -> QAbstractItemModel::beginRemoveRows(index, first, last)
      last > rowCount(), last was greater than the rowCount.
      This is because in Node::removeNode the child was first removed from the childrenlist and then deleted.
      But createIndex() & rowCount() rely on the item to still be in the model/list. Node::row() would simply return -1 which would result in an invalid index.
      rowCount for invalid index < last Item
      The solution is simple, like in Node::clear(), first delete the item and then remove it from the list.
      Test Plan:
      - compile Qt 5.11.1 with debug&asserts enabled
      - compile kdevelop against this version of Qt
      - start kdevelop and open a project
      - open the Classes toolview
      - expand & collapse some items
      -> assert/crash
      Reviewers: #kdevelop, brauch
      Reviewed By: #kdevelop, brauch
      Subscribers: brauch, kdevelop-devel
      Tags: #kdevelop
      Differential Revision: https://phabricator.kde.org/D14840
    • Gleb Popov's avatar
      Use "gmake" command in custommake plugin on FreeBSD. Fixes unit test. · bbcf0cfa
      Gleb Popov authored
      Reviewers: #kdevelop
      Subscribers: kdevelop-devel
      Tags: #kdevelop
      Differential Revision: https://phabricator.kde.org/D14731
  5. 13 Aug, 2018 11 commits
  6. 11 Aug, 2018 3 commits
  7. 10 Aug, 2018 4 commits