1. 26 Jun, 2019 1 commit
  2. 20 Nov, 2018 1 commit
  3. 25 Oct, 2018 1 commit
  4. 18 Jun, 2018 1 commit
    • Christoph Roick's avatar
      Reenable navigation inside QtDocumentation · 4e02a129
      Christoph Roick authored
      Summary:
      - updating a web page using `QtWebEnginePage::load()`
        in `StandardDocumentationView`does not seem to work for the
        Qt documentation pages and only using a new widget does the job
      - adding a url to the documentation history when showing a page now
        is the default, which reverts 3f7a93af
      - requires similar changes in kdev-php
      
      BUG 393445
      
      Test Plan:
      - navigate in Qt documentation between different classes (QString->QChar for example)
      - navigate in manpages
      - navigate in PHP documentation (with changes applied to kdev-php)
      
      Reviewers: apol
      
      Reviewed By: apol
      
      Subscribers: apol, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D12793
      4e02a129
  5. 13 Oct, 2017 1 commit
    • Kevin Funk's avatar
      Revert "Don't set up DocumentationViews when shutting down" · 173964fb
      Kevin Funk authored
      Several issues:
      a) unreviewed
      b) returning inside a constructor is bad habit, as it may leave the
      class instance half-initialized
      c) the fix is at the wrong location, the DocumentationView ctor should
      not be called in the first place => find out *when* it is being called
      during shutdown (=> put breakpoint on DocumentationView() in gdb, lldb)
      
      This reverts commit 4b4806d0.
      173964fb
  6. 12 Oct, 2017 1 commit
    • René J.V. Bertin's avatar
      Don't set up DocumentationViews when shutting down · 4b4806d0
      René J.V. Bertin authored
      In rare situations a DocumentationView can be created when shutting
      down, which can lead to race conditions and crashing. Prevent this by
      returning early from the class ctor when shutdown is in progress.
      
      In addition, prevent errors from QWidget::setTabOrder() by checking its
      input arguments.
      
      BUG: 385640
      4b4806d0
  7. 04 Oct, 2017 1 commit
    • Friedrich W. H. Kossebau's avatar
      Always create Documentation tool view, fix it to work with no providers · 781bb47c
      Friedrich W. H. Kossebau authored
      Summary:
      Creating the Documentation tool view at DocumentationController
      initialization time only if the list returned by documentationProviders() is
      non-empty has some flaws:
      1) The QtHelp plugin delays initialization to after reaching the event loop.
      So if it is the only documentation provider (provider) plugin activated, it
      will return 0 providers in the beginning.
      2) It ignores the option that users can enable another documentation provider plugin
      at runtime.
      3) There is also no code for removing the tool view in case the user
      disables any documentation providers at runtime.
      4) It ignores the option of plugins like the QtHelp one allowing the user to
      disable any documentation providers at runtime.
      
      This patch always creates the toolview instead of magically creating/removing it
      automatically based on documentation provider availability and leaves it to
      the user to add or remove it as they prefer.
      
      It also prepares the Documentation tool view to properly handle the case of
      no documentation providers available (done in a way to keep the current public
      API).
      
      BUG: 383875
      FIXED-IN: 5.2.0
      
      Reviewers: #kdevelop, apol
      
      Reviewed By: #kdevelop, apol
      
      Subscribers: kdevelop-devel
      
      Differential Revision: https://phabricator.kde.org/D8140
      781bb47c
  8. 29 Sep, 2017 1 commit