1. 03 Jul, 2019 1 commit
  2. 21 Jun, 2019 1 commit
  3. 20 Nov, 2018 1 commit
  4. 25 Oct, 2018 1 commit
  5. 15 Sep, 2018 1 commit
    • Anton Anikin's avatar
      Fix segfaults in OutputWidget · f856a9a6
      Anton Anikin authored
      Summary:
      This patch fixes regressions provided by D14931.
      
      Steps to reproduce (my system is neon/bionic with Qt 5.11.1 and KDevelop/master):
      
      1) Start KDevelop and load some project
      2) Start project build
      3) Close KDevelop
      4) Segfault happens
      
      Main problems:
      
      1) Incorrect signal processing. `OutputWidget::updateFilter()` slot is called from parent's destructor when `m_tabwidget`/`m_stackwidget` is deleted so we have destroyed `m_views` hash and segfault as a result.
      
      2) Incorrect `QSharedPointer` usage. All handled objects have `QWidget` as a parent so we have double-free problem and and segfault as a result.
      
      BUG: 398615
      
      Test Plan: Tested on different output widgets (`KDevelop::IOutputView::OneView/HistoryView/MultipleView`) with no segfaults. All our `QTreeView`/`QSortFilterProxyModel` objects are deleted (no memory leaks).
      
      Reviewers: #kdevelop, kossebau
      
      Reviewed By: #kdevelop, kossebau
      
      Subscribers: kfunk, kossebau, vkorneev, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D15326
      f856a9a6
  6. 11 Sep, 2018 1 commit
    • Friedrich W. H. Kossebau's avatar
      [StandardOutputView] Remove dead & broken code for prev_error/next_error · 4378163c
      Friedrich W. H. Kossebau authored
      Summary:
      Commit 9ec8eee2 had removed the custom
      actions prev_error & next_error in favour of some global actions with
      global shortcut, which would dynamically decide which result tool view to
      apply the action (e.g. by shortcut) on. Two things were forgotten:
      
      a) the plugin still installed a ui.rc file for those actions
      
      b) The OutputWidget still tried to get the two actions by their id from
      the plugin, to insert it into its own UI. Later the commit
      fc8d34f0 also added generic actions to
      the widget. As a result of the failing action fetching two warnings
      QWidget::insertAction: Attempt to insert null action
      were seen on the log.
      
      This commit fixes both by removing the no longer useful code.
      
      Test Plan:
      Output widget still works WRT item navigation, both from main menu and from
      toolview actions.
      
      Reviewers: #kdevelop, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D15432
      4378163c
  7. 04 Sep, 2018 1 commit
    • Vyacheslav Korneev's avatar
      Fix double delete bug in OutputWidget · 7b2e5e40
      Vyacheslav Korneev authored
      Summary:
      The bug was unfortunately introduced in D14931 by me - two shared pointers
      were created from the same raw pointer. Eliminated it by using QSharedPointer
      as a return value from view creation helper lambda.
      
      Test Plan:
      The bug can be triggered only in IOutputView:OneView widget mode, which is (as
      far as I can see) currently neither used, nor properly tested. Planning to change
      this in following patches.
      
      Reviewers: kfunk, kossebau
      
      Reviewed By: kfunk
      
      Subscribers: anthonyfieroni, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D15241
      7b2e5e40
  8. 02 Sep, 2018 1 commit
    • Vyacheslav Korneev's avatar
      Eliminate duplicate QMaps in OutputWidget · 252482d1
      Vyacheslav Korneev authored
      Summary:
      There were 3 QMaps with identical keys used for storing corresponding
      view, proxy model and filter. In this version only one map is used - this
      reduces the amount of map lookups and potential mistakes during code
      changes.
      
      Test Plan:
      This patch isn't supposed to change any behavior in OutputWidget, so we
      need to assure that OutputWidget works as usually. For example:
      create a few outputs;
      enter the filters for some of the outputs;
      choose random output;
      close all other outputs;
      check if the output is shown, filter corresponds to output, etc;
      repeat previous actions a few times.
      
      Reviewers: #kdevelop, kfunk
      
      Reviewed By: #kdevelop, kfunk
      
      Subscribers: anthonyfieroni, aaronpuchert, kfunk, pino, kdevelop-devel
      
      Tags: #kdevelop
      
      Differential Revision: https://phabricator.kde.org/D14931
      252482d1
  9. 17 Aug, 2018 1 commit
  10. 16 Aug, 2018 1 commit
  11. 15 Aug, 2018 1 commit
    • Friedrich W. H. Kossebau's avatar
      Generate strings with lists by collecting items, then use QSL::join() · 835b1164
      Friedrich W. H. Kossebau authored
      Saves memory reallocations and copying on every appending to the string
      collecting the result, once for the item and once for some possible
      separator.
      
      Ideally we would just reserve enough space in the target string and
      append the new content in there directly. But that requires knowning the
      final size in advance or the maximal possible, so the
      835b1164
  12. 05 Mar, 2018 1 commit
    • Anton Anikin's avatar
      UI improvement - add expandable line edit widget · 236950e9
      Anton Anikin authored
      Summary:
      The patch adds custom line edit widget which tries to expand its width to fit typed text. New widget is used by problemreporter and standardoutputview plugins to improve usability - old versions uses standard line edits with fixed size which is not comfortable for cases when we type long search string.
      
      Old version:
      {F5721229}
      
      New version:
      {F5721234}
      
      Reviewers: #kdevelop, brauch
      
      Reviewed By: #kdevelop, brauch
      
      Subscribers: brauch, apol, broulik, kdevelop-devel
      
      Differential Revision: https://phabricator.kde.org/D10705
      236950e9
  13. 13 Sep, 2017 1 commit