Tom Moebert (4f39d0b4) at 26 Nov 13:50
No Bernhard, you can't replace a long with an unsigned integer!
Tom Moebert (6b325cd4) at 04 Nov 10:41
Disable deprecated since
Tom Moebert (0b24222c) at 04 Nov 10:41
Disable deprecated since
Tom Moebert (20bdb0b6) at 31 Oct 11:46
Remove pointless qt5compat
Tom Moebert (fc41df2b) at 29 Oct 14:25
Merge remote-tracking branch 'upstream/master' into qt6
... and 12 more commits
Tom Moebert (94e8336a) at 29 Oct 13:17
Fix build for old ecm
Tom Moebert (68e97fb6) at 16 Sep 14:40
Merge remote-tracking branch 'upstream/master' into exception-handling
... and 62 more commits
Wow, there are 5 people linked here and nobody feels responsible for merging an approved PR. In 2020 I have already made a bad experience with a simple PR for kexiv2. I wanted to give it another try, because I thought, I was too impatient back then. But I see, nothing has changed. Just keep on merging your own PRs and ignoring other ones. I have a couple of fixes and improvements for kexiv2 and kdcraw. I'll keep them in my forks now. I compiled kio with Qt6 for Windows and came across so many problems in various depending projects. But I'll keep the patches for vcpkg only. I really cannot believe, that I was one year younger when I faced this issued and opened the PR. It's pointless. I'm done.
Previously, when holding the SHIFT key while clicking two items in the view, only items which intersected the "selection rectangle" were selected. However, the documentation of QAbstractItemView::ExtendedSelection says:
"If the user presses the Shift key while clicking on an item, all items between the current item and the clicked item are selected or unselected..."
This change fixes this behaviour by respecting the view's state(). You can test this behaviour with the kcategorizedviewtest.
Previously, when holding the SHIFT key while clicking two items in the view, only items which intersected the "selection rectangle" were selected. However, the documentation of QAbstractItemView::ExtendedSelection says:
"If the user presses the Shift key while clicking on an item, all items between the current item and the clicked item are selected or unselected..."
This change fixes this behaviour by respecting the view's state(). You can test this behaviour with the kcategorizedviewtest.
Tom Moebert (30654781) at 30 Apr 19:37
Fix SHIFT selection behaviour in KCategorizedView
... and 15 more commits
There is not a single unit test for the entire KCategorizedView class. You guys only have this manual test application kcategorizedviewtest.cpp
, which I have changed appropriately. And I don't see a reason to start unit testing this class for a piece of code that hasn't been changed for >8 years. Also, testing this automatically would probably involve mocking key and/or mouse events. I don't think it's worth the hassle, sry.
Is anyone ever going to merge this?!
Tom Moebert (ebe0b0db) at 21 Apr 11:50
Stop useless and expensive deep-copies of ExifData
Tom Moebert (deda4001) at 27 Mar 18:50
Don't hardcode SHARED
Tom Moebert (d85d42f6) at 27 Mar 18:50
Don't hardcode SHARED
Tom Moebert (5766af3f) at 20 Mar 10:16
Disable install, KDE_INSTALL_INCLUDEDIR_KF5 is empty for some reason
Tom Moebert (9ed87c6c) at 20 Mar 10:16
Disable install, KDE_INSTALL_INCLUDEDIR_KF5 is empty for some reason
Tom Moebert (b2526805) at 20 Mar 10:12
Use PROJECT_SOURCE_DIR