Commit 853e42fd authored by Wolthera van Hövell's avatar Wolthera van Hövell 🛍

Uncheck 'embed profile' by default.

It seems we cannot rely on Firefox and ColorD to manage sRGB images as sRGB images with a regular bog-standard sRGB profile. This is shown previously by an experiment with a PNG that has an sRGB chunk, and a png that has a sRGB profile looking exactly as distorted in Firefox. It is a pity that we have to encourage our users not to embed sRGB profile, but as long as something as simple as showing an sRGB image as an sRGB image(which yes, dear commit message reader, is the same as doing exactly nothing with it) is too complicated for other programs, it cannot be helped.

CCBUG:367832
parent be0f07c4
......@@ -154,7 +154,11 @@ KisImportExportFilter::ConversionStatus KisPNGExport::convert(const QByteArray&
wdg->bnTransparencyFillColor->setEnabled(!wdg->alpha->isChecked());
wdg->chkSRGB->setEnabled(sRGB);
//This used to be 'setEnabled(sRGB)' but firefox and ColorD are incredibly awkward about sRGB management
//on Linux devices, as indicated by the same distorted colours with using the sRGB chunk, meaning it's unrelated to the profile.
//We can somewhat assume sRGB is the default color space for the web, but it's still a darn pity we cannot rely on firefox and colord
//to manage sRGB-marked images properly.
wdg->chkSRGB->setEnabled(!sRGB);
wdg->chkSRGB->setChecked(cfg.getBool("saveSRGBProfile", true));
wdg->chkForceSRGB->setEnabled(!sRGB);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment