1. 04 Jan, 2012 3 commits
  2. 03 Jan, 2012 5 commits
  3. 02 Jan, 2012 14 commits
    • Sven Langkamp's avatar
      don't do anything if there is no current node · 8f089713
      Sven Langkamp authored
      BUG:290402
      8f089713
    • Thorsten Zachmann's avatar
      Fix whitespace handling in xml loading · f7883c7b
      Thorsten Zachmann authored
      This changes the xml loading to no longer strip whitespace. This fixes one of the
      problems attached to the bug report where there is a text node with only a space
      e.g. <text:line-break/> <text:s/>2 space.
      This change uncovered some problems where white space was not handled properly:
      anchors and line-breaks in filters, frame element loading in libs.
      It also fixes saving of line-break to use the correct tag instead of the QChar::LineSperator as char.
      Also whitespace handling after tabs, bookmark-ref and when variables are used have been fixed.
      
      REVIEW: 103568
      
      BUG: 290091
      f7883c7b
    • Dmitry Kazakov's avatar
      Removed blocking signals from the KisImageSignalRouter · ef487ff7
      Dmitry Kazakov authored
      Currently, there is a quite annoying limitation: we cannot add/remove/move
      layers from the context of the scheduler's thread. We can do it only from
      the UI thread. It means that the actions, which work with nodes' position
      should work using legacy undo adapter.
      
      Here is an explanation of the problem
      (from KisImageSignalRouter::emitAboutToAddANode):
      
      Some of the users of our signals rely on the fact that the
      signals are emitted synchronously from the same thread. Such
      users are KisNodeModel, KisShapeController. They request the
      data of the signal right from the node data, so these signals cannot
      be emitted asynchronously. We cannot use BlockingQueued
      connections here, because the we'll get a deadlock when UI
      will decide to wait for scheduler to finish it's job.
      That is why we explicitly check that no nodes are added,
      removed or moved from the context of the scheduler thread.
      Currently we have no other way than to assert in such a case.
      So all the node modifications should be done using legacy
      undo adapter, in the context of the UI thread.
      ef487ff7
    • Dmitry Kazakov's avatar
      Fix compilation · 047e3889
      Dmitry Kazakov authored
      047e3889
    • Boudewijn Rempt's avatar
      232cb5b1
    • Boudewijn Rempt's avatar
      assignImageProfile should not create commands · 16f6b255
      Boudewijn Rempt authored
      As the apidox already made clear (but it's even clearer now) this method
      is for setting the profile on an image during creation or loading. At
      that time, undo commands are not needed and can be dangerous because
      they lead to a projection update.
      16f6b255
    • Boudewijn Rempt's avatar
      Remove the unused and unusable gray without alpha colorspaces · 8c270acd
      Boudewijn Rempt authored
      Pigment cannot use colorspaces without an alpha channel, it doesn't
      support premultiplied alpha at all.
      8c270acd
    • Boudewijn Rempt's avatar
    • Boudewijn Rempt's avatar
      Make the global selection a mask on the rootlayer · 7c3ef1aa
      Boudewijn Rempt authored
      This way, the selection will be cropped, resized etc. together with
      the other nodes. It will also make it possible in the future to use the
      paint/fill/gradient/filter tools on the selection.
      
      CCBUG:273260
      7c3ef1aa
    • Boudewijn Rempt's avatar
      Make the global selection manipulations methods private · 0b4c60d9
      Boudewijn Rempt authored
      These may only be used by the relevant command classes (and one
      unittest)
      0b4c60d9
    • Boudewijn Rempt's avatar
      rename two enums · f3903d8a
      Boudewijn Rempt authored
      Enums used to start in Krita with a lower-case enum prefix. That we
      stopped doing, but we should always initcap the enum's name since an
      enum is a type.
      f3903d8a
    • Boudewijn Rempt's avatar
      Update select by colorrange to make it work with transactions · 16a90183
      Boudewijn Rempt authored
      After the previous refactoring, the colorrange dialog used setGlobalSelection
      directly and destructively, making undo impossible. This fixes that
      problem.
      
      Also:
      
      * remove the preview window, which is a relic from 1.x days in these
      days of on-canvas preview
      * make select opaque work on all nodes, not just layers.
      16a90183
    • Boudewijn Rempt's avatar
      Use the selection's projection outline · c6556056
      Boudewijn Rempt authored
      Instead of having two sepeparate outline objects, one for the shape
      and one for the pixel selection, use the projection to determine the
      outline of the complete selection.
      c6556056
    • Boudewijn Rempt's avatar
      Remove unused method · 363c30bd
      Boudewijn Rempt authored
      363c30bd
  4. 01 Jan, 2012 3 commits
  5. 31 Dec, 2011 8 commits
  6. 30 Dec, 2011 5 commits
  7. 29 Dec, 2011 2 commits
    • Lukáš Tvrdý's avatar
      Add unit-test for upscaling · ccd85824
      Lukáš Tvrdý authored
      Bug is detected by asserts and by
      checking the size of scaled device.
      ccd85824
    • Lukáš Tvrdý's avatar
      Fix artefacts when upscaling · 02671608
      Lukáš Tvrdý authored
      o overflow in arithemthics caused opaque
        pixels, might fix crashes for scaling for MSVC compiler
      o removed alias variable
      o fix coding style: add braces to single-line if conditions
      o add asserts to catch overflows
      
      BUG:262324
      02671608