GitLab

Seriously, tell me it's not a little ridiculous that
QCoreApplication::applicationDirPath() would be dropped from
QCoreApplication::libraryPaths().

Summary: This seems almost finished, but I'm stuck. I create an installer successfully but get a "windows platform plugin not found" error on the target machine.

Reviewers: rempt

Differential Revision: https://phabricator.kde.org/D506

This fixes some names and some TRCs.

Resolves T1039

This reverts commit e823974b.

When switching documents KisNodeModel::m_d::parentOfRemovedNode was
still pointing to an old (probably removed node dummy), which
obviously caused a crash on the next layer selection

BUG:354975

Without openGL animation will work very slow, because there is no (!)
caching at all, but at least it can show something for people with
faulty GPUs.

See a comment in KisAnimationPlayer::slotCancelPlaybackSafe()

BUG:355020

This way they will always be found and won't clutter up the install
directory with stuff that never changes.

To quote the cmake manual:

"Policy CMP0042 was introduced to change the default value of
MACOSX_RPATH to ON. This is because use of @rpath is a more flexible
and powerful alternative to @executable_path and @loader_path."

And whenever something is flexible and powerful, you can bet there
are too many ways of doing things and that it'll take days or weeks
to get things working again.

This change explicitly sets the rpaths both for running krita on OSX
after doing a make install and for running krita from a bundle. There
may be some redundancy here and it is still not enough. Macdeployqt
doesn't pick up the location of the libraries and start looking in
/Libraries/Frameworks for the Qt frameworks. So either we can add
a #{CMAKE_INSTALL_PREFIX}/lib to the properties here, or fix that in
the deploy script. For now, I'm doing the latter and running
macdeployqt like this:

rm -rf ~/kf5/krita.app/
rm -rf ~/kf5/krita.dmg
cp -r ~/kf5/i/bin/krita.app ~/kf5
cp -r ~/kf5/i/share ~/kf5/krita.app/Contents/
mkdir -p ~/kf5/krita.app/Contents/PlugIns/krita
install_name_tool -add_rpath /Users/boudewijnrempt/kf5/i/lib ~/kf5/krita.app/Contents/MacOS/krita
macdeployqt ~/kf5/krita.app \
    -verbose=0 \
    -executable=/Users/boudewijnrempt/kf5/krita.app/Contents/MacOS/krita \
    -extra-plugins=/Users/boudewijnrempt/kf5/i/lib/krita/ \
    -extra-plugins=/Users/boudewijnrempt/kf5/i/lib/plugins/ \
    -extra-plugins=/Users/boudewijnrempt/kf5/i/plugins/
mv ~/kf5/krita.app/Contents/PlugIns/*so ~/kf5/krita.app/Contents/PlugIns/krita
install_name_tool -delete_rpath  @loader_path/../../../../lib ~/kf5/krita.app/Contents/MacOS/krita
install_name_tool -delete_rpath  /Users/boudewijnrempt/kf5/i/lib ~/kf5/krita.app/Contents/MacOS/krita

We don't have an api for developing plugins outside the krita tree
at the moment, so don't clutter the install dir

We cannot handle the crash dumps from breakpad anymore, and breakpad
hasn't been built for a year or so, so get rid of it for now.