- 09 Jul, 2019 8 commits
-
-
Sharaf Zaman authored
Maniphest: T10784
-
Halla Rempt authored
Because otherwise krita will just seem to crash.
-
Halla Rempt authored
This is not a fatal error, and we should be able to load files we saved in a broken way.
-
Halla Rempt authored
On loading an exr, we check whether the exr layername and the krita layername are the same with a safe assert, so we probably should make sure of that when saving as well.
-
Halla Rempt authored
-
Ivan Yossi authored
BUG:396158
-
Script Kiddy authored
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
-
Script Kiddy authored
-
- 08 Jul, 2019 4 commits
-
-
Agata Cacko authored
Before this commit this action would mirror them vertically. (It's under Layer -> Transform All Layers -> menu entry)
-
Halla Rempt authored
-
Dmitry Kazakov authored
OpenGL 2.1 systems are supported, but Small Colro Selector is not available for them, because it doesn't have legacy shaders (needs to be implemented). CCBUG:408872
-
Agata Cacko authored
Before this commit if you first selected the color model, then color profile, then color depth, the color profile would switch to default for this color depth no matter that the user just set it manually. This is mostly the problem if someone is for example using Rec2020 profile for HDR images and switches between 32 and 16 bit color depths. Behaviour now: - by default color profile changes to the default one that suits the color model and color depth - if the user sets the profile manually, it is remembered and if it changes color depth, the profile doesn't change (keep in mind that "(Default)" suffix is still attached to the default profile, so it's easy to find in case the user wants it - if the user changes the color model, the default behaviour (switching profile automatically) is restored until the user sets up the profile maually again. BUG:406700
-
- 06 Jul, 2019 13 commits
-
-
Dmitry Kazakov authored
They cause artifacts and we don't have a fix yet :( CCBUG:404133 Note from the committer: This commit was initially made on krita/4.2 branch. However between 4.2.1 and 4.2.2 the stable branch was reconstructed, which caused all commits that were exclusively on the previous krita/4.2 (and not on master) to be missing. The previous commit hash: d3e4c3aa Also regarding the artifacts: it never worked, optimization were enabled during the creamy flow implementation, but they never should be enabled until someone fix them properly.
-
Tusooa Zhu authored
ShapeGroupContainerModel::remove() will call KoShapeGroup::invalidateSizeCache(), even when the shape group is going to be destroyed. This method is called after KoShapeGroup's destructor, so at this time we no longer have access to members of KoShapeGroup, i.e. its d-pointer. So this call will cause access violation as the instance `QScopedPointer<Private> d` in KoShapeGroup has already been destroyed. This is a result of getting rid of derived d-pointers, because if we use a derived d-pointer, it only gets destroyed in the ancestor class (KoShape). We temporarily fix this problem by manually call `model()->deleteOwnedShapes()` in KoShapeGroup's destructor.
-
Halla Rempt authored
CCMAIL:tusooa@vista.aero
-
Halla Rempt authored
This fixes a crash when pressing cancel when you're trying to create a RGB8 linear gamma image, which shouldn't be possible.
-
Tusooa Zhu authored
The class KisSharedDescendent used to be employed to wrap up derived d-pointers, but since we have already refactored them out, there is no reason to keep them now.
-
Tusooa Zhu authored
-
Tusooa Zhu authored
KoImageData was explicitly shared, and the implicit sharing breaks TestImageCollection
-
Tusooa Zhu authored
-
Tusooa Zhu authored
-
Tusooa Zhu authored
-
Tusooa Zhu authored
-
Tusooa Zhu authored
These two class templates are used to store any subclass of a base class. KisSharedDescendent is also inherited from QSharedData, and its use for copy-on-write is documented in the comments.
-
Tusooa Zhu authored
-
- 05 Jul, 2019 8 commits
-
-
Dmitry Kazakov authored
-
Halla Rempt authored
-
Halla Rempt authored
The KisNodeModelTest didn't set the image it was testing with on the document. This broke in KisShapeController::setImage(KisImageWSP image), which cleared all connections, then didn't use the image parameter but the local doc's image object (which is 0) to reconnect the signals/slots, and which then crashed in KisShapeController::slotUpdateDocumentResolution(), where the image would still be 0. Howewever, the question is: should this function even have this parameter? If so, should the image then be set on the doc? Should this function even exist since it makes it possible to have a local m_doc->image() that is different from the image parameter? There are still a bunch of warnings, too. boud@boud-ThinkPad-T470p:~/dev/b-krita/libs/ui/tests$ ./kis_node_model_test ********* Start testing of KisNodeModelTest ********* Config: Using QtTest library 5.12.3, Qt 5.12.3 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 7.4.0) PASS : KisNodeModelTest::initTestCase() QWARN : KisNodeModelTest::testSetImage() KoColor debug runtime checks are active. PASS : KisNodeModelTest::testSetImage() QWARN : KisNodeModelTest::testAddNode() SAFE ASSERT (krita): "!newNode->parent()" in file /home/boud/dev/krita/libs/image/kis_node.cpp, line 500 QWARN : KisNodeModelTest::testAddNode() SAFE ASSERT (krita): "!newNode->parent()" in file /home/boud/dev/krita/libs/image/kis_node.cpp, line 500 QWARN : KisNodeModelTest::testAddNode() SAFE ASSERT (krita): "!newNode->parent()" in file /home/boud/dev/krita/libs/image/kis_node.cpp, line 500 QWARN : KisNodeModelTest::testAddNode() SAFE ASSERT (krita): "!newNode->parent()" in file /home/boud/dev/krita/libs/image/kis_node.cpp, line 500 QWARN : KisNodeModelTest::testAddNode() SAFE ASSERT (krita): "!newNode->parent()" in file /home/boud/dev/krita/libs/image/kis_node.cpp, line 500 PASS : KisNodeModelTest::testAddNode() QWARN : KisNodeModelTest::testRemoveAllNodes() SAFE ASSERT (krita): "!newNode->parent()" in file /home/boud/dev/krita/libs/image/kis_node.cpp, line 500 QWARN : KisNodeModelTest::testRemoveAllNodes() SAFE ASSERT (krita): "!newNode->parent()" in file /home/boud/dev/krita/libs/image/kis_node.cpp, line 500 QWARN : KisNodeModelTest::testRemoveAllNodes() SAFE ASSERT (krita): "!newNode->parent()" in file /home/boud/dev/krita/libs/image/kis_node.cpp, line 500 QWARN : KisNodeModelTest::testRemoveAllNodes() SAFE ASSERT (krita): "!newNode->parent()" in file /home/boud/dev/krita/libs/image/kis_node.cpp, line 500 QWARN : KisNodeModelTest::testRemoveAllNodes() SAFE ASSERT (krita): "!newNode->parent()" in file /home/boud/dev/krita/libs/image/kis_node.cpp, line 500 PASS : KisNodeModelTest::testRemoveAllNodes() QWARN : KisNodeModelTest::testRemoveIncludingRoot() SAFE ASSERT (krita): "!newNode->parent()" in file /home/boud/dev/krita/libs/image/kis_node.cpp, line 500 QWARN : KisNodeModelTest::testRemoveIncludingRoot() SAFE ASSERT (krita): "!newNode->parent()" in file /home/boud/dev/krita/libs/image/kis_node.cpp, line 500 QWARN : KisNodeModelTest::testRemoveIncludingRoot() SAFE ASSERT (krita): "!newNode->parent()" in file /home/boud/dev/krita/libs/image/kis_node.cpp, line 500 QWARN : KisNodeModelTest::testRemoveIncludingRoot() SAFE ASSERT (krita): "!newNode->parent()" in file /home/boud/dev/krita/libs/image/kis_node.cpp, line 500 QWARN : KisNodeModelTest::testRemoveIncludingRoot() SAFE ASSERT (krita): "!newNode->parent()" in file /home/boud/dev/krita/libs/image/kis_node.cpp, line 500 PASS : KisNodeModelTest::testRemoveIncludingRoot() PASS : KisNodeModelTest::cleanupTestCase() Totals: 6 passed, 0 failed, 0 skipped, 0 blacklisted, 1597ms ********* Finished testing of KisNodeModelTest *********
-
Dmitry Kazakov authored
-
Dmitry Kazakov authored
-
Wolthera van Hövell authored
This was not a good use of an assert, especially as there was no way to check if the swatch is there without having access to the group, which is also what this function searches for...
-
Script Kiddy authored
In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
-
Script Kiddy authored
-
- 04 Jul, 2019 4 commits
-
-
Halla Rempt authored
-
Ivan Yossi authored
toQColor uses current Color colorSpace to convert which avoids the color discrepancy after hitting ok on nativeDialog in macOS. BUG:407880
-
Ivan Yossi authored
-
Ivan Yossi authored
This allows to use null selection objects to temporarly remove selection for stroke selections BUG:409254
-
- 03 Jul, 2019 1 commit
-
-
Dmitry Kazakov authored
On old GPUs that support D3D<=10.0 we cannot use Angle for emulating openGL, therefore we should use some software implementation (or try using D3D9 with its openGLES 2.0). This patch adds an option to select software rasterizer WARP, created by Microsoft, which is a part of DirectX 11 and should be avaailable on all system with Windows 7 and newer. CCBUG:408872
-
- 02 Jul, 2019 2 commits
-
-
Timothée Giet authored
new icon for "Switch to selected snapshot" button
-
Halla Rempt authored
It needs to be a KISTEST_MAIN test because it needs resources.
-